* [U-Boot] Are typedefs discouraged?
@ 2010-10-31 9:01 Reinhard Meyer
2010-10-31 9:28 ` Wolfgang Denk
0 siblings, 1 reply; 4+ messages in thread
From: Reinhard Meyer @ 2010-10-31 9:01 UTC (permalink / raw)
To: u-boot
Hi All,
WARNING: do not add new typedefs
#64: FILE: arch/arm/include/asm/arch-at91/at91_shdwn.h:19:
+typedef struct at91_shdwn {
total: 0 errors, 1 warnings, 45 lines checked
xx has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
I assume that "rule" does not apply to u-boot, and such warnings
can be ignored?
However why would typedefs be discouraged in kernel?
Reinhard
^ permalink raw reply [flat|nested] 4+ messages in thread* [U-Boot] Are typedefs discouraged?
2010-10-31 9:01 [U-Boot] Are typedefs discouraged? Reinhard Meyer
@ 2010-10-31 9:28 ` Wolfgang Denk
2010-10-31 9:45 ` Reinhard Meyer
0 siblings, 1 reply; 4+ messages in thread
From: Wolfgang Denk @ 2010-10-31 9:28 UTC (permalink / raw)
To: u-boot
Dear Reinhard Meyer,
In message <4CCD305D.50600@emk-elektronik.de> you wrote:
> Hi All,
>
> WARNING: do not add new typedefs
> #64: FILE: arch/arm/include/asm/arch-at91/at91_shdwn.h:19:
> +typedef struct at91_shdwn {
>
> total: 0 errors, 1 warnings, 45 lines checked
>
> xx has style problems, please review. If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
>
> I assume that "rule" does not apply to u-boot, and such warnings
> can be ignored?
No.
> However why would typedefs be discouraged in kernel?
Please read "Chapter 5: Typedefs" in the "CodingStyle" document.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
There's a way out of any cage.
-- Captain Christopher Pike, "The Menagerie" ("The Cage"),
stardate unknown.
^ permalink raw reply [flat|nested] 4+ messages in thread* [U-Boot] Are typedefs discouraged?
2010-10-31 9:28 ` Wolfgang Denk
@ 2010-10-31 9:45 ` Reinhard Meyer
2010-10-31 10:36 ` Wolfgang Denk
0 siblings, 1 reply; 4+ messages in thread
From: Reinhard Meyer @ 2010-10-31 9:45 UTC (permalink / raw)
To: u-boot
Dear Wolfgang Denk,
> Please read "Chapter 5: Typedefs" in the "CodingStyle" document.
Since no clause, not even (c) applies, I guess *ALL* at91 header files
and drivers using them need a rework...
Best Regards,
Reinhard
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] Are typedefs discouraged?
2010-10-31 9:45 ` Reinhard Meyer
@ 2010-10-31 10:36 ` Wolfgang Denk
0 siblings, 0 replies; 4+ messages in thread
From: Wolfgang Denk @ 2010-10-31 10:36 UTC (permalink / raw)
To: u-boot
Dear Reinhard Meyer,
In message <4CCD3AAB.7040705@emk-elektronik.de> you wrote:
>
> > Please read "Chapter 5: Typedefs" in the "CodingStyle" document.
> Since no clause, not even (c) applies, I guess *ALL* at91 header files
> and drivers using them need a rework...
Not really.
Just don't add new ones.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The universe is all a spin-off of the Big Bang.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-10-31 10:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-31 9:01 [U-Boot] Are typedefs discouraged? Reinhard Meyer
2010-10-31 9:28 ` Wolfgang Denk
2010-10-31 9:45 ` Reinhard Meyer
2010-10-31 10:36 ` Wolfgang Denk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox