* [PATCH 01/23] board: st: Drop old LED code from stm32f429-disco
2025-11-14 16:23 [PATCH 00/23] stm32: Update led management for STMicroelectronics boards Patrice Chotard
@ 2025-11-14 16:23 ` Patrice Chotard
2025-12-04 13:12 ` Quentin Schulz
2025-11-14 16:23 ` [PATCH 02/23] board: st: Update LED management for stm32mp1 Patrice Chotard
` (22 subsequent siblings)
23 siblings, 1 reply; 54+ messages in thread
From: Patrice Chotard @ 2025-11-14 16:23 UTC (permalink / raw)
To: u-boot
Cc: Patrice CHOTARD, Patrick DELAUNAY, U-Boot STM32, Simon Glass,
Kamil Lulko, Tom Rini
From: Simon Glass <sjg@chromium.org>
This predates the LED framework, so drop it.
Signed-off-by: Simon Glass <sjg@chromium.org>
Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
---
board/st/stm32f429-discovery/Makefile | 1 -
board/st/stm32f429-discovery/led.c | 39 ---------------------------
2 files changed, 40 deletions(-)
delete mode 100644 board/st/stm32f429-discovery/led.c
diff --git a/board/st/stm32f429-discovery/Makefile b/board/st/stm32f429-discovery/Makefile
index 6b02c0fddec..233eafdad3d 100644
--- a/board/st/stm32f429-discovery/Makefile
+++ b/board/st/stm32f429-discovery/Makefile
@@ -7,4 +7,3 @@
# Kamil Lulko, <kamil.lulko@gmail.com>
obj-y := stm32f429-discovery.o
-obj-y += led.o
diff --git a/board/st/stm32f429-discovery/led.c b/board/st/stm32f429-discovery/led.c
deleted file mode 100644
index 4b8038341b9..00000000000
--- a/board/st/stm32f429-discovery/led.c
+++ /dev/null
@@ -1,39 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0+
-/*
- * (C) Copyright 2015
- * Kamil Lulko, <kamil.lulko@gmail.com>
- */
-
-#include <status_led.h>
-#include <asm-generic/gpio.h>
-
-#define RED_LED 110
-#define GREEN_LED 109
-
-void coloured_LED_init(void)
-{
- gpio_request(RED_LED, "red led");
- gpio_direction_output(RED_LED, 0);
- gpio_request(GREEN_LED, "green led");
- gpio_direction_output(GREEN_LED, 0);
-}
-
-void red_led_off(void)
-{
- gpio_set_value(RED_LED, 0);
-}
-
-void green_led_off(void)
-{
- gpio_set_value(GREEN_LED, 0);
-}
-
-void red_led_on(void)
-{
- gpio_set_value(RED_LED, 1);
-}
-
-void green_led_on(void)
-{
- gpio_set_value(GREEN_LED, 1);
-}
--
2.43.0
^ permalink raw reply related [flat|nested] 54+ messages in thread* Re: [PATCH 01/23] board: st: Drop old LED code from stm32f429-disco
2025-11-14 16:23 ` [PATCH 01/23] board: st: Drop old LED code from stm32f429-disco Patrice Chotard
@ 2025-12-04 13:12 ` Quentin Schulz
2025-12-04 14:58 ` Quentin Schulz
0 siblings, 1 reply; 54+ messages in thread
From: Quentin Schulz @ 2025-12-04 13:12 UTC (permalink / raw)
To: Patrice Chotard, u-boot
Cc: Patrick DELAUNAY, U-Boot STM32, Simon Glass, Kamil Lulko,
Tom Rini
Hi Patrice,
On 11/14/25 5:23 PM, Patrice Chotard wrote:
> From: Simon Glass <sjg@chromium.org>
>
> This predates the LED framework, so drop it.
>
Well, we could still use it with the legacy LED API if we enable it, but
stm32f429-discovery_defconfig doesn't, so I guess it's fine?
Since it was disabled, I assume we don't need/want to migrate it to the
new LED framework using DT?
Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>
Thanks!
Quentin
> Signed-off-by: Simon Glass <sjg@chromium.org>
> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
> ---
>
> board/st/stm32f429-discovery/Makefile | 1 -
> board/st/stm32f429-discovery/led.c | 39 ---------------------------
> 2 files changed, 40 deletions(-)
> delete mode 100644 board/st/stm32f429-discovery/led.c
>
> diff --git a/board/st/stm32f429-discovery/Makefile b/board/st/stm32f429-discovery/Makefile
> index 6b02c0fddec..233eafdad3d 100644
> --- a/board/st/stm32f429-discovery/Makefile
> +++ b/board/st/stm32f429-discovery/Makefile
> @@ -7,4 +7,3 @@
> # Kamil Lulko, <kamil.lulko@gmail.com>
>
> obj-y := stm32f429-discovery.o
> -obj-y += led.o
> diff --git a/board/st/stm32f429-discovery/led.c b/board/st/stm32f429-discovery/led.c
> deleted file mode 100644
> index 4b8038341b9..00000000000
> --- a/board/st/stm32f429-discovery/led.c
> +++ /dev/null
> @@ -1,39 +0,0 @@
> -// SPDX-License-Identifier: GPL-2.0+
> -/*
> - * (C) Copyright 2015
> - * Kamil Lulko, <kamil.lulko@gmail.com>
> - */
> -
> -#include <status_led.h>
> -#include <asm-generic/gpio.h>
> -
> -#define RED_LED 110
> -#define GREEN_LED 109
> -
> -void coloured_LED_init(void)
> -{
> - gpio_request(RED_LED, "red led");
> - gpio_direction_output(RED_LED, 0);
> - gpio_request(GREEN_LED, "green led");
> - gpio_direction_output(GREEN_LED, 0);
> -}
> -
> -void red_led_off(void)
> -{
> - gpio_set_value(RED_LED, 0);
> -}
> -
> -void green_led_off(void)
> -{
> - gpio_set_value(GREEN_LED, 0);
> -}
> -
> -void red_led_on(void)
> -{
> - gpio_set_value(RED_LED, 1);
> -}
> -
> -void green_led_on(void)
> -{
> - gpio_set_value(GREEN_LED, 1);
> -}
^ permalink raw reply [flat|nested] 54+ messages in thread* Re: [PATCH 01/23] board: st: Drop old LED code from stm32f429-disco
2025-12-04 13:12 ` Quentin Schulz
@ 2025-12-04 14:58 ` Quentin Schulz
0 siblings, 0 replies; 54+ messages in thread
From: Quentin Schulz @ 2025-12-04 14:58 UTC (permalink / raw)
To: Patrice Chotard, u-boot
Cc: Patrick DELAUNAY, U-Boot STM32, Simon Glass, Kamil Lulko,
Tom Rini
On 12/4/25 2:12 PM, Quentin Schulz wrote:
> Hi Patrice,
>
> On 11/14/25 5:23 PM, Patrice Chotard wrote:
>> From: Simon Glass <sjg@chromium.org>
>>
>> This predates the LED framework, so drop it.
>>
>
> Well, we could still use it with the legacy LED API if we enable it, but
> stm32f429-discovery_defconfig doesn't, so I guess it's fine?
>
> Since it was disabled, I assume we don't need/want to migrate it to the
> new LED framework using DT?
>
OK, this is actually done in patch 4.
Cheers,
Quentin
^ permalink raw reply [flat|nested] 54+ messages in thread
* [PATCH 02/23] board: st: Update LED management for stm32mp1
2025-11-14 16:23 [PATCH 00/23] stm32: Update led management for STMicroelectronics boards Patrice Chotard
2025-11-14 16:23 ` [PATCH 01/23] board: st: Drop old LED code from stm32f429-disco Patrice Chotard
@ 2025-11-14 16:23 ` Patrice Chotard
2025-12-04 15:38 ` Quentin Schulz
2025-11-14 16:23 ` [PATCH 03/23] board: st: Update LED management for stm32mp2 Patrice Chotard
` (21 subsequent siblings)
23 siblings, 1 reply; 54+ messages in thread
From: Patrice Chotard @ 2025-11-14 16:23 UTC (permalink / raw)
To: u-boot
Cc: Patrice CHOTARD, Patrick DELAUNAY, U-Boot STM32, Kory Maincent,
Marek Vasut, Tom Rini
Remove get_led() and setup_led() which became obsolete since
led_boot_on() introduction. led_boot_on() is automatically called
from board_r.c
Regarding "u-boot,error-led" property can't be used anymore since commit
Since commit 516a13e8db32 ("led: update LED boot/activity to new property implementation")
Instead get the LED labeled "red:status".
See kernel series: https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=1022570
Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
---
board/st/stm32mp1/stm32mp1.c | 45 ++++--------------------------------
1 file changed, 4 insertions(+), 41 deletions(-)
diff --git a/board/st/stm32mp1/stm32mp1.c b/board/st/stm32mp1/stm32mp1.c
index cb5cab9f36a..5f7c6822116 100644
--- a/board/st/stm32mp1/stm32mp1.c
+++ b/board/st/stm32mp1/stm32mp1.c
@@ -247,41 +247,6 @@ int g_dnl_bind_fixup(struct usb_device_descriptor *dev, const char *name)
}
#endif /* CONFIG_USB_GADGET_DOWNLOAD */
-static int get_led(struct udevice **dev, char *led_string)
-{
- const char *led_name;
- int ret;
-
- led_name = ofnode_conf_read_str(led_string);
- if (!led_name) {
- log_debug("could not find %s config string\n", led_string);
- return -ENOENT;
- }
- ret = led_get_by_label(led_name, dev);
- if (ret) {
- log_debug("get=%d\n", ret);
- return ret;
- }
-
- return 0;
-}
-
-static int setup_led(enum led_state_t cmd)
-{
- struct udevice *dev;
- int ret;
-
- if (!CONFIG_IS_ENABLED(LED))
- return 0;
-
- ret = get_led(&dev, "u-boot,boot-led");
- if (ret)
- return ret;
-
- ret = led_set_state(dev, cmd);
- return ret;
-}
-
static void __maybe_unused led_error_blink(u32 nb_blink)
{
int ret;
@@ -292,9 +257,9 @@ static void __maybe_unused led_error_blink(u32 nb_blink)
return;
if (CONFIG_IS_ENABLED(LED)) {
- ret = get_led(&led, "u-boot,error-led");
+ ret = led_get_by_label("red:status", &led);
if (!ret) {
- /* make u-boot,error-led blinking */
+ /* make led "red:status" blinking */
/* if U32_MAX and 125ms interval, for 17.02 years */
for (i = 0; i < 2 * nb_blink; i++) {
led_set_state(led, LEDST_TOGGLE);
@@ -418,7 +383,7 @@ static int board_check_usb_power(void)
* If highest and lowest value are either both below
* USB_LOW_THRESHOLD_UV or both above USB_LOW_THRESHOLD_UV, that
* means USB TYPE-C is in unattached mode, this is an issue, make
- * u-boot,error-led blinking and stop boot process.
+ * led "red:status" blinking and stop boot process.
*/
if ((max_uV > USB_LOW_THRESHOLD_UV &&
min_uV > USB_LOW_THRESHOLD_UV) ||
@@ -672,8 +637,6 @@ int board_init(void)
if (IS_ENABLED(CONFIG_ARMV7_NONSEC))
sysconf_init();
- setup_led(LEDST_ON);
-
#if IS_ENABLED(CONFIG_EFI_HAVE_CAPSULE_SUPPORT)
efi_guid_t image_type_guid = STM32MP_FIP_IMAGE_GUID;
@@ -736,7 +699,7 @@ int board_late_init(void)
void board_quiesce_devices(void)
{
- setup_led(LEDST_OFF);
+ led_boot_off();
}
enum env_location env_get_location(enum env_operation op, int prio)
--
2.43.0
^ permalink raw reply related [flat|nested] 54+ messages in thread* Re: [PATCH 02/23] board: st: Update LED management for stm32mp1
2025-11-14 16:23 ` [PATCH 02/23] board: st: Update LED management for stm32mp1 Patrice Chotard
@ 2025-12-04 15:38 ` Quentin Schulz
2025-12-05 9:24 ` Patrice CHOTARD
0 siblings, 1 reply; 54+ messages in thread
From: Quentin Schulz @ 2025-12-04 15:38 UTC (permalink / raw)
To: Patrice Chotard, u-boot
Cc: Patrick DELAUNAY, U-Boot STM32, Kory Maincent, Marek Vasut,
Tom Rini
Hi Patrice,
On 11/14/25 5:23 PM, Patrice Chotard wrote:
> Remove get_led() and setup_led() which became obsolete since
> led_boot_on() introduction. led_boot_on() is automatically called
> from board_r.c
>
Yes, but called later than board_init(). If this compromise is fine then
it's ok.
> Regarding "u-boot,error-led" property can't be used anymore since commit
> Since commit 516a13e8db32 ("led: update LED boot/activity to new property implementation")
>
> Instead get the LED labeled "red:status".
Would this work with stm32mp157a-dhcor-avenger96 (led4),
stm32mp157c-odyssey (red but not "status" as function?) and
stm32mp15xx-dhcom (error but possibly broken since commit
332facce6f5669fc1bb8d150c08cee2ebdae6d2b which removed the led with that
label)? Seems like Odissey has LED=y and LED_GPIO=y so it probably
worked before this patch? The other two, their defconfigs don't seem to
enable LED support (new or legacy) so I guess it never was used anyway?
I'm also wondering how you get this string... I don't see any label or
LED_FUNCTION_STATUS function for the LED devices on ST boards. I'm
probably missing on something?
Cheers,
Quentin
^ permalink raw reply [flat|nested] 54+ messages in thread* Re: [PATCH 02/23] board: st: Update LED management for stm32mp1
2025-12-04 15:38 ` Quentin Schulz
@ 2025-12-05 9:24 ` Patrice CHOTARD
2025-12-05 10:43 ` Quentin Schulz
0 siblings, 1 reply; 54+ messages in thread
From: Patrice CHOTARD @ 2025-12-05 9:24 UTC (permalink / raw)
To: Quentin Schulz, u-boot
Cc: Patrick DELAUNAY, U-Boot STM32, Kory Maincent, Marek Vasut,
Tom Rini
On 12/4/25 16:38, Quentin Schulz wrote:
> Hi Patrice,
>
> On 11/14/25 5:23 PM, Patrice Chotard wrote:
>> Remove get_led() and setup_led() which became obsolete since
>> led_boot_on() introduction. led_boot_on() is automatically called
>> from board_r.c
>>
>
> Yes, but called later than board_init(). If this compromise is fine then it's ok.
>
>> Regarding "u-boot,error-led" property can't be used anymore since commit
>> Since commit 516a13e8db32 ("led: update LED boot/activity to new property implementation")
>>
>> Instead get the LED labeled "red:status".
>
> Would this work with stm32mp157a-dhcor-avenger96 (led4), stm32mp157c-odyssey (red but not "status" as function?) and stm32mp15xx-dhcom (error but possibly broken since commit 332facce6f5669fc1bb8d150c08cee2ebdae6d2b which removed the led with that label)? Seems like Odissey has LED=y and LED_GPIO=y so it probably worked before this patch? The other two, their defconfigs don't seem to enable LED support (new or legacy) so I guess it never was used anyway?
Hi Quentin
Regarding stm32mp157a-dhcor-avenger96, stm32mp157c-odyssey, stm32mp15xx-dhcom, these boards are not
STMicroelectronics board, so i don't maintain them.
>
> I'm also wondering how you get this string... I don't see any label or LED_FUNCTION_STATUS function for the LED devices on ST boards. I'm probably missing on something?
As indicated in the cover-letter, the LED "red:status" has been added in kernel device tree by this serie:
[4] https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=1023034
U-Boot will inherit of these properties when the above kernel serie will be merged and U-Boot device tree
synchronization will be performed.
Thanks
Patrice
>
> Cheers,
> Quentin
^ permalink raw reply [flat|nested] 54+ messages in thread* Re: [PATCH 02/23] board: st: Update LED management for stm32mp1
2025-12-05 9:24 ` Patrice CHOTARD
@ 2025-12-05 10:43 ` Quentin Schulz
2025-12-05 11:04 ` Patrice CHOTARD
0 siblings, 1 reply; 54+ messages in thread
From: Quentin Schulz @ 2025-12-05 10:43 UTC (permalink / raw)
To: Patrice CHOTARD, u-boot
Cc: Patrick DELAUNAY, U-Boot STM32, Kory Maincent, Marek Vasut,
Tom Rini
Hi Patrice,
On 12/5/25 10:24 AM, Patrice CHOTARD wrote:
>
>
> On 12/4/25 16:38, Quentin Schulz wrote:
>> Hi Patrice,
>>
>> On 11/14/25 5:23 PM, Patrice Chotard wrote:
>>> Remove get_led() and setup_led() which became obsolete since
>>> led_boot_on() introduction. led_boot_on() is automatically called
>>> from board_r.c
>>>
>>
>> Yes, but called later than board_init(). If this compromise is fine then it's ok.
>>
>>> Regarding "u-boot,error-led" property can't be used anymore since commit
>>> Since commit 516a13e8db32 ("led: update LED boot/activity to new property implementation")
>>>
>>> Instead get the LED labeled "red:status".
>>
>> Would this work with stm32mp157a-dhcor-avenger96 (led4), stm32mp157c-odyssey (red but not "status" as function?) and stm32mp15xx-dhcom (error but possibly broken since commit 332facce6f5669fc1bb8d150c08cee2ebdae6d2b which removed the led with that label)? Seems like Odissey has LED=y and LED_GPIO=y so it probably worked before this patch? The other two, their defconfigs don't seem to enable LED support (new or legacy) so I guess it never was used anyway?
>
> Hi Quentin
>
> Regarding stm32mp157a-dhcor-avenger96, stm32mp157c-odyssey, stm32mp15xx-dhcom, these boards are not
> STMicroelectronics board, so i don't maintain them.
>
Seems like Marek is handling the DHCOR/DHCOM stuff, and he's in Cc so I
guess there's a chance he sees this and do something about it.
As for Odyssey, you are listed as maintainer but maybe we could add the
people who contributed to it?
I see Marcin Sloniewski, Grzegorz Szymaszek and Heesub Shin for the DT.
According to 69df7ff4b844fb22d02a941d57d8e6c2d6b679dc, you probably
contacted them and had no feedback. But maybe add in the commit log that
this is going to break them and hint at how to fix it maybe? For the
error LED, I guess simply removing the error label and adding the status
function should be enough? That would change the way to interact with
the LED though (when using the label for example).
>>
>> I'm also wondering how you get this string... I don't see any label or LED_FUNCTION_STATUS function for the LED devices on ST boards. I'm probably missing on something?
>
> As indicated in the cover-letter, the LED "red:status" has been added in kernel device tree by this serie:
>
> [4] https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=1023034
>
> U-Boot will inherit of these properties when the above kernel serie will be merged and U-Boot device tree
> synchronization will be performed.
>
So are we supposed to wait on those patches being sync'ed with U-Boot in
order to merge this series? Because if I understood correctly, this will
break LED support that currently should be working.
I personally don't care what you're doing with the STM boards, but I
depend on this series to be merged to continue the work on removing
legacy LED support (which I also don't care too much about but now that
there are patches for it, let's finish this :) ). So if 1 or 2 releases
of broken LED support until the Linux kernel DT is sync'ed in U-Boot is
fine with you, that's fine with me as well. We could also edit
-u-boot.dtsi DTS manually until the sync and have the best of both worlds.
Cheers,
Quentin
^ permalink raw reply [flat|nested] 54+ messages in thread* Re: [PATCH 02/23] board: st: Update LED management for stm32mp1
2025-12-05 10:43 ` Quentin Schulz
@ 2025-12-05 11:04 ` Patrice CHOTARD
0 siblings, 0 replies; 54+ messages in thread
From: Patrice CHOTARD @ 2025-12-05 11:04 UTC (permalink / raw)
To: Quentin Schulz, u-boot
Cc: Patrick DELAUNAY, U-Boot STM32, Kory Maincent, Marek Vasut,
Tom Rini
On 12/5/25 11:43, Quentin Schulz wrote:
> Hi Patrice,
>
> On 12/5/25 10:24 AM, Patrice CHOTARD wrote:
>>
>>
>> On 12/4/25 16:38, Quentin Schulz wrote:
>>> Hi Patrice,
>>>
>>> On 11/14/25 5:23 PM, Patrice Chotard wrote:
>>>> Remove get_led() and setup_led() which became obsolete since
>>>> led_boot_on() introduction. led_boot_on() is automatically called
>>>> from board_r.c
>>>>
>>>
>>> Yes, but called later than board_init(). If this compromise is fine then it's ok.
>>>
>>>> Regarding "u-boot,error-led" property can't be used anymore since commit
>>>> Since commit 516a13e8db32 ("led: update LED boot/activity to new property implementation")
>>>>
>>>> Instead get the LED labeled "red:status".
>>>
>>> Would this work with stm32mp157a-dhcor-avenger96 (led4), stm32mp157c-odyssey (red but not "status" as function?) and stm32mp15xx-dhcom (error but possibly broken since commit 332facce6f5669fc1bb8d150c08cee2ebdae6d2b which removed the led with that label)? Seems like Odissey has LED=y and LED_GPIO=y so it probably worked before this patch? The other two, their defconfigs don't seem to enable LED support (new or legacy) so I guess it never was used anyway?
>>
>> Hi Quentin
>>
>> Regarding stm32mp157a-dhcor-avenger96, stm32mp157c-odyssey, stm32mp15xx-dhcom, these boards are not
>> STMicroelectronics board, so i don't maintain them.
>>
>
> Seems like Marek is handling the DHCOR/DHCOM stuff, and he's in Cc so I guess there's a chance he sees this and do something about it.
>
> As for Odyssey, you are listed as maintainer but maybe we could add the people who contributed to it?
> I see Marcin Sloniewski, Grzegorz Szymaszek and Heesub Shin for the DT. According to 69df7ff4b844fb22d02a941d57d8e6c2d6b679dc, you probably contacted them and had no feedback. But maybe add in the commit log that this is going to break them and hint at how to fix it maybe? For the error LED, I guess simply removing the error label and adding the status function should be enough? That would change the way to interact with the LED though (when using the label for example).
I have already try to contact these people you mentioned when i converted STMicroelectronics
boards to CONFIG_UPSTREAM flags but unfortunately none of them replied.
>
>>>
>>> I'm also wondering how you get this string... I don't see any label or LED_FUNCTION_STATUS function for the LED devices on ST boards. I'm probably missing on something?
>>
>> As indicated in the cover-letter, the LED "red:status" has been added in kernel device tree by this serie:
>>
>> [4] https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=1023034
>>
>> U-Boot will inherit of these properties when the above kernel serie will be merged and U-Boot device tree
>> synchronization will be performed.
>>
>
> So are we supposed to wait on those patches being sync'ed with U-Boot in order to merge this series? Because if I understood correctly, this will break LED support that currently should be working.
I will not wait the DT sync to merge this series, i was just waiting for review from my
colleague Patrick Delaunay or from other people present on the mailing list.
As you have reviewed this serie, i will submit a pull request for U-Boot next.
>
> I personally don't care what you're doing with the STM boards, but I depend on this series to be merged to continue the work on removing legacy LED support (which I also don't care too much about but now that there are patches for it, let's finish this :) ). So if 1 or 2 releases of broken LED support until the Linux kernel DT is sync'ed in U-Boot is fine with you, that's fine with me as well. We could also edit -u-boot.dtsi DTS manually until the sync and have the best of both worlds.
Thanks
Patrice
>
> Cheers,
> Quentin
^ permalink raw reply [flat|nested] 54+ messages in thread
* [PATCH 03/23] board: st: Update LED management for stm32mp2
2025-11-14 16:23 [PATCH 00/23] stm32: Update led management for STMicroelectronics boards Patrice Chotard
2025-11-14 16:23 ` [PATCH 01/23] board: st: Drop old LED code from stm32f429-disco Patrice Chotard
2025-11-14 16:23 ` [PATCH 02/23] board: st: Update LED management for stm32mp1 Patrice Chotard
@ 2025-11-14 16:23 ` Patrice Chotard
2025-12-04 15:43 ` Quentin Schulz
2025-11-14 16:23 ` [PATCH 04/23] configs: stm32: Enable LED config flags for stm32f429-disco Patrice Chotard
` (20 subsequent siblings)
23 siblings, 1 reply; 54+ messages in thread
From: Patrice Chotard @ 2025-11-14 16:23 UTC (permalink / raw)
To: u-boot
Cc: Patrice CHOTARD, Patrick DELAUNAY, U-Boot STM32, Marek Vasut,
Tom Rini
Remove get_led() and setup_led() which became obsolete since
led_boot_on() introduction. led_boot_on() is automatically called
from board_r.c
Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
---
board/st/stm32mp2/stm32mp2.c | 38 +-----------------------------------
1 file changed, 1 insertion(+), 37 deletions(-)
diff --git a/board/st/stm32mp2/stm32mp2.c b/board/st/stm32mp2/stm32mp2.c
index a72056e12d6..7bc7d2a608f 100644
--- a/board/st/stm32mp2/stm32mp2.c
+++ b/board/st/stm32mp2/stm32mp2.c
@@ -58,41 +58,6 @@ int checkboard(void)
return 0;
}
-static int get_led(struct udevice **dev, char *led_string)
-{
- const char *led_name;
- int ret;
-
- led_name = ofnode_conf_read_str(led_string);
- if (!led_name) {
- log_debug("could not find %s config string\n", led_string);
- return -ENOENT;
- }
- ret = led_get_by_label(led_name, dev);
- if (ret) {
- log_debug("get=%d\n", ret);
- return ret;
- }
-
- return 0;
-}
-
-static int setup_led(enum led_state_t cmd)
-{
- struct udevice *dev;
- int ret;
-
- if (!CONFIG_IS_ENABLED(LED))
- return 0;
-
- ret = get_led(&dev, "u-boot,boot-led");
- if (ret)
- return ret;
-
- ret = led_set_state(dev, cmd);
- return ret;
-}
-
static void check_user_button(void)
{
struct udevice *button;
@@ -118,7 +83,6 @@ static void check_user_button(void)
/* board dependent setup after realloc */
int board_init(void)
{
- setup_led(LEDST_ON);
check_user_button();
return 0;
@@ -222,5 +186,5 @@ int board_late_init(void)
void board_quiesce_devices(void)
{
- setup_led(LEDST_OFF);
+ led_boot_off();
}
--
2.43.0
^ permalink raw reply related [flat|nested] 54+ messages in thread* [PATCH 04/23] configs: stm32: Enable LED config flags for stm32f429-disco
2025-11-14 16:23 [PATCH 00/23] stm32: Update led management for STMicroelectronics boards Patrice Chotard
` (2 preceding siblings ...)
2025-11-14 16:23 ` [PATCH 03/23] board: st: Update LED management for stm32mp2 Patrice Chotard
@ 2025-11-14 16:23 ` Patrice Chotard
2025-12-04 15:46 ` Quentin Schulz
2025-11-14 16:23 ` [PATCH 05/23] " Patrice Chotard
` (19 subsequent siblings)
23 siblings, 1 reply; 54+ messages in thread
From: Patrice Chotard @ 2025-11-14 16:23 UTC (permalink / raw)
To: u-boot
Cc: Patrice CHOTARD, Patrick DELAUNAY, U-Boot STM32, Kamil Lulko,
Peng Fan, Sam Protsenko, Tom Rini
Enable LED, LED_BOOT and LED_GPIO flags.
Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
---
configs/stm32f429-discovery_defconfig | 3 +++
1 file changed, 3 insertions(+)
diff --git a/configs/stm32f429-discovery_defconfig b/configs/stm32f429-discovery_defconfig
index 45dc8bb0cee..2195b8867dd 100644
--- a/configs/stm32f429-discovery_defconfig
+++ b/configs/stm32f429-discovery_defconfig
@@ -29,6 +29,9 @@ CONFIG_CMD_TIMER=y
CONFIG_OF_CONTROL=y
CONFIG_ENV_IS_IN_FLASH=y
CONFIG_NO_NET=y
+CONFIG_LED=y
+CONFIG_LED_BOOT=y
+CONFIG_LED_GPIO=y
# CONFIG_MMC is not set
CONFIG_MTD=y
CONFIG_MTD_NOR_FLASH=y
--
2.43.0
^ permalink raw reply related [flat|nested] 54+ messages in thread* Re: [PATCH 04/23] configs: stm32: Enable LED config flags for stm32f429-disco
2025-11-14 16:23 ` [PATCH 04/23] configs: stm32: Enable LED config flags for stm32f429-disco Patrice Chotard
@ 2025-12-04 15:46 ` Quentin Schulz
0 siblings, 0 replies; 54+ messages in thread
From: Quentin Schulz @ 2025-12-04 15:46 UTC (permalink / raw)
To: Patrice Chotard, u-boot
Cc: Patrick DELAUNAY, U-Boot STM32, Kamil Lulko, Peng Fan,
Sam Protsenko, Tom Rini
Hi Patrice,
On 11/14/25 5:23 PM, Patrice Chotard wrote:
> Enable LED, LED_BOOT and LED_GPIO flags.
>
Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>
Thanks!
Quentin
^ permalink raw reply [flat|nested] 54+ messages in thread
* [PATCH 05/23] configs: stm32: Enable LED config flags for stm32f429-disco
2025-11-14 16:23 [PATCH 00/23] stm32: Update led management for STMicroelectronics boards Patrice Chotard
` (3 preceding siblings ...)
2025-11-14 16:23 ` [PATCH 04/23] configs: stm32: Enable LED config flags for stm32f429-disco Patrice Chotard
@ 2025-11-14 16:23 ` Patrice Chotard
2025-12-04 15:50 ` Quentin Schulz
2025-11-14 16:23 ` [PATCH 06/23] configs: stm32: Enable LED config flags for stm32f746-disco Patrice Chotard
` (18 subsequent siblings)
23 siblings, 1 reply; 54+ messages in thread
From: Patrice Chotard @ 2025-11-14 16:23 UTC (permalink / raw)
To: u-boot
Cc: Patrice CHOTARD, Patrick DELAUNAY, U-Boot STM32, Marek Vasut,
Peng Fan, Sam Protsenko, Tom Rini
Enable LED, LED_BOOT and LED_GPIO flags.
Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
---
configs/stm32f469-discovery_defconfig | 3 +++
1 file changed, 3 insertions(+)
diff --git a/configs/stm32f469-discovery_defconfig b/configs/stm32f469-discovery_defconfig
index f0aab073bae..37e48698123 100644
--- a/configs/stm32f469-discovery_defconfig
+++ b/configs/stm32f469-discovery_defconfig
@@ -29,6 +29,9 @@ CONFIG_CMD_TIMER=y
CONFIG_OF_CONTROL=y
CONFIG_ENV_RELOC_GD_ENV_ADDR=y
CONFIG_NO_NET=y
+CONFIG_LED=y
+CONFIG_LED_BOOT=y
+CONFIG_LED_GPIO=y
CONFIG_ARM_PL180_MMCI=y
CONFIG_MTD=y
CONFIG_DM_MTD=y
--
2.43.0
^ permalink raw reply related [flat|nested] 54+ messages in thread* Re: [PATCH 05/23] configs: stm32: Enable LED config flags for stm32f429-disco
2025-11-14 16:23 ` [PATCH 05/23] " Patrice Chotard
@ 2025-12-04 15:50 ` Quentin Schulz
0 siblings, 0 replies; 54+ messages in thread
From: Quentin Schulz @ 2025-12-04 15:50 UTC (permalink / raw)
To: Patrice Chotard, u-boot
Cc: Patrick DELAUNAY, U-Boot STM32, Marek Vasut, Peng Fan,
Sam Protsenko, Tom Rini
Hi Patrice,
Typo in the commit title, should be stm32f469-disco instead of
stm32f429-disco.
On 11/14/25 5:23 PM, Patrice Chotard wrote:
> Enable LED, LED_BOOT and LED_GPIO flags.
>
Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>
Thanks!
Quentin
^ permalink raw reply [flat|nested] 54+ messages in thread
* [PATCH 06/23] configs: stm32: Enable LED config flags for stm32f746-disco
2025-11-14 16:23 [PATCH 00/23] stm32: Update led management for STMicroelectronics boards Patrice Chotard
` (4 preceding siblings ...)
2025-11-14 16:23 ` [PATCH 05/23] " Patrice Chotard
@ 2025-11-14 16:23 ` Patrice Chotard
2025-12-04 16:00 ` Quentin Schulz
2025-11-14 16:23 ` [PATCH 07/23] configs: stm32: Enable LED config flags for stm32f769-disco Patrice Chotard
` (17 subsequent siblings)
23 siblings, 1 reply; 54+ messages in thread
From: Patrice Chotard @ 2025-11-14 16:23 UTC (permalink / raw)
To: u-boot
Cc: Patrice CHOTARD, Patrick DELAUNAY, U-Boot STM32, Dario Binacchi,
Marek Vasut, Tom Rini
Enable LED, LED_BOOT and LED_GPIO flags.
Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
---
configs/stm32f746-disco_defconfig | 3 +++
1 file changed, 3 insertions(+)
diff --git a/configs/stm32f746-disco_defconfig b/configs/stm32f746-disco_defconfig
index 1e39569c055..cd601e72791 100644
--- a/configs/stm32f746-disco_defconfig
+++ b/configs/stm32f746-disco_defconfig
@@ -37,6 +37,9 @@ CONFIG_OF_CONTROL=y
CONFIG_ENV_RELOC_GD_ENV_ADDR=y
CONFIG_NETCONSOLE=y
CONFIG_NET_RANDOM_ETHADDR=y
+CONFIG_LED=y
+CONFIG_LED_BOOT=y
+CONFIG_LED_GPIO=y
CONFIG_ARM_PL180_MMCI=y
CONFIG_MTD=y
CONFIG_DM_MTD=y
--
2.43.0
^ permalink raw reply related [flat|nested] 54+ messages in thread* [PATCH 07/23] configs: stm32: Enable LED config flags for stm32f769-disco
2025-11-14 16:23 [PATCH 00/23] stm32: Update led management for STMicroelectronics boards Patrice Chotard
` (5 preceding siblings ...)
2025-11-14 16:23 ` [PATCH 06/23] configs: stm32: Enable LED config flags for stm32f746-disco Patrice Chotard
@ 2025-11-14 16:23 ` Patrice Chotard
2025-12-04 16:03 ` Quentin Schulz
2025-11-14 16:23 ` [PATCH 08/23] configs: stm32: Enable LED config flags for stm32h743-disco Patrice Chotard
` (16 subsequent siblings)
23 siblings, 1 reply; 54+ messages in thread
From: Patrice Chotard @ 2025-11-14 16:23 UTC (permalink / raw)
To: u-boot
Cc: Patrice CHOTARD, Patrick DELAUNAY, U-Boot STM32, Dario Binacchi,
Linus Walleij, Marek Vasut, Tom Rini
Enable LED, LED_BOOT and LED_GPIO flags.
Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
---
configs/stm32f769-disco_defconfig | 3 +++
1 file changed, 3 insertions(+)
diff --git a/configs/stm32f769-disco_defconfig b/configs/stm32f769-disco_defconfig
index 8cda9e3dff8..5eafb6842e2 100644
--- a/configs/stm32f769-disco_defconfig
+++ b/configs/stm32f769-disco_defconfig
@@ -38,6 +38,9 @@ CONFIG_OF_CONTROL=y
CONFIG_ENV_RELOC_GD_ENV_ADDR=y
CONFIG_NETCONSOLE=y
CONFIG_NET_RANDOM_ETHADDR=y
+CONFIG_LED=y
+CONFIG_LED_BOOT=y
+CONFIG_LED_GPIO=y
CONFIG_ARM_PL180_MMCI=y
CONFIG_MTD=y
CONFIG_DM_MTD=y
--
2.43.0
^ permalink raw reply related [flat|nested] 54+ messages in thread* Re: [PATCH 07/23] configs: stm32: Enable LED config flags for stm32f769-disco
2025-11-14 16:23 ` [PATCH 07/23] configs: stm32: Enable LED config flags for stm32f769-disco Patrice Chotard
@ 2025-12-04 16:03 ` Quentin Schulz
0 siblings, 0 replies; 54+ messages in thread
From: Quentin Schulz @ 2025-12-04 16:03 UTC (permalink / raw)
To: Patrice Chotard, u-boot
Cc: Patrick DELAUNAY, U-Boot STM32, Dario Binacchi, Linus Walleij,
Marek Vasut, Tom Rini
Hi Patrice,
On 11/14/25 5:23 PM, Patrice Chotard wrote:
> Enable LED, LED_BOOT and LED_GPIO flags.
>
Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>
Thanks!
Quentin
^ permalink raw reply [flat|nested] 54+ messages in thread
* [PATCH 08/23] configs: stm32: Enable LED config flags for stm32h743-disco
2025-11-14 16:23 [PATCH 00/23] stm32: Update led management for STMicroelectronics boards Patrice Chotard
` (6 preceding siblings ...)
2025-11-14 16:23 ` [PATCH 07/23] configs: stm32: Enable LED config flags for stm32f769-disco Patrice Chotard
@ 2025-11-14 16:23 ` Patrice Chotard
2025-12-04 16:03 ` Quentin Schulz
2025-11-14 16:23 ` [PATCH 09/23] configs: stm32: Enable LED config flags for stm32h743-eval Patrice Chotard
` (15 subsequent siblings)
23 siblings, 1 reply; 54+ messages in thread
From: Patrice Chotard @ 2025-11-14 16:23 UTC (permalink / raw)
To: u-boot
Cc: Patrice CHOTARD, Patrick DELAUNAY, U-Boot STM32, Marek Vasut,
Peng Fan, Sam Protsenko, Tom Rini
Enable LED, LED_BOOT and LED_GPIO flags.
Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
---
configs/stm32h743-disco_defconfig | 3 +++
1 file changed, 3 insertions(+)
diff --git a/configs/stm32h743-disco_defconfig b/configs/stm32h743-disco_defconfig
index 5818e68ff7e..d0e2c95df25 100644
--- a/configs/stm32h743-disco_defconfig
+++ b/configs/stm32h743-disco_defconfig
@@ -32,5 +32,8 @@ CONFIG_CMD_EXT4_WRITE=y
CONFIG_OF_CONTROL=y
CONFIG_ENV_RELOC_GD_ENV_ADDR=y
CONFIG_NO_NET=y
+CONFIG_LED=y
+CONFIG_LED_BOOT=y
+CONFIG_LED_GPIO=y
CONFIG_STM32_SDMMC2=y
# CONFIG_PINCTRL_FULL is not set
--
2.43.0
^ permalink raw reply related [flat|nested] 54+ messages in thread* Re: [PATCH 08/23] configs: stm32: Enable LED config flags for stm32h743-disco
2025-11-14 16:23 ` [PATCH 08/23] configs: stm32: Enable LED config flags for stm32h743-disco Patrice Chotard
@ 2025-12-04 16:03 ` Quentin Schulz
0 siblings, 0 replies; 54+ messages in thread
From: Quentin Schulz @ 2025-12-04 16:03 UTC (permalink / raw)
To: Patrice Chotard, u-boot
Cc: Patrick DELAUNAY, U-Boot STM32, Marek Vasut, Peng Fan,
Sam Protsenko, Tom Rini
Hi Patrice,
On 11/14/25 5:23 PM, Patrice Chotard wrote:
> Enable LED, LED_BOOT and LED_GPIO flags.
>
Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>
Thanks!
Quentin
^ permalink raw reply [flat|nested] 54+ messages in thread
* [PATCH 09/23] configs: stm32: Enable LED config flags for stm32h743-eval
2025-11-14 16:23 [PATCH 00/23] stm32: Update led management for STMicroelectronics boards Patrice Chotard
` (7 preceding siblings ...)
2025-11-14 16:23 ` [PATCH 08/23] configs: stm32: Enable LED config flags for stm32h743-disco Patrice Chotard
@ 2025-11-14 16:23 ` Patrice Chotard
2025-12-04 16:04 ` Quentin Schulz
2025-11-14 16:23 ` [PATCH 10/23] configs: stm32: Enable LED config flags for stm32h747-disco Patrice Chotard
` (14 subsequent siblings)
23 siblings, 1 reply; 54+ messages in thread
From: Patrice Chotard @ 2025-11-14 16:23 UTC (permalink / raw)
To: u-boot
Cc: Patrice CHOTARD, Patrick DELAUNAY, U-Boot STM32, Marek Vasut,
Peng Fan, Sam Protsenko, Tom Rini
Enable LED, LED_BOOT and LED_GPIO flags.
Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
---
configs/stm32h743-eval_defconfig | 3 +++
1 file changed, 3 insertions(+)
diff --git a/configs/stm32h743-eval_defconfig b/configs/stm32h743-eval_defconfig
index 3ee8d082da8..5384592b1fd 100644
--- a/configs/stm32h743-eval_defconfig
+++ b/configs/stm32h743-eval_defconfig
@@ -32,5 +32,8 @@ CONFIG_CMD_EXT4_WRITE=y
CONFIG_OF_CONTROL=y
CONFIG_ENV_RELOC_GD_ENV_ADDR=y
CONFIG_NO_NET=y
+CONFIG_LED=y
+CONFIG_LED_BOOT=y
+CONFIG_LED_GPIO=y
CONFIG_STM32_SDMMC2=y
# CONFIG_PINCTRL_FULL is not set
--
2.43.0
^ permalink raw reply related [flat|nested] 54+ messages in thread* Re: [PATCH 09/23] configs: stm32: Enable LED config flags for stm32h743-eval
2025-11-14 16:23 ` [PATCH 09/23] configs: stm32: Enable LED config flags for stm32h743-eval Patrice Chotard
@ 2025-12-04 16:04 ` Quentin Schulz
0 siblings, 0 replies; 54+ messages in thread
From: Quentin Schulz @ 2025-12-04 16:04 UTC (permalink / raw)
To: Patrice Chotard, u-boot
Cc: Patrick DELAUNAY, U-Boot STM32, Marek Vasut, Peng Fan,
Sam Protsenko, Tom Rini
Hi Patrice,
On 11/14/25 5:23 PM, Patrice Chotard wrote:
> Enable LED, LED_BOOT and LED_GPIO flags.
>
Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>
Thanks!
Quentin
^ permalink raw reply [flat|nested] 54+ messages in thread
* [PATCH 10/23] configs: stm32: Enable LED config flags for stm32h747-disco
2025-11-14 16:23 [PATCH 00/23] stm32: Update led management for STMicroelectronics boards Patrice Chotard
` (8 preceding siblings ...)
2025-11-14 16:23 ` [PATCH 09/23] configs: stm32: Enable LED config flags for stm32h743-eval Patrice Chotard
@ 2025-11-14 16:23 ` Patrice Chotard
2025-12-04 16:04 ` Quentin Schulz
2025-11-14 16:23 ` [PATCH 11/23] configs: stm32mp13: Enable LED_BOOT for stm32mp13_defconfig Patrice Chotard
` (13 subsequent siblings)
23 siblings, 1 reply; 54+ messages in thread
From: Patrice Chotard @ 2025-11-14 16:23 UTC (permalink / raw)
To: u-boot
Cc: Patrice CHOTARD, Patrick DELAUNAY, U-Boot STM32, Dario Binacchi,
Peng Fan, Sam Protsenko, Tom Rini
Enable LED, LED_BOOT and LED_GPIO flags.
Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
---
configs/stm32h747-disco_defconfig | 3 +++
1 file changed, 3 insertions(+)
diff --git a/configs/stm32h747-disco_defconfig b/configs/stm32h747-disco_defconfig
index bea1fa5a809..3db7eea238b 100644
--- a/configs/stm32h747-disco_defconfig
+++ b/configs/stm32h747-disco_defconfig
@@ -32,5 +32,8 @@ CONFIG_CMD_EXT4_WRITE=y
CONFIG_OF_CONTROL=y
CONFIG_ENV_RELOC_GD_ENV_ADDR=y
CONFIG_NO_NET=y
+CONFIG_LED=y
+CONFIG_LED_BOOT=y
+CONFIG_LED_GPIO=y
CONFIG_STM32_SDMMC2=y
# CONFIG_PINCTRL_FULL is not set
--
2.43.0
^ permalink raw reply related [flat|nested] 54+ messages in thread* Re: [PATCH 10/23] configs: stm32: Enable LED config flags for stm32h747-disco
2025-11-14 16:23 ` [PATCH 10/23] configs: stm32: Enable LED config flags for stm32h747-disco Patrice Chotard
@ 2025-12-04 16:04 ` Quentin Schulz
0 siblings, 0 replies; 54+ messages in thread
From: Quentin Schulz @ 2025-12-04 16:04 UTC (permalink / raw)
To: Patrice Chotard, u-boot
Cc: Patrick DELAUNAY, U-Boot STM32, Dario Binacchi, Peng Fan,
Sam Protsenko, Tom Rini
Hi Patrice,
On 11/14/25 5:23 PM, Patrice Chotard wrote:
> Enable LED, LED_BOOT and LED_GPIO flags.
>
Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>
Thanks!
Quentin
^ permalink raw reply [flat|nested] 54+ messages in thread
* [PATCH 11/23] configs: stm32mp13: Enable LED_BOOT for stm32mp13_defconfig
2025-11-14 16:23 [PATCH 00/23] stm32: Update led management for STMicroelectronics boards Patrice Chotard
` (9 preceding siblings ...)
2025-11-14 16:23 ` [PATCH 10/23] configs: stm32: Enable LED config flags for stm32h747-disco Patrice Chotard
@ 2025-11-14 16:23 ` Patrice Chotard
2025-12-04 16:08 ` Quentin Schulz
2025-11-14 16:23 ` [PATCH 12/23] configs: stm32mp15: Enable LED_BOOT for stm32mp15_defconfig Patrice Chotard
` (12 subsequent siblings)
23 siblings, 1 reply; 54+ messages in thread
From: Patrice Chotard @ 2025-11-14 16:23 UTC (permalink / raw)
To: u-boot
Cc: Patrice CHOTARD, Patrick DELAUNAY, U-Boot STM32, Cheick Traore,
Marek Vasut, Tom Rini
Enable LED_BOOT to use led_boot_on/off() API in board file.
Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
---
configs/stm32mp13_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/configs/stm32mp13_defconfig b/configs/stm32mp13_defconfig
index 3283e910219..7367525dda0 100644
--- a/configs/stm32mp13_defconfig
+++ b/configs/stm32mp13_defconfig
@@ -72,6 +72,7 @@ CONFIG_GPIO_HOG=y
CONFIG_DM_I2C=y
CONFIG_SYS_I2C_STM32F7=y
CONFIG_LED=y
+CONFIG_LED_BOOT=y
CONFIG_LED_GPIO=y
CONFIG_SUPPORT_EMMC_BOOT=y
CONFIG_STM32_SDMMC2=y
--
2.43.0
^ permalink raw reply related [flat|nested] 54+ messages in thread* Re: [PATCH 11/23] configs: stm32mp13: Enable LED_BOOT for stm32mp13_defconfig
2025-11-14 16:23 ` [PATCH 11/23] configs: stm32mp13: Enable LED_BOOT for stm32mp13_defconfig Patrice Chotard
@ 2025-12-04 16:08 ` Quentin Schulz
0 siblings, 0 replies; 54+ messages in thread
From: Quentin Schulz @ 2025-12-04 16:08 UTC (permalink / raw)
To: Patrice Chotard, u-boot
Cc: Patrick DELAUNAY, U-Boot STM32, Cheick Traore, Marek Vasut,
Tom Rini
Hi Patrice,
On 11/14/25 5:23 PM, Patrice Chotard wrote:
> Enable LED_BOOT to use led_boot_on/off() API in board file.
>
Note that the first BOOTP packet will turn off the boot LED, c.f.
https://elixir.bootlin.com/u-boot/v2025.10/source/net/bootp.c#L392 which
will be switched over to the new API, c.f.
https://lore.kernel.org/u-boot/20251120-legacy-led-removal-v1-1-369d44338358@cherry.de/
Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>
Thanks!
Quentin
^ permalink raw reply [flat|nested] 54+ messages in thread
* [PATCH 12/23] configs: stm32mp15: Enable LED_BOOT for stm32mp15_defconfig
2025-11-14 16:23 [PATCH 00/23] stm32: Update led management for STMicroelectronics boards Patrice Chotard
` (10 preceding siblings ...)
2025-11-14 16:23 ` [PATCH 11/23] configs: stm32mp13: Enable LED_BOOT for stm32mp13_defconfig Patrice Chotard
@ 2025-11-14 16:23 ` Patrice Chotard
2025-12-04 16:11 ` Quentin Schulz
2025-11-14 16:23 ` [PATCH 13/23] configs: stm32mp15: Enable LED_BOOT for stm32mp15_basic_defconfig Patrice Chotard
` (11 subsequent siblings)
23 siblings, 1 reply; 54+ messages in thread
From: Patrice Chotard @ 2025-11-14 16:23 UTC (permalink / raw)
To: u-boot
Cc: Patrice CHOTARD, Patrick DELAUNAY, U-Boot STM32, Marek Vasut,
Tom Rini
Enable LED_BOOT to use led_boot_on/off() API in board file.
Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
---
configs/stm32mp15_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/configs/stm32mp15_defconfig b/configs/stm32mp15_defconfig
index b3ec3898861..c13bc1d0360 100644
--- a/configs/stm32mp15_defconfig
+++ b/configs/stm32mp15_defconfig
@@ -94,6 +94,7 @@ CONFIG_HWSPINLOCK_STM32=y
CONFIG_DM_I2C=y
CONFIG_SYS_I2C_STM32F7=y
CONFIG_LED=y
+CONFIG_LED_BOOT=y
CONFIG_LED_GPIO=y
CONFIG_STM32_FMC2_EBI=y
CONFIG_SUPPORT_EMMC_BOOT=y
--
2.43.0
^ permalink raw reply related [flat|nested] 54+ messages in thread* [PATCH 13/23] configs: stm32mp15: Enable LED_BOOT for stm32mp15_basic_defconfig
2025-11-14 16:23 [PATCH 00/23] stm32: Update led management for STMicroelectronics boards Patrice Chotard
` (11 preceding siblings ...)
2025-11-14 16:23 ` [PATCH 12/23] configs: stm32mp15: Enable LED_BOOT for stm32mp15_defconfig Patrice Chotard
@ 2025-11-14 16:23 ` Patrice Chotard
2025-12-04 16:14 ` Quentin Schulz
2025-11-14 16:23 ` [PATCH 14/23] configs: stm32mp15: Enable LED_BOOT for stm32mp15_trusted_defconfig Patrice Chotard
` (10 subsequent siblings)
23 siblings, 1 reply; 54+ messages in thread
From: Patrice Chotard @ 2025-11-14 16:23 UTC (permalink / raw)
To: u-boot
Cc: Patrice CHOTARD, Patrick DELAUNAY, U-Boot STM32, Antonio Borneo,
Marek Vasut, Simon Glass, Tom Rini
Enable LED_BOOT to use led_boot_on/off() API in board file.
Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
---
configs/stm32mp15_basic_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/configs/stm32mp15_basic_defconfig b/configs/stm32mp15_basic_defconfig
index 79593cce9fe..15edea314f2 100644
--- a/configs/stm32mp15_basic_defconfig
+++ b/configs/stm32mp15_basic_defconfig
@@ -123,6 +123,7 @@ CONFIG_HWSPINLOCK_STM32=y
CONFIG_DM_I2C=y
CONFIG_SYS_I2C_STM32F7=y
CONFIG_LED=y
+CONFIG_LED_BOOT=y
CONFIG_LED_GPIO=y
CONFIG_STM32_FMC2_EBI=y
CONFIG_SUPPORT_EMMC_BOOT=y
--
2.43.0
^ permalink raw reply related [flat|nested] 54+ messages in thread* Re: [PATCH 13/23] configs: stm32mp15: Enable LED_BOOT for stm32mp15_basic_defconfig
2025-11-14 16:23 ` [PATCH 13/23] configs: stm32mp15: Enable LED_BOOT for stm32mp15_basic_defconfig Patrice Chotard
@ 2025-12-04 16:14 ` Quentin Schulz
0 siblings, 0 replies; 54+ messages in thread
From: Quentin Schulz @ 2025-12-04 16:14 UTC (permalink / raw)
To: Patrice Chotard, u-boot
Cc: Patrick DELAUNAY, U-Boot STM32, Antonio Borneo, Marek Vasut,
Simon Glass, Tom Rini
Hi Patrice,
On 11/14/25 5:23 PM, Patrice Chotard wrote:
> Enable LED_BOOT to use led_boot_on/off() API in board file.
>
Same as feedback on two previous patches and it also obviously depend on
the /options/u-boot/boot-led property being set, but that is sent to the
Linux ML already so hopefully it'll make it to U-Boot 2026.04 :)
Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>
Thanks!
Quentin
^ permalink raw reply [flat|nested] 54+ messages in thread
* [PATCH 14/23] configs: stm32mp15: Enable LED_BOOT for stm32mp15_trusted_defconfig
2025-11-14 16:23 [PATCH 00/23] stm32: Update led management for STMicroelectronics boards Patrice Chotard
` (12 preceding siblings ...)
2025-11-14 16:23 ` [PATCH 13/23] configs: stm32mp15: Enable LED_BOOT for stm32mp15_basic_defconfig Patrice Chotard
@ 2025-11-14 16:23 ` Patrice Chotard
2025-12-04 16:19 ` Quentin Schulz
2025-11-14 16:23 ` [PATCH 15/23] configs: stm32mp2: Enable LED_BOOT for stm32mp25_defconfig Patrice Chotard
` (9 subsequent siblings)
23 siblings, 1 reply; 54+ messages in thread
From: Patrice Chotard @ 2025-11-14 16:23 UTC (permalink / raw)
To: u-boot
Cc: Patrice CHOTARD, Patrick DELAUNAY, U-Boot STM32, Marek Vasut,
Tom Rini
Enable LED_BOOT to use led_boot_on/off() API in board file.
Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
---
configs/stm32mp15_trusted_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/configs/stm32mp15_trusted_defconfig b/configs/stm32mp15_trusted_defconfig
index 09383ed4824..77684c0e8c9 100644
--- a/configs/stm32mp15_trusted_defconfig
+++ b/configs/stm32mp15_trusted_defconfig
@@ -95,6 +95,7 @@ CONFIG_HWSPINLOCK_STM32=y
CONFIG_DM_I2C=y
CONFIG_SYS_I2C_STM32F7=y
CONFIG_LED=y
+CONFIG_LED_BOOT=y
CONFIG_LED_GPIO=y
CONFIG_STM32_FMC2_EBI=y
CONFIG_SUPPORT_EMMC_BOOT=y
--
2.43.0
^ permalink raw reply related [flat|nested] 54+ messages in thread* [PATCH 15/23] configs: stm32mp2: Enable LED_BOOT for stm32mp25_defconfig
2025-11-14 16:23 [PATCH 00/23] stm32: Update led management for STMicroelectronics boards Patrice Chotard
` (13 preceding siblings ...)
2025-11-14 16:23 ` [PATCH 14/23] configs: stm32mp15: Enable LED_BOOT for stm32mp15_trusted_defconfig Patrice Chotard
@ 2025-11-14 16:23 ` Patrice Chotard
2025-12-04 16:20 ` Quentin Schulz
2025-11-14 16:23 ` [PATCH 16/23] configs: stm32mp2: Enable LED_BOOT for stm32mp23_defconfig Patrice Chotard
` (8 subsequent siblings)
23 siblings, 1 reply; 54+ messages in thread
From: Patrice Chotard @ 2025-11-14 16:23 UTC (permalink / raw)
To: u-boot
Cc: Patrice CHOTARD, Patrick DELAUNAY, U-Boot STM32, Cheick Traore,
Marek Vasut, Tom Rini
Enable LED_BOOT to use led_boot_on/off() API in board file.
Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
---
configs/stm32mp25_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/configs/stm32mp25_defconfig b/configs/stm32mp25_defconfig
index a5ee02a09b4..7c3b46fcf94 100644
--- a/configs/stm32mp25_defconfig
+++ b/configs/stm32mp25_defconfig
@@ -61,6 +61,7 @@ CONFIG_GPIO_HOG=y
CONFIG_DM_I2C=y
CONFIG_SYS_I2C_STM32F7=y
CONFIG_LED=y
+CONFIG_LED_BOOT=y
CONFIG_LED_GPIO=y
CONFIG_STM32_OMM=y
CONFIG_SUPPORT_EMMC_BOOT=y
--
2.43.0
^ permalink raw reply related [flat|nested] 54+ messages in thread* [PATCH 16/23] configs: stm32mp2: Enable LED_BOOT for stm32mp23_defconfig
2025-11-14 16:23 [PATCH 00/23] stm32: Update led management for STMicroelectronics boards Patrice Chotard
` (14 preceding siblings ...)
2025-11-14 16:23 ` [PATCH 15/23] configs: stm32mp2: Enable LED_BOOT for stm32mp25_defconfig Patrice Chotard
@ 2025-11-14 16:23 ` Patrice Chotard
2025-12-04 16:21 ` Quentin Schulz
2025-11-14 16:23 ` [PATCH 17/23] ARM: dts: stm32: Drop "u-boot-led" and "error-led" from stm32mp135f-dk-u-boot Patrice Chotard
` (7 subsequent siblings)
23 siblings, 1 reply; 54+ messages in thread
From: Patrice Chotard @ 2025-11-14 16:23 UTC (permalink / raw)
To: u-boot
Cc: Patrice CHOTARD, Patrick DELAUNAY, U-Boot STM32, Cheick Traore,
Marek Vasut, Tom Rini
Enable LED_BOOT to use led_boot_on/off() API in board file.
Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
---
configs/stm32mp23_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/configs/stm32mp23_defconfig b/configs/stm32mp23_defconfig
index 840855c23e5..49f47becba6 100644
--- a/configs/stm32mp23_defconfig
+++ b/configs/stm32mp23_defconfig
@@ -55,6 +55,7 @@ CONFIG_GPIO_HOG=y
CONFIG_DM_I2C=y
CONFIG_SYS_I2C_STM32F7=y
CONFIG_LED=y
+CONFIG_LED_BOOT=y
CONFIG_LED_GPIO=y
CONFIG_SUPPORT_EMMC_BOOT=y
CONFIG_STM32_SDMMC2=y
--
2.43.0
^ permalink raw reply related [flat|nested] 54+ messages in thread* [PATCH 17/23] ARM: dts: stm32: Drop "u-boot-led" and "error-led" from stm32mp135f-dk-u-boot
2025-11-14 16:23 [PATCH 00/23] stm32: Update led management for STMicroelectronics boards Patrice Chotard
` (15 preceding siblings ...)
2025-11-14 16:23 ` [PATCH 16/23] configs: stm32mp2: Enable LED_BOOT for stm32mp23_defconfig Patrice Chotard
@ 2025-11-14 16:23 ` Patrice Chotard
2025-12-04 16:25 ` Quentin Schulz
2025-11-14 16:23 ` [PATCH 18/23] ARM: dts: stm32: Drop "u-boot-led" and "error-led" from stm32mp157a-dk1-scmi-u-boot Patrice Chotard
` (6 subsequent siblings)
23 siblings, 1 reply; 54+ messages in thread
From: Patrice Chotard @ 2025-11-14 16:23 UTC (permalink / raw)
To: u-boot; +Cc: Patrice CHOTARD, Patrick DELAUNAY, U-Boot STM32, Tom Rini
Remove obsolete properties "u-boot, u-boot-led" and "u-boot,error-led"
from stm32mp135f-dk-u-boot.dtsi.
Remove also led-red node which is now part of kernel DT.
See kernel series: https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=1022570
Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
---
arch/arm/dts/stm32mp135f-dk-u-boot.dtsi | 6 ------
1 file changed, 6 deletions(-)
diff --git a/arch/arm/dts/stm32mp135f-dk-u-boot.dtsi b/arch/arm/dts/stm32mp135f-dk-u-boot.dtsi
index 3d428c3c4db..bfd9f128cb6 100644
--- a/arch/arm/dts/stm32mp135f-dk-u-boot.dtsi
+++ b/arch/arm/dts/stm32mp135f-dk-u-boot.dtsi
@@ -11,8 +11,6 @@
};
config {
- u-boot,boot-led = "led-blue";
- u-boot,error-led = "led-red";
u-boot,mmc-env-partition = "u-boot-env";
};
@@ -33,10 +31,6 @@
led-blue {
/delete-property/default-state;
};
-
- led-red {
- gpios = <&gpioa 13 GPIO_ACTIVE_LOW>;
- };
};
};
--
2.43.0
^ permalink raw reply related [flat|nested] 54+ messages in thread* Re: [PATCH 17/23] ARM: dts: stm32: Drop "u-boot-led" and "error-led" from stm32mp135f-dk-u-boot
2025-11-14 16:23 ` [PATCH 17/23] ARM: dts: stm32: Drop "u-boot-led" and "error-led" from stm32mp135f-dk-u-boot Patrice Chotard
@ 2025-12-04 16:25 ` Quentin Schulz
2025-12-05 9:45 ` Patrice CHOTARD
0 siblings, 1 reply; 54+ messages in thread
From: Quentin Schulz @ 2025-12-04 16:25 UTC (permalink / raw)
To: Patrice Chotard, u-boot; +Cc: Patrick DELAUNAY, U-Boot STM32, Tom Rini
Hi Patrice,
On 11/14/25 5:23 PM, Patrice Chotard wrote:
> Remove obsolete properties "u-boot, u-boot-led" and "u-boot,error-led"
> from stm32mp135f-dk-u-boot.dtsi.
>
> Remove also led-red node which is now part of kernel DT.
> See kernel series: https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=1022570
>
You may want to wait for the DT to be sync'ed with Linux's for this
patch so that the red LED can still be used with the led command?
Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>
Thanks!
Quentin
^ permalink raw reply [flat|nested] 54+ messages in thread
* Re: [PATCH 17/23] ARM: dts: stm32: Drop "u-boot-led" and "error-led" from stm32mp135f-dk-u-boot
2025-12-04 16:25 ` Quentin Schulz
@ 2025-12-05 9:45 ` Patrice CHOTARD
2025-12-05 10:47 ` Quentin Schulz
0 siblings, 1 reply; 54+ messages in thread
From: Patrice CHOTARD @ 2025-12-05 9:45 UTC (permalink / raw)
To: Quentin Schulz, u-boot; +Cc: Patrick DELAUNAY, U-Boot STM32, Tom Rini
On 12/4/25 17:25, Quentin Schulz wrote:
> Hi Patrice,
>
> On 11/14/25 5:23 PM, Patrice Chotard wrote:
>> Remove obsolete properties "u-boot, u-boot-led" and "u-boot,error-led"
>> from stm32mp135f-dk-u-boot.dtsi.
>>
>> Remove also led-red node which is now part of kernel DT.
>> See kernel series: https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=1022570
>>
>
> You may want to wait for the DT to be sync'ed with Linux's for this patch so that the red LED can still be used with the led command?
>
I will not wait for the DT to be synchronized, as the red led is no more functional since a while it's not a big deal.
Thanks
Patrice
> Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>
>
> Thanks!
> Quentin
^ permalink raw reply [flat|nested] 54+ messages in thread
* Re: [PATCH 17/23] ARM: dts: stm32: Drop "u-boot-led" and "error-led" from stm32mp135f-dk-u-boot
2025-12-05 9:45 ` Patrice CHOTARD
@ 2025-12-05 10:47 ` Quentin Schulz
0 siblings, 0 replies; 54+ messages in thread
From: Quentin Schulz @ 2025-12-05 10:47 UTC (permalink / raw)
To: Patrice CHOTARD, u-boot; +Cc: Patrick DELAUNAY, U-Boot STM32, Tom Rini
Hi Patrice,
On 12/5/25 10:45 AM, Patrice CHOTARD wrote:
>
>
> On 12/4/25 17:25, Quentin Schulz wrote:
>> Hi Patrice,
>>
>> On 11/14/25 5:23 PM, Patrice Chotard wrote:
>>> Remove obsolete properties "u-boot, u-boot-led" and "u-boot,error-led"
>>> from stm32mp135f-dk-u-boot.dtsi.
>>>
>>> Remove also led-red node which is now part of kernel DT.
>>> See kernel series: https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=1022570
>>>
>>
>> You may want to wait for the DT to be sync'ed with Linux's for this patch so that the red LED can still be used with the led command?
>>
>
> I will not wait for the DT to be synchronized, as the red led is no more functional since a while it's not a big deal.
>
OK. Then this also answers my question sent by mail to patch 2 just now.
Cheers,
Quentin
^ permalink raw reply [flat|nested] 54+ messages in thread
* [PATCH 18/23] ARM: dts: stm32: Drop "u-boot-led" and "error-led" from stm32mp157a-dk1-scmi-u-boot
2025-11-14 16:23 [PATCH 00/23] stm32: Update led management for STMicroelectronics boards Patrice Chotard
` (16 preceding siblings ...)
2025-11-14 16:23 ` [PATCH 17/23] ARM: dts: stm32: Drop "u-boot-led" and "error-led" from stm32mp135f-dk-u-boot Patrice Chotard
@ 2025-11-14 16:23 ` Patrice Chotard
2025-12-04 16:27 ` Quentin Schulz
2025-11-14 16:23 ` [PATCH 19/23] ARM: dts: stm32: Drop "u-boot-led" and "error-led" from stm32mp157a-dk1-u-boot Patrice Chotard
` (5 subsequent siblings)
23 siblings, 1 reply; 54+ messages in thread
From: Patrice Chotard @ 2025-11-14 16:23 UTC (permalink / raw)
To: u-boot; +Cc: Patrice CHOTARD, Patrick DELAUNAY, U-Boot STM32, Peng Fan,
Tom Rini
Remove obsolete properties "u-boot, u-boot-led" and "u-boot,error-led"
from stm32mp157a-dk1-scmi-u-boot.dtsi.
Remove led-red node which is now available in kernel DT.
See kernel series: https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=1022570
Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
---
arch/arm/dts/stm32mp157a-dk1-scmi-u-boot.dtsi | 6 ------
1 file changed, 6 deletions(-)
diff --git a/arch/arm/dts/stm32mp157a-dk1-scmi-u-boot.dtsi b/arch/arm/dts/stm32mp157a-dk1-scmi-u-boot.dtsi
index b8e4b4ea6a8..76023cb198a 100644
--- a/arch/arm/dts/stm32mp157a-dk1-scmi-u-boot.dtsi
+++ b/arch/arm/dts/stm32mp157a-dk1-scmi-u-boot.dtsi
@@ -13,8 +13,6 @@
};
config {
- u-boot,boot-led = "led-blue";
- u-boot,error-led = "led-red";
u-boot,mmc-env-partition = "u-boot-env";
st,adc_usb_pd = <&adc1 18>, <&adc1 19>;
};
@@ -39,10 +37,6 @@
led-blue {
/delete-property/label;
};
-
- led-red {
- gpios = <&gpioa 13 GPIO_ACTIVE_LOW>;
- };
};
};
--
2.43.0
^ permalink raw reply related [flat|nested] 54+ messages in thread* [PATCH 19/23] ARM: dts: stm32: Drop "u-boot-led" and "error-led" from stm32mp157a-dk1-u-boot
2025-11-14 16:23 [PATCH 00/23] stm32: Update led management for STMicroelectronics boards Patrice Chotard
` (17 preceding siblings ...)
2025-11-14 16:23 ` [PATCH 18/23] ARM: dts: stm32: Drop "u-boot-led" and "error-led" from stm32mp157a-dk1-scmi-u-boot Patrice Chotard
@ 2025-11-14 16:23 ` Patrice Chotard
2025-12-04 16:27 ` Quentin Schulz
2025-11-14 16:23 ` [PATCH 20/23] ARM: dts: stm32: Drop "u-boot-led" and "error-led" from stm32mp157c-ed1-scmi-u-boot Patrice Chotard
` (4 subsequent siblings)
23 siblings, 1 reply; 54+ messages in thread
From: Patrice Chotard @ 2025-11-14 16:23 UTC (permalink / raw)
To: u-boot; +Cc: Patrice CHOTARD, Patrick DELAUNAY, U-Boot STM32, Tom Rini
Remove obsolete properties "u-boot, u-boot-led" and "u-boot,error-led"
from stm32mp135f-dk-u-boot.dtsi.
Remove led-red which is now available in kernel DT.
See kernel series: https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=1022570
Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
---
arch/arm/dts/stm32mp157a-dk1-u-boot.dtsi | 5 -----
1 file changed, 5 deletions(-)
diff --git a/arch/arm/dts/stm32mp157a-dk1-u-boot.dtsi b/arch/arm/dts/stm32mp157a-dk1-u-boot.dtsi
index 4c928499f50..41583396b1f 100644
--- a/arch/arm/dts/stm32mp157a-dk1-u-boot.dtsi
+++ b/arch/arm/dts/stm32mp157a-dk1-u-boot.dtsi
@@ -15,8 +15,6 @@
};
config {
- u-boot,boot-led = "led-blue";
- u-boot,error-led = "led-red";
u-boot,mmc-env-partition = "fip";
st,adc_usb_pd = <&adc1 18>, <&adc1 19>;
};
@@ -68,9 +66,6 @@
/delete-property/label;
};
- led-red {
- gpios = <&gpioa 13 GPIO_ACTIVE_LOW>;
- };
};
};
--
2.43.0
^ permalink raw reply related [flat|nested] 54+ messages in thread* [PATCH 20/23] ARM: dts: stm32: Drop "u-boot-led" and "error-led" from stm32mp157c-ed1-scmi-u-boot
2025-11-14 16:23 [PATCH 00/23] stm32: Update led management for STMicroelectronics boards Patrice Chotard
` (18 preceding siblings ...)
2025-11-14 16:23 ` [PATCH 19/23] ARM: dts: stm32: Drop "u-boot-led" and "error-led" from stm32mp157a-dk1-u-boot Patrice Chotard
@ 2025-11-14 16:23 ` Patrice Chotard
2025-12-04 16:31 ` Quentin Schulz
2025-11-14 16:23 ` [PATCH 21/23] ARM: dts: stm32: Drop "u-boot-led" and "error-led" from stm32mp157c-ed1-u-boot Patrice Chotard
` (3 subsequent siblings)
23 siblings, 1 reply; 54+ messages in thread
From: Patrice Chotard @ 2025-11-14 16:23 UTC (permalink / raw)
To: u-boot; +Cc: Patrice CHOTARD, Patrick DELAUNAY, U-Boot STM32, Peng Fan,
Tom Rini
Remove obsolete properties "u-boot, u-boot-led" and "u-boot,error-led"
from stm32mp157c-ed1-scmi-u-boot.dtsi.
Remove led-red and led-blue nodes which are available in kernel DT.
See kernel series: https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=1022570
Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
---
arch/arm/dts/stm32mp157c-ed1-scmi-u-boot.dtsi | 14 --------------
1 file changed, 14 deletions(-)
diff --git a/arch/arm/dts/stm32mp157c-ed1-scmi-u-boot.dtsi b/arch/arm/dts/stm32mp157c-ed1-scmi-u-boot.dtsi
index a0f034b008e..ca1342b80f9 100644
--- a/arch/arm/dts/stm32mp157c-ed1-scmi-u-boot.dtsi
+++ b/arch/arm/dts/stm32mp157c-ed1-scmi-u-boot.dtsi
@@ -12,8 +12,6 @@
};
config {
- u-boot,boot-led = "led-blue";
- u-boot,error-led = "led-red";
u-boot,mmc-env-partition = "u-boot-env";
};
@@ -32,18 +30,6 @@
gpios = <&gpioa 13 (GPIO_ACTIVE_LOW | GPIO_PULL_UP)>;
};
};
-
- led {
- compatible = "gpio-leds";
-
- led-blue {
- gpios = <&gpiod 9 GPIO_ACTIVE_HIGH>;
- };
-
- led-red {
- gpios = <&gpioa 13 GPIO_ACTIVE_LOW>;
- };
- };
};
&uart4_pins_a {
--
2.43.0
^ permalink raw reply related [flat|nested] 54+ messages in thread* [PATCH 21/23] ARM: dts: stm32: Drop "u-boot-led" and "error-led" from stm32mp157c-ed1-u-boot
2025-11-14 16:23 [PATCH 00/23] stm32: Update led management for STMicroelectronics boards Patrice Chotard
` (19 preceding siblings ...)
2025-11-14 16:23 ` [PATCH 20/23] ARM: dts: stm32: Drop "u-boot-led" and "error-led" from stm32mp157c-ed1-scmi-u-boot Patrice Chotard
@ 2025-11-14 16:23 ` Patrice Chotard
2025-12-04 16:34 ` Quentin Schulz
2025-11-14 16:23 ` [PATCH 22/23] ARM: dts: stm32: Drop "u-boot-led" from stm32mp235f-dk-u-boot Patrice Chotard
` (2 subsequent siblings)
23 siblings, 1 reply; 54+ messages in thread
From: Patrice Chotard @ 2025-11-14 16:23 UTC (permalink / raw)
To: u-boot; +Cc: Patrice CHOTARD, Patrick DELAUNAY, U-Boot STM32, Tom Rini
Remove obsolete properties "u-boot, u-boot-led" and "u-boot,error-led"
from stm32mp157cf-ed1-u-boot.dtsi.
Remove led-red and led-blue nodes which are available in kernel DT.
See kernel series: https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=1022570
Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
---
arch/arm/dts/stm32mp157c-ed1-u-boot.dtsi | 14 --------------
1 file changed, 14 deletions(-)
diff --git a/arch/arm/dts/stm32mp157c-ed1-u-boot.dtsi b/arch/arm/dts/stm32mp157c-ed1-u-boot.dtsi
index 77a65003f53..9ee0204f9fb 100644
--- a/arch/arm/dts/stm32mp157c-ed1-u-boot.dtsi
+++ b/arch/arm/dts/stm32mp157c-ed1-u-boot.dtsi
@@ -14,8 +14,6 @@
};
config {
- u-boot,boot-led = "led-blue";
- u-boot,error-led = "led-red";
u-boot,mmc-env-partition = "fip";
};
@@ -57,18 +55,6 @@
gpios = <&gpioa 13 (GPIO_ACTIVE_LOW | GPIO_PULL_UP)>;
};
};
-
- led {
- compatible = "gpio-leds";
-
- led-blue {
- gpios = <&gpiod 9 GPIO_ACTIVE_HIGH>;
- };
-
- led-red {
- gpios = <&gpioa 13 GPIO_ACTIVE_LOW>;
- };
- };
};
&clk_hse {
--
2.43.0
^ permalink raw reply related [flat|nested] 54+ messages in thread* [PATCH 22/23] ARM: dts: stm32: Drop "u-boot-led" from stm32mp235f-dk-u-boot
2025-11-14 16:23 [PATCH 00/23] stm32: Update led management for STMicroelectronics boards Patrice Chotard
` (20 preceding siblings ...)
2025-11-14 16:23 ` [PATCH 21/23] ARM: dts: stm32: Drop "u-boot-led" and "error-led" from stm32mp157c-ed1-u-boot Patrice Chotard
@ 2025-11-14 16:23 ` Patrice Chotard
2025-12-04 16:40 ` Quentin Schulz
2025-11-14 16:23 ` [PATCH 23/23] ARM: dts: stm32: Drop "u-boot-led" from stm32mp257f-ev1-u-boot Patrice Chotard
2025-12-05 12:52 ` [PATCH 00/23] stm32: Update led management for STMicroelectronics boards Patrice CHOTARD
23 siblings, 1 reply; 54+ messages in thread
From: Patrice Chotard @ 2025-11-14 16:23 UTC (permalink / raw)
To: u-boot; +Cc: Patrice CHOTARD, Patrick DELAUNAY, U-Boot STM32, Tom Rini
Remove obsolete property "u-boot, u-boot-led" from
stm32mp235f-dk-u-boot.dtsi.
Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
---
arch/arm/dts/stm32mp235f-dk-u-boot.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/dts/stm32mp235f-dk-u-boot.dtsi b/arch/arm/dts/stm32mp235f-dk-u-boot.dtsi
index 1bc77874050..ce8003650bc 100644
--- a/arch/arm/dts/stm32mp235f-dk-u-boot.dtsi
+++ b/arch/arm/dts/stm32mp235f-dk-u-boot.dtsi
@@ -7,7 +7,6 @@
/ {
config {
- u-boot,boot-led = "led-blue";
u-boot,mmc-env-partition = "u-boot-env";
};
};
--
2.43.0
^ permalink raw reply related [flat|nested] 54+ messages in thread* [PATCH 23/23] ARM: dts: stm32: Drop "u-boot-led" from stm32mp257f-ev1-u-boot
2025-11-14 16:23 [PATCH 00/23] stm32: Update led management for STMicroelectronics boards Patrice Chotard
` (21 preceding siblings ...)
2025-11-14 16:23 ` [PATCH 22/23] ARM: dts: stm32: Drop "u-boot-led" from stm32mp235f-dk-u-boot Patrice Chotard
@ 2025-11-14 16:23 ` Patrice Chotard
2025-12-04 16:41 ` Quentin Schulz
2025-12-05 12:52 ` [PATCH 00/23] stm32: Update led management for STMicroelectronics boards Patrice CHOTARD
23 siblings, 1 reply; 54+ messages in thread
From: Patrice Chotard @ 2025-11-14 16:23 UTC (permalink / raw)
To: u-boot; +Cc: Patrice CHOTARD, Patrick DELAUNAY, U-Boot STM32, Tom Rini
Remove obsolete property "u-boot, u-boot-led" from
stm32mp257f-ev1-u-boot.dtsi.
Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
---
arch/arm/dts/stm32mp257f-ev1-u-boot.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/dts/stm32mp257f-ev1-u-boot.dtsi b/arch/arm/dts/stm32mp257f-ev1-u-boot.dtsi
index 7bbb3e00351..b70cd8b52ce 100644
--- a/arch/arm/dts/stm32mp257f-ev1-u-boot.dtsi
+++ b/arch/arm/dts/stm32mp257f-ev1-u-boot.dtsi
@@ -7,7 +7,6 @@
/ {
config {
- u-boot,boot-led = "led-blue";
u-boot,mmc-env-partition = "u-boot-env";
};
};
--
2.43.0
^ permalink raw reply related [flat|nested] 54+ messages in thread* Re: [PATCH 00/23] stm32: Update led management for STMicroelectronics boards
2025-11-14 16:23 [PATCH 00/23] stm32: Update led management for STMicroelectronics boards Patrice Chotard
` (22 preceding siblings ...)
2025-11-14 16:23 ` [PATCH 23/23] ARM: dts: stm32: Drop "u-boot-led" from stm32mp257f-ev1-u-boot Patrice Chotard
@ 2025-12-05 12:52 ` Patrice CHOTARD
23 siblings, 0 replies; 54+ messages in thread
From: Patrice CHOTARD @ 2025-12-05 12:52 UTC (permalink / raw)
To: u-boot
Cc: Patrick DELAUNAY, U-Boot STM32, Antonio Borneo, Cheick Traore,
Dario Binacchi, Kamil Lulko, Kory Maincent, Linus Walleij,
Marek Vasut, Peng Fan, Sam Protsenko, Simon Glass, Tom Rini
On 11/14/25 17:23, Patrice Chotard wrote:
> Since commit 516a13e8db32 ("led: update LED boot/activity to new property implementation")
> "u-boot,boot-led" and "u-boot,error-led" properties can't be used anymore,
> and in addition these properties are removed by series [1]
>
> Instead, make usage of "boot-led" property in /options/u-boot node ,see [2].
> "boot-led" property is added in kernel DT [3].
>
> "u-boot,error-led" is replaced by LED labeled "red:status".
> "red:status" addition has been submitted on kernel side [4]
>
> This series also :
> - Remove no more used board/st/stm32f429-discovery/led.c
> - Update LED management for stm32mp1/2 boards.
> - Enable LED_BOOT flag in STM32 MCU's and MPU's defconfig files.
>
> [1] https://patchwork.ozlabs.org/project/uboot/list/?series=481840
> [2] https://github.com/devicetree-org/dt-schema/blob/main/dtschema/schemas/options/u-boot.yaml
> [3] https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=1022570
> [4] https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=1023034
>
>
> Patrice Chotard (22):
> board: st: Update LED management for stm32mp1
> board: st: Update LED management for stm32mp2
> configs: stm32: Enable LED config flags for stm32f429-disco
> configs: stm32: Enable LED config flags for stm32f429-disco
> configs: stm32: Enable LED config flags for stm32f746-disco
> configs: stm32: Enable LED config flags for stm32f769-disco
> configs: stm32: Enable LED config flags for stm32h743-disco
> configs: stm32: Enable LED config flags for stm32h743-eval
> configs: stm32: Enable LED config flags for stm32h747-disco
> configs: stm32mp13: Enable LED_BOOT for stm32mp13_defconfig
> configs: stm32mp15: Enable LED_BOOT for stm32mp15_defconfig
> configs: stm32mp15: Enable LED_BOOT for stm32mp15_basic_defconfig
> configs: stm32mp15: Enable LED_BOOT for stm32mp15_trusted_defconfig
> configs: stm32mp2: Enable LED_BOOT for stm32mp25_defconfig
> configs: stm32mp2: Enable LED_BOOT for stm32mp23_defconfig
> ARM: dts: stm32: Drop "u-boot-led" and "error-led" from
> stm32mp135f-dk-u-boot
> ARM: dts: stm32: Drop "u-boot-led" and "error-led" from
> stm32mp157a-dk1-scmi-u-boot
> ARM: dts: stm32: Drop "u-boot-led" and "error-led" from
> stm32mp157a-dk1-u-boot
> ARM: dts: stm32: Drop "u-boot-led" and "error-led" from
> stm32mp157c-ed1-scmi-u-boot
> ARM: dts: stm32: Drop "u-boot-led" and "error-led" from
> stm32mp157c-ed1-u-boot
> ARM: dts: stm32: Drop "u-boot-led" from stm32mp235f-dk-u-boot
> ARM: dts: stm32: Drop "u-boot-led" from stm32mp257f-ev1-u-boot
>
> Simon Glass (1):
> board: st: Drop old LED code from stm32f429-disco
>
> arch/arm/dts/stm32mp135f-dk-u-boot.dtsi | 6 ---
> arch/arm/dts/stm32mp157a-dk1-scmi-u-boot.dtsi | 6 ---
> arch/arm/dts/stm32mp157a-dk1-u-boot.dtsi | 5 ---
> arch/arm/dts/stm32mp157c-ed1-scmi-u-boot.dtsi | 14 ------
> arch/arm/dts/stm32mp157c-ed1-u-boot.dtsi | 14 ------
> arch/arm/dts/stm32mp235f-dk-u-boot.dtsi | 1 -
> arch/arm/dts/stm32mp257f-ev1-u-boot.dtsi | 1 -
> board/st/stm32f429-discovery/Makefile | 1 -
> board/st/stm32f429-discovery/led.c | 39 ----------------
> board/st/stm32mp1/stm32mp1.c | 45 ++-----------------
> board/st/stm32mp2/stm32mp2.c | 38 +---------------
> configs/stm32f429-discovery_defconfig | 3 ++
> configs/stm32f469-discovery_defconfig | 3 ++
> configs/stm32f746-disco_defconfig | 3 ++
> configs/stm32f769-disco_defconfig | 3 ++
> configs/stm32h743-disco_defconfig | 3 ++
> configs/stm32h743-eval_defconfig | 3 ++
> configs/stm32h747-disco_defconfig | 3 ++
> configs/stm32mp13_defconfig | 1 +
> configs/stm32mp15_basic_defconfig | 1 +
> configs/stm32mp15_defconfig | 1 +
> configs/stm32mp15_trusted_defconfig | 1 +
> configs/stm32mp23_defconfig | 1 +
> configs/stm32mp25_defconfig | 1 +
> 24 files changed, 32 insertions(+), 165 deletions(-)
> delete mode 100644 board/st/stm32f429-discovery/led.c
>
For the whole serie:
Applied to u-boot-stm32/next
Thanks
Patrice
^ permalink raw reply [flat|nested] 54+ messages in thread