* [U-Boot] [PATCH] board: ge: bx50v3: don't configure the backlight when there's no display @ 2016-05-20 12:22 Andrew Shadura 2016-05-24 14:07 ` Stefano Babic 0 siblings, 1 reply; 6+ messages in thread From: Andrew Shadura @ 2016-05-20 12:22 UTC (permalink / raw) To: u-boot Don't try to configure the backlight when CONFIG_VIDEO_IPUV3 isn't set. Signed-off-by: Andrew Shadura <andrew.shadura@collabora.co.uk> --- board/ge/bx50v3/bx50v3.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/board/ge/bx50v3/bx50v3.c b/board/ge/bx50v3/bx50v3.c index e167cd5..fb112ee 100644 --- a/board/ge/bx50v3/bx50v3.c +++ b/board/ge/bx50v3/bx50v3.c @@ -601,6 +601,8 @@ int board_late_init(void) #ifdef CONFIG_CMD_BMODE add_board_boot_modes(board_boot_modes); #endif + +#ifdef CONFIG_VIDEO_IPUV3 /* We need at least 200ms between power on and backlight on * as per specifications from CHI MEI */ mdelay(250); @@ -615,6 +617,7 @@ int board_late_init(void) gpio_direction_output(LVDS_BACKLIGHT_GP, 1); pwm_enable(0); +#endif return 0; } -- 2.7.4 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] board: ge: bx50v3: don't configure the backlight when there's no display 2016-05-20 12:22 [U-Boot] [PATCH] board: ge: bx50v3: don't configure the backlight when there's no display Andrew Shadura @ 2016-05-24 14:07 ` Stefano Babic 2016-05-24 14:09 ` Andrew Shadura 0 siblings, 1 reply; 6+ messages in thread From: Stefano Babic @ 2016-05-24 14:07 UTC (permalink / raw) To: u-boot Hi Andrew, On 20/05/2016 14:22, Andrew Shadura wrote: > Don't try to configure the backlight when CONFIG_VIDEO_IPUV3 isn't set. > > Signed-off-by: Andrew Shadura <andrew.shadura@collabora.co.uk> > --- > board/ge/bx50v3/bx50v3.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/board/ge/bx50v3/bx50v3.c b/board/ge/bx50v3/bx50v3.c > index e167cd5..fb112ee 100644 > --- a/board/ge/bx50v3/bx50v3.c > +++ b/board/ge/bx50v3/bx50v3.c > @@ -601,6 +601,8 @@ int board_late_init(void) > #ifdef CONFIG_CMD_BMODE > add_board_boot_modes(board_boot_modes); > #endif > + > +#ifdef CONFIG_VIDEO_IPUV3 > /* We need at least 200ms between power on and backlight on > * as per specifications from CHI MEI */ > mdelay(250); > @@ -615,6 +617,7 @@ int board_late_init(void) > gpio_direction_output(LVDS_BACKLIGHT_GP, 1); > > pwm_enable(0); > +#endif ...but CONFIG_VIDEO_IPUV3 is set in include/configs/ge_bx50v3.h, that means your changes works on a out-of-tree version of the board. To get this real working, you need to set CONFIG_VIDEO_IPUV3 via menuconfig, that is outside ge_bx50v3.h. Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de ===================================================================== ^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] board: ge: bx50v3: don't configure the backlight when there's no display 2016-05-24 14:07 ` Stefano Babic @ 2016-05-24 14:09 ` Andrew Shadura 2016-05-24 15:26 ` Stefano Babic 0 siblings, 1 reply; 6+ messages in thread From: Andrew Shadura @ 2016-05-24 14:09 UTC (permalink / raw) To: u-boot On 24/05/16 16:07, Stefano Babic wrote: > Hi Andrew, > > On 20/05/2016 14:22, Andrew Shadura wrote: >> > Don't try to configure the backlight when CONFIG_VIDEO_IPUV3 isn't set. >> > >> > Signed-off-by: Andrew Shadura <andrew.shadura@collabora.co.uk> >> > --- >> > board/ge/bx50v3/bx50v3.c | 3 +++ >> > 1 file changed, 3 insertions(+) >> > >> > diff --git a/board/ge/bx50v3/bx50v3.c b/board/ge/bx50v3/bx50v3.c >> > index e167cd5..fb112ee 100644 >> > --- a/board/ge/bx50v3/bx50v3.c >> > +++ b/board/ge/bx50v3/bx50v3.c >> > @@ -601,6 +601,8 @@ int board_late_init(void) >> > #ifdef CONFIG_CMD_BMODE >> > add_board_boot_modes(board_boot_modes); >> > #endif >> > + >> > +#ifdef CONFIG_VIDEO_IPUV3 >> > /* We need at least 200ms between power on and backlight on >> > * as per specifications from CHI MEI */ >> > mdelay(250); >> > @@ -615,6 +617,7 @@ int board_late_init(void) >> > gpio_direction_output(LVDS_BACKLIGHT_GP, 1); >> > >> > pwm_enable(0); >> > +#endif > ...but CONFIG_VIDEO_IPUV3 is set in include/configs/ge_bx50v3.h, that > means your changes works on a out-of-tree version of the board. > > To get this real working, you need to set CONFIG_VIDEO_IPUV3 via > menuconfig, that is outside ge_bx50v3.h. The next change in the patchset makes use of this bit. I put this patch first so that I don't break things and only then fix them. -- Cheers, Andrew -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: OpenPGP digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160524/8a2690fc/attachment.sig> ^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] board: ge: bx50v3: don't configure the backlight when there's no display 2016-05-24 14:09 ` Andrew Shadura @ 2016-05-24 15:26 ` Stefano Babic 2016-05-24 15:28 ` Andrew Shadura 0 siblings, 1 reply; 6+ messages in thread From: Stefano Babic @ 2016-05-24 15:26 UTC (permalink / raw) To: u-boot Hi Andrew, On 24/05/2016 16:09, Andrew Shadura wrote: > On 24/05/16 16:07, Stefano Babic wrote: >> Hi Andrew, >> >> On 20/05/2016 14:22, Andrew Shadura wrote: >>>> Don't try to configure the backlight when CONFIG_VIDEO_IPUV3 isn't set. >>>> >>>> Signed-off-by: Andrew Shadura <andrew.shadura@collabora.co.uk> >>>> --- >>>> board/ge/bx50v3/bx50v3.c | 3 +++ >>>> 1 file changed, 3 insertions(+) >>>> >>>> diff --git a/board/ge/bx50v3/bx50v3.c b/board/ge/bx50v3/bx50v3.c >>>> index e167cd5..fb112ee 100644 >>>> --- a/board/ge/bx50v3/bx50v3.c >>>> +++ b/board/ge/bx50v3/bx50v3.c >>>> @@ -601,6 +601,8 @@ int board_late_init(void) >>>> #ifdef CONFIG_CMD_BMODE >>>> add_board_boot_modes(board_boot_modes); >>>> #endif >>>> + >>>> +#ifdef CONFIG_VIDEO_IPUV3 >>>> /* We need at least 200ms between power on and backlight on >>>> * as per specifications from CHI MEI */ >>>> mdelay(250); >>>> @@ -615,6 +617,7 @@ int board_late_init(void) >>>> gpio_direction_output(LVDS_BACKLIGHT_GP, 1); >>>> >>>> pwm_enable(0); >>>> +#endif >> ...but CONFIG_VIDEO_IPUV3 is set in include/configs/ge_bx50v3.h, that >> means your changes works on a out-of-tree version of the board. >> >> To get this real working, you need to set CONFIG_VIDEO_IPUV3 via >> menuconfig, that is outside ge_bx50v3.h. > > The next change in the patchset makes use of this bit. I put this patch > first so that I don't break things and only then fix them. I suggest you send all your changes in a single patchset - this let possible to understand all your changes and we can provide a better review. Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de ===================================================================== ^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] board: ge: bx50v3: don't configure the backlight when there's no display 2016-05-24 15:26 ` Stefano Babic @ 2016-05-24 15:28 ` Andrew Shadura 2016-05-24 15:33 ` Stefano Babic 0 siblings, 1 reply; 6+ messages in thread From: Andrew Shadura @ 2016-05-24 15:28 UTC (permalink / raw) To: u-boot On 24/05/16 17:26, Stefano Babic wrote: >>> ...but CONFIG_VIDEO_IPUV3 is set in include/configs/ge_bx50v3.h, that >>> >> means your changes works on a out-of-tree version of the board. >>> >> >>> >> To get this real working, you need to set CONFIG_VIDEO_IPUV3 via >>> >> menuconfig, that is outside ge_bx50v3.h. >> > >> > The next change in the patchset makes use of this bit. I put this patch >> > first so that I don't break things and only then fix them. > I suggest you send all your changes in a single patchset - this let > possible to understand all your changes and we can provide a better review. That's what I did, I've resent all patches at once. -- Cheers, Andrew -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: OpenPGP digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160524/b1a4152a/attachment.sig> ^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] board: ge: bx50v3: don't configure the backlight when there's no display 2016-05-24 15:28 ` Andrew Shadura @ 2016-05-24 15:33 ` Stefano Babic 0 siblings, 0 replies; 6+ messages in thread From: Stefano Babic @ 2016-05-24 15:33 UTC (permalink / raw) To: u-boot On 24/05/2016 17:28, Andrew Shadura wrote: > On 24/05/16 17:26, Stefano Babic wrote: >>>> ...but CONFIG_VIDEO_IPUV3 is set in include/configs/ge_bx50v3.h, that >>>>>> means your changes works on a out-of-tree version of the board. >>>>>> >>>>>> To get this real working, you need to set CONFIG_VIDEO_IPUV3 via >>>>>> menuconfig, that is outside ge_bx50v3.h. >>>> >>>> The next change in the patchset makes use of this bit. I put this patch >>>> first so that I don't break things and only then fix them. >> I suggest you send all your changes in a single patchset - this let >> possible to understand all your changes and we can provide a better review. > > That's what I did, I've resent all patches at once. > I see, but you missed again to send them to the board Maintainer (Martin). Martin, can you also track them ? Regards, Stefano -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de ===================================================================== ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-05-24 15:33 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-05-20 12:22 [U-Boot] [PATCH] board: ge: bx50v3: don't configure the backlight when there's no display Andrew Shadura 2016-05-24 14:07 ` Stefano Babic 2016-05-24 14:09 ` Andrew Shadura 2016-05-24 15:26 ` Stefano Babic 2016-05-24 15:28 ` Andrew Shadura 2016-05-24 15:33 ` Stefano Babic
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox