From: Jaehoon Chung <jh80.chung@gmail.com>
To: John Keeping <john@metanate.com>, Jaehoon Chung <jh80.chung@samsung.com>
Cc: u-boot@lists.denx.de
Subject: Re: [PATCH] power: act8846_pmic: fix number of registers
Date: Tue, 31 Jan 2023 21:48:04 +0900 [thread overview]
Message-ID: <7d0e5ebd-885a-389e-cb11-19454ea4ac6d@gmail.com> (raw)
In-Reply-To: <20230119125612.1968983-1-john@metanate.com>
On 1/19/23 21:56, John Keeping wrote:
> The highest register on ACT8846 is 0xf5, so set the number of registers
> to 0xf6, ensuring that the pmic read/write commands are able to access
> all of the supported registers (and many that are not valid, since the
> register space is quite sparse).
>
> Signed-off-by: John Keeping <john@metanate.com>
Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>
Best Regards,
Jaehoon Chung
> ---
> include/power/act8846_pmic.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/power/act8846_pmic.h b/include/power/act8846_pmic.h
> index acd0fd671e..84845c70f9 100644
> --- a/include/power/act8846_pmic.h
> +++ b/include/power/act8846_pmic.h
> @@ -9,7 +9,7 @@
>
> #include <asm/gpio.h>
>
> -#define ACT8846_NUM_OF_REGS 12
> +#define ACT8846_NUM_OF_REGS 0xf6
>
> #define BUCK_VOL_MASK 0x3f
> #define LDO_VOL_MASK 0x3f
prev parent reply other threads:[~2023-01-31 12:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-19 12:56 [PATCH] power: act8846_pmic: fix number of registers John Keeping
2023-01-19 16:19 ` Simon Glass
2023-01-31 12:48 ` Jaehoon Chung [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d0e5ebd-885a-389e-cb11-19454ea4ac6d@gmail.com \
--to=jh80.chung@gmail.com \
--cc=jh80.chung@samsung.com \
--cc=john@metanate.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox