* [PATCH] power: act8846_pmic: fix number of registers
@ 2023-01-19 12:56 John Keeping
2023-01-19 16:19 ` Simon Glass
2023-01-31 12:48 ` Jaehoon Chung
0 siblings, 2 replies; 3+ messages in thread
From: John Keeping @ 2023-01-19 12:56 UTC (permalink / raw)
To: Jaehoon Chung; +Cc: u-boot, John Keeping
The highest register on ACT8846 is 0xf5, so set the number of registers
to 0xf6, ensuring that the pmic read/write commands are able to access
all of the supported registers (and many that are not valid, since the
register space is quite sparse).
Signed-off-by: John Keeping <john@metanate.com>
---
include/power/act8846_pmic.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/power/act8846_pmic.h b/include/power/act8846_pmic.h
index acd0fd671e..84845c70f9 100644
--- a/include/power/act8846_pmic.h
+++ b/include/power/act8846_pmic.h
@@ -9,7 +9,7 @@
#include <asm/gpio.h>
-#define ACT8846_NUM_OF_REGS 12
+#define ACT8846_NUM_OF_REGS 0xf6
#define BUCK_VOL_MASK 0x3f
#define LDO_VOL_MASK 0x3f
--
2.39.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] power: act8846_pmic: fix number of registers
2023-01-19 12:56 [PATCH] power: act8846_pmic: fix number of registers John Keeping
@ 2023-01-19 16:19 ` Simon Glass
2023-01-31 12:48 ` Jaehoon Chung
1 sibling, 0 replies; 3+ messages in thread
From: Simon Glass @ 2023-01-19 16:19 UTC (permalink / raw)
To: John Keeping; +Cc: Jaehoon Chung, u-boot
On Thu, 19 Jan 2023 at 05:56, John Keeping <john@metanate.com> wrote:
>
> The highest register on ACT8846 is 0xf5, so set the number of registers
> to 0xf6, ensuring that the pmic read/write commands are able to access
> all of the supported registers (and many that are not valid, since the
> register space is quite sparse).
>
> Signed-off-by: John Keeping <john@metanate.com>
> ---
> include/power/act8846_pmic.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] power: act8846_pmic: fix number of registers
2023-01-19 12:56 [PATCH] power: act8846_pmic: fix number of registers John Keeping
2023-01-19 16:19 ` Simon Glass
@ 2023-01-31 12:48 ` Jaehoon Chung
1 sibling, 0 replies; 3+ messages in thread
From: Jaehoon Chung @ 2023-01-31 12:48 UTC (permalink / raw)
To: John Keeping, Jaehoon Chung; +Cc: u-boot
On 1/19/23 21:56, John Keeping wrote:
> The highest register on ACT8846 is 0xf5, so set the number of registers
> to 0xf6, ensuring that the pmic read/write commands are able to access
> all of the supported registers (and many that are not valid, since the
> register space is quite sparse).
>
> Signed-off-by: John Keeping <john@metanate.com>
Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>
Best Regards,
Jaehoon Chung
> ---
> include/power/act8846_pmic.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/power/act8846_pmic.h b/include/power/act8846_pmic.h
> index acd0fd671e..84845c70f9 100644
> --- a/include/power/act8846_pmic.h
> +++ b/include/power/act8846_pmic.h
> @@ -9,7 +9,7 @@
>
> #include <asm/gpio.h>
>
> -#define ACT8846_NUM_OF_REGS 12
> +#define ACT8846_NUM_OF_REGS 0xf6
>
> #define BUCK_VOL_MASK 0x3f
> #define LDO_VOL_MASK 0x3f
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-31 12:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-19 12:56 [PATCH] power: act8846_pmic: fix number of registers John Keeping
2023-01-19 16:19 ` Simon Glass
2023-01-31 12:48 ` Jaehoon Chung
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox