From: Kever Yang <kever.yang@rock-chips.com>
To: Quentin Schulz <foss+uboot@0leil.net>,
Tom Rini <trini@konsulko.com>, Simon Glass <sjg@chromium.org>,
Philipp Tomsich <philipp.tomsich@vrull.eu>,
Heiko Stuebner <heiko.stuebner@cherry.de>,
Jagan Teki <jagan@amarulasolutions.com>,
Suniel Mahesh <sunil@amarulasolutions.com>,
Quentin Schulz <quentin.schulz@theobroma-systems.com>,
Klaus Goger <klaus.goger@theobroma-systems.com>
Cc: jonas@kwiboo.se, u-boot@lists.denx.de,
Quentin Schulz <quentin.schulz@cherry.de>
Subject: Re: [PATCH 01/10] rockchip: px30: default TPL_SYS_MALLOC_F_LEN to 0x600 on PX30 Kconfig level
Date: Thu, 23 May 2024 11:48:02 +0800 [thread overview]
Message-ID: <7d1828f1-dfc5-4d88-bb5b-dcf4bd7ce8c8@rock-chips.com> (raw)
In-Reply-To: <20240521-px30-2024-07-rc-v1-1-62109c84d44f@cherry.de>
On 2024/5/22 01:39, Quentin Schulz wrote:
> From: Quentin Schulz <quentin.schulz@cherry.de>
>
> This is the kind of setting that typically doesn't need to be changed
> between boards based on the same SoC, so let's make it the default in
> PX30 Kconfig so we don't have to care about it in the defconfig if we
> don't want to.
>
> Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
Thanks,
- Kever
> ---
> arch/arm/mach-rockchip/px30/Kconfig | 3 +++
> configs/evb-px30_defconfig | 1 -
> configs/firefly-px30_defconfig | 1 -
> configs/odroid-go2_defconfig | 1 -
> configs/px30-core-ctouch2-of10-px30_defconfig | 1 -
> configs/px30-core-ctouch2-px30_defconfig | 1 -
> configs/px30-core-edimm2.2-px30_defconfig | 1 -
> configs/ringneck-px30_defconfig | 1 -
> 8 files changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arm/mach-rockchip/px30/Kconfig b/arch/arm/mach-rockchip/px30/Kconfig
> index 23f8f430c4a..e39472604c3 100644
> --- a/arch/arm/mach-rockchip/px30/Kconfig
> +++ b/arch/arm/mach-rockchip/px30/Kconfig
> @@ -83,6 +83,9 @@ config TPL_TEXT_BASE
> config TPL_STACK
> default 0xff0e4fff
>
> +config TPL_SYS_MALLOC_F_LEN
> + default 0x600
> +
> config DEBUG_UART_CHANNEL
> int "Mux channel to use for debug UART2/UART3"
> depends on DEBUG_UART_BOARD_INIT
> diff --git a/configs/evb-px30_defconfig b/configs/evb-px30_defconfig
> index 07c56a45ec0..73a3c6120e0 100644
> --- a/configs/evb-px30_defconfig
> +++ b/configs/evb-px30_defconfig
> @@ -16,7 +16,6 @@ CONFIG_ROCKCHIP_PX30=y
> CONFIG_TARGET_EVB_PX30=y
> CONFIG_TPL_LIBGENERIC_SUPPORT=y
> CONFIG_SPL_DRIVERS_MISC=y
> -CONFIG_TPL_SYS_MALLOC_F_LEN=0x600
> CONFIG_SPL_STACK_R_ADDR=0x600000
> CONFIG_SPL_STACK=0x400000
> CONFIG_SPL_HAS_BSS_LINKER_SECTION=y
> diff --git a/configs/firefly-px30_defconfig b/configs/firefly-px30_defconfig
> index e5377dcdf3d..0a14b393667 100644
> --- a/configs/firefly-px30_defconfig
> +++ b/configs/firefly-px30_defconfig
> @@ -17,7 +17,6 @@ CONFIG_TARGET_EVB_PX30=y
> CONFIG_DEBUG_UART_CHANNEL=1
> CONFIG_TPL_LIBGENERIC_SUPPORT=y
> CONFIG_SPL_DRIVERS_MISC=y
> -CONFIG_TPL_SYS_MALLOC_F_LEN=0x600
> CONFIG_SPL_STACK_R_ADDR=0x600000
> CONFIG_SPL_STACK=0x400000
> CONFIG_SPL_HAS_BSS_LINKER_SECTION=y
> diff --git a/configs/odroid-go2_defconfig b/configs/odroid-go2_defconfig
> index 99d7149a44c..3c1abb83ed9 100644
> --- a/configs/odroid-go2_defconfig
> +++ b/configs/odroid-go2_defconfig
> @@ -19,7 +19,6 @@ CONFIG_TARGET_ODROID_GO2=y
> CONFIG_DEBUG_UART_CHANNEL=1
> CONFIG_TPL_LIBGENERIC_SUPPORT=y
> CONFIG_SPL_DRIVERS_MISC=y
> -CONFIG_TPL_SYS_MALLOC_F_LEN=0x600
> CONFIG_SPL_STACK_R_ADDR=0x600000
> CONFIG_SPL_STACK=0x400000
> CONFIG_SPL_HAS_BSS_LINKER_SECTION=y
> diff --git a/configs/px30-core-ctouch2-of10-px30_defconfig b/configs/px30-core-ctouch2-of10-px30_defconfig
> index a2801ec7796..87a39e115df 100644
> --- a/configs/px30-core-ctouch2-of10-px30_defconfig
> +++ b/configs/px30-core-ctouch2-of10-px30_defconfig
> @@ -17,7 +17,6 @@ CONFIG_TARGET_PX30_CORE=y
> CONFIG_DEBUG_UART_CHANNEL=1
> CONFIG_TPL_LIBGENERIC_SUPPORT=y
> CONFIG_SPL_DRIVERS_MISC=y
> -CONFIG_TPL_SYS_MALLOC_F_LEN=0x600
> CONFIG_SPL_STACK_R_ADDR=0x600000
> CONFIG_SPL_STACK=0x400000
> CONFIG_SPL_HAS_BSS_LINKER_SECTION=y
> diff --git a/configs/px30-core-ctouch2-px30_defconfig b/configs/px30-core-ctouch2-px30_defconfig
> index cc33e275742..7162c117beb 100644
> --- a/configs/px30-core-ctouch2-px30_defconfig
> +++ b/configs/px30-core-ctouch2-px30_defconfig
> @@ -17,7 +17,6 @@ CONFIG_TARGET_PX30_CORE=y
> CONFIG_DEBUG_UART_CHANNEL=1
> CONFIG_TPL_LIBGENERIC_SUPPORT=y
> CONFIG_SPL_DRIVERS_MISC=y
> -CONFIG_TPL_SYS_MALLOC_F_LEN=0x600
> CONFIG_SPL_STACK_R_ADDR=0x600000
> CONFIG_SPL_STACK=0x400000
> CONFIG_SPL_HAS_BSS_LINKER_SECTION=y
> diff --git a/configs/px30-core-edimm2.2-px30_defconfig b/configs/px30-core-edimm2.2-px30_defconfig
> index 99e1b2fc7ae..1182f60358f 100644
> --- a/configs/px30-core-edimm2.2-px30_defconfig
> +++ b/configs/px30-core-edimm2.2-px30_defconfig
> @@ -17,7 +17,6 @@ CONFIG_TARGET_PX30_CORE=y
> CONFIG_DEBUG_UART_CHANNEL=1
> CONFIG_TPL_LIBGENERIC_SUPPORT=y
> CONFIG_SPL_DRIVERS_MISC=y
> -CONFIG_TPL_SYS_MALLOC_F_LEN=0x600
> CONFIG_SPL_STACK_R_ADDR=0x600000
> CONFIG_SPL_STACK=0x400000
> CONFIG_SPL_HAS_BSS_LINKER_SECTION=y
> diff --git a/configs/ringneck-px30_defconfig b/configs/ringneck-px30_defconfig
> index 67a44eda684..0df1b8a59ac 100644
> --- a/configs/ringneck-px30_defconfig
> +++ b/configs/ringneck-px30_defconfig
> @@ -17,7 +17,6 @@ CONFIG_ROCKCHIP_PX30=y
> CONFIG_TARGET_RINGNECK_PX30=y
> CONFIG_TPL_LIBGENERIC_SUPPORT=y
> CONFIG_SPL_DRIVERS_MISC=y
> -CONFIG_TPL_SYS_MALLOC_F_LEN=0x600
> CONFIG_SPL_STACK_R_ADDR=0x600000
> CONFIG_SPL_STACK=0x400000
> CONFIG_SPL_HAS_BSS_LINKER_SECTION=y
>
next prev parent reply other threads:[~2024-05-23 3:48 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-21 17:39 [PATCH 00/10] rockchip: px30: migrate to common bss and stack addresses + UART fixes for evb-px30 Quentin Schulz
2024-05-21 17:39 ` [PATCH 01/10] rockchip: px30: default TPL_SYS_MALLOC_F_LEN to 0x600 on PX30 Kconfig level Quentin Schulz
2024-05-21 20:22 ` Heiko Stübner
2024-05-23 3:48 ` Kever Yang [this message]
2024-05-21 17:39 ` [PATCH 02/10] rockchip: Use common bss and stack addresses on PX30 Quentin Schulz
2024-05-23 3:48 ` Kever Yang
2024-05-21 17:39 ` [PATCH 03/10] rockchip: ringneck_px30: Use common bss and stack addresses Quentin Schulz
2024-05-23 3:48 ` Kever Yang
2024-05-21 17:39 ` [PATCH 04/10] rockchip: evb-px30: " Quentin Schulz
2024-05-23 3:48 ` Kever Yang
2024-05-21 17:39 ` [PATCH 05/10] rockchip: firefly-px30: " Quentin Schulz
2024-05-23 3:48 ` Kever Yang
2024-05-21 17:39 ` [PATCH 06/10] rockchip: odroid-go2: " Quentin Schulz
2024-05-23 3:48 ` Kever Yang
2024-05-21 17:40 ` [PATCH 07/10] rockchip: px30-core-*: " Quentin Schulz
2024-05-23 3:48 ` Kever Yang
2024-05-21 17:40 ` [PATCH 08/10] rockchip: px30: make UART pinmux accessible to TPL/SPL DTB Quentin Schulz
2024-05-23 3:49 ` Kever Yang
2024-05-21 17:40 ` [PATCH 09/10] rockchip: evb-px30: do not remove pinctrl nodes from SPL DTB Quentin Schulz
2024-05-23 3:49 ` Kever Yang
2024-05-21 17:40 ` [PATCH 10/10] rockchip: evb-px30: make UART5 the debug UART Quentin Schulz
2024-05-23 3:49 ` Kever Yang
2024-05-21 18:04 ` [PATCH 00/10] rockchip: px30: migrate to common bss and stack addresses + UART fixes for evb-px30 Tom Rini
2024-05-22 8:39 ` Quentin Schulz
2024-05-22 12:14 ` Heiko Stübner
2024-05-22 14:15 ` Tom Rini
2024-05-21 19:16 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d1828f1-dfc5-4d88-bb5b-dcf4bd7ce8c8@rock-chips.com \
--to=kever.yang@rock-chips.com \
--cc=foss+uboot@0leil.net \
--cc=heiko.stuebner@cherry.de \
--cc=jagan@amarulasolutions.com \
--cc=jonas@kwiboo.se \
--cc=klaus.goger@theobroma-systems.com \
--cc=philipp.tomsich@vrull.eu \
--cc=quentin.schulz@cherry.de \
--cc=quentin.schulz@theobroma-systems.com \
--cc=sjg@chromium.org \
--cc=sunil@amarulasolutions.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox