U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] usb: gadget: atmel: Add SAM9X60 support
@ 2025-03-22 20:56 Zixun LI
  2025-03-22 22:59 ` Marek Vasut
  2025-03-24  9:23 ` Eugen Hristev
  0 siblings, 2 replies; 7+ messages in thread
From: Zixun LI @ 2025-03-22 20:56 UTC (permalink / raw)
  To: Eugen Hristev, Tom Rini, Lukasz Majewski, Mattijs Korpershoek,
	Marek Vasut
  Cc: Zixun LI, u-boot

Add compatible "microchip,sam9x60-udc" and device tree binding.
Compared to SAM9X5 the only difference is the DPRAM memory from the
USB High Speed Device Port (UDPHS) hardware block was increased,
so we can reuse the same endpoint data.

Tested on SAM9X60-Curiosity board with nfs and ums commands.

Signed-off-by: Zixun LI <admin@hifiphile.com>
---
 arch/arm/dts/sam9x60.dtsi                        | 14 ++++++++++++++
 arch/arm/mach-at91/include/mach/atmel_usba_udc.h |  2 +-
 drivers/usb/gadget/atmel_usba_udc.c              |  1 +
 3 files changed, 16 insertions(+), 1 deletion(-)

diff --git a/arch/arm/dts/sam9x60.dtsi b/arch/arm/dts/sam9x60.dtsi
index 3b684fc63d5..96a8faf09b3 100644
--- a/arch/arm/dts/sam9x60.dtsi
+++ b/arch/arm/dts/sam9x60.dtsi
@@ -69,6 +69,20 @@
 		#size-cells = <1>;
 		ranges;
 
+		usb0: gadget@500000 {
+			compatible = "microchip,sam9x60-udc";
+			reg = <0x500000 0x100000>,
+				<0xf803c000 0x400>;
+			#address-cells = <1>;
+			#size-cells = <0>;
+			interrupts = <23 IRQ_TYPE_LEVEL_HIGH 2>;
+			clocks = <&pmc PMC_TYPE_PERIPHERAL 23>, <&pmc PMC_TYPE_CORE 8>;
+			clock-names = "pclk", "hclk";
+			assigned-clocks = <&pmc PMC_TYPE_CORE 8>;
+			assigned-clock-rates = <480000000>;
+			status = "disabled";
+		};
+
 		usb1: usb@600000 {
 			compatible = "atmel,at91rm9200-ohci", "usb-ohci";
 			reg = <0x00600000 0x100000>;
diff --git a/arch/arm/mach-at91/include/mach/atmel_usba_udc.h b/arch/arm/mach-at91/include/mach/atmel_usba_udc.h
index 835b47d91ba..23c71985c90 100644
--- a/arch/arm/mach-at91/include/mach/atmel_usba_udc.h
+++ b/arch/arm/mach-at91/include/mach/atmel_usba_udc.h
@@ -20,7 +20,7 @@
 	}
 
 #if defined(CONFIG_AT91SAM9G45) || defined(CONFIG_AT91SAM9M10G45) || \
-	defined(CONFIG_AT91SAM9X5)
+	defined(CONFIG_AT91SAM9X5) || defined(CONFIG_SAM9X60)
 static struct usba_ep_data usba_udc_ep[] = {
 	EP("ep0", 0, 64, 1, 0, 0),
 	EP("ep1", 1, 1024, 2, 1, 1),
diff --git a/drivers/usb/gadget/atmel_usba_udc.c b/drivers/usb/gadget/atmel_usba_udc.c
index a77037a7094..f9326f0a7e7 100644
--- a/drivers/usb/gadget/atmel_usba_udc.c
+++ b/drivers/usb/gadget/atmel_usba_udc.c
@@ -1443,6 +1443,7 @@ static const struct udevice_id usba_udc_ids[] = {
 	{ .compatible = "atmel,at91sam9rl-udc" },
 	{ .compatible = "atmel,at91sam9g45-udc" },
 	{ .compatible = "atmel,sama5d3-udc" },
+	{ .compatible = "microchip,sam9x60-udc" },
 	{}
 };
 
-- 
2.39.5


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH] usb: gadget: atmel: Add SAM9X60 support
  2025-03-22 20:56 [PATCH] usb: gadget: atmel: Add SAM9X60 support Zixun LI
@ 2025-03-22 22:59 ` Marek Vasut
  2025-03-24  9:23 ` Eugen Hristev
  1 sibling, 0 replies; 7+ messages in thread
From: Marek Vasut @ 2025-03-22 22:59 UTC (permalink / raw)
  To: Zixun LI, Eugen Hristev, Tom Rini, Lukasz Majewski,
	Mattijs Korpershoek
  Cc: u-boot

On 3/22/25 9:56 PM, Zixun LI wrote:
> Add compatible "microchip,sam9x60-udc" and device tree binding.
> Compared to SAM9X5 the only difference is the DPRAM memory from the
> USB High Speed Device Port (UDPHS) hardware block was increased,
> so we can reuse the same endpoint data.
> 
> Tested on SAM9X60-Curiosity board with nfs and ums commands.
> 
> Signed-off-by: Zixun LI <admin@hifiphile.com>
Reviewed-by: Marek Vasut <marex@denx.de>

Thanks !

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] usb: gadget: atmel: Add SAM9X60 support
  2025-03-22 20:56 [PATCH] usb: gadget: atmel: Add SAM9X60 support Zixun LI
  2025-03-22 22:59 ` Marek Vasut
@ 2025-03-24  9:23 ` Eugen Hristev
  2025-03-31  9:05   ` Mattijs Korpershoek
  1 sibling, 1 reply; 7+ messages in thread
From: Eugen Hristev @ 2025-03-24  9:23 UTC (permalink / raw)
  To: Zixun LI, Tom Rini, Lukasz Majewski, Mattijs Korpershoek,
	Marek Vasut
  Cc: u-boot



On 3/22/25 22:56, Zixun LI wrote:
> Add compatible "microchip,sam9x60-udc" and device tree binding.
> Compared to SAM9X5 the only difference is the DPRAM memory from the
> USB High Speed Device Port (UDPHS) hardware block was increased,
> so we can reuse the same endpoint data.
> 
> Tested on SAM9X60-Curiosity board with nfs and ums commands.

Why no patch to enable it on the board as well then ?

> 
> Signed-off-by: Zixun LI <admin@hifiphile.com>
> ---
>  arch/arm/dts/sam9x60.dtsi                        | 14 ++++++++++++++
>  arch/arm/mach-at91/include/mach/atmel_usba_udc.h |  2 +-
>  drivers/usb/gadget/atmel_usba_udc.c              |  1 +

Device tree and driver changes should be separate commits.


>  3 files changed, 16 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/dts/sam9x60.dtsi b/arch/arm/dts/sam9x60.dtsi
> index 3b684fc63d5..96a8faf09b3 100644
> --- a/arch/arm/dts/sam9x60.dtsi
> +++ b/arch/arm/dts/sam9x60.dtsi
> @@ -69,6 +69,20 @@
>  		#size-cells = <1>;
>  		ranges;
>  
> +		usb0: gadget@500000 {
> +			compatible = "microchip,sam9x60-udc";
> +			reg = <0x500000 0x100000>,
> +				<0xf803c000 0x400>;
> +			#address-cells = <1>;
> +			#size-cells = <0>;
Can you please reorder these to have them in the same order as in Linux
DTS ? (easier to diff...)

> +			interrupts = <23 IRQ_TYPE_LEVEL_HIGH 2>;
> +			clocks = <&pmc PMC_TYPE_PERIPHERAL 23>, <&pmc PMC_TYPE_CORE 8>;
> +			clock-names = "pclk", "hclk";
> +			assigned-clocks = <&pmc PMC_TYPE_CORE 8>;
> +			assigned-clock-rates = <480000000>;
> +			status = "disabled";
> +		};
> +
>  		usb1: usb@600000 {
>  			compatible = "atmel,at91rm9200-ohci", "usb-ohci";
>  			reg = <0x00600000 0x100000>;
> diff --git a/arch/arm/mach-at91/include/mach/atmel_usba_udc.h b/arch/arm/mach-at91/include/mach/atmel_usba_udc.h
> index 835b47d91ba..23c71985c90 100644
> --- a/arch/arm/mach-at91/include/mach/atmel_usba_udc.h
> +++ b/arch/arm/mach-at91/include/mach/atmel_usba_udc.h
> @@ -20,7 +20,7 @@
>  	}
>  
>  #if defined(CONFIG_AT91SAM9G45) || defined(CONFIG_AT91SAM9M10G45) || \
> -	defined(CONFIG_AT91SAM9X5)
> +	defined(CONFIG_AT91SAM9X5) || defined(CONFIG_SAM9X60)
>  static struct usba_ep_data usba_udc_ep[] = {
>  	EP("ep0", 0, 64, 1, 0, 0),
>  	EP("ep1", 1, 1024, 2, 1, 1),
> diff --git a/drivers/usb/gadget/atmel_usba_udc.c b/drivers/usb/gadget/atmel_usba_udc.c
> index a77037a7094..f9326f0a7e7 100644
> --- a/drivers/usb/gadget/atmel_usba_udc.c
> +++ b/drivers/usb/gadget/atmel_usba_udc.c
> @@ -1443,6 +1443,7 @@ static const struct udevice_id usba_udc_ids[] = {
>  	{ .compatible = "atmel,at91sam9rl-udc" },
>  	{ .compatible = "atmel,at91sam9g45-udc" },
>  	{ .compatible = "atmel,sama5d3-udc" },
> +	{ .compatible = "microchip,sam9x60-udc" },
>  	{}
>  };
>  


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] usb: gadget: atmel: Add SAM9X60 support
  2025-03-24  9:23 ` Eugen Hristev
@ 2025-03-31  9:05   ` Mattijs Korpershoek
  2025-03-31  9:26     ` Eugen Hristev
  0 siblings, 1 reply; 7+ messages in thread
From: Mattijs Korpershoek @ 2025-03-31  9:05 UTC (permalink / raw)
  To: Eugen Hristev, Zixun LI, Tom Rini, Lukasz Majewski, Marek Vasut; +Cc: u-boot

Hi Eugen, Zixun,

On lun., mars 24, 2025 at 11:23, Eugen Hristev <eugen.hristev@linaro.org> wrote:

> On 3/22/25 22:56, Zixun LI wrote:
>> Add compatible "microchip,sam9x60-udc" and device tree binding.
>> Compared to SAM9X5 the only difference is the DPRAM memory from the
>> USB High Speed Device Port (UDPHS) hardware block was increased,
>> so we can reuse the same endpoint data.
>> 
>> Tested on SAM9X60-Curiosity board with nfs and ums commands.
>
> Why no patch to enable it on the board as well then ?

Looking at configs/at91sam9x5ek_mmc_defconfig, I don't see
CMD_USB_MASS_STORAGE=y in there as well.

Could you elaborate on why you'd want this to be enabled as part of the
driver series?

On one hand, users has more built-in commands available and it eases the
testing. On the other hand, some users might not be interested in having
this by default. Enabling it via menuconfig is quite easy.

>
>> 
>> Signed-off-by: Zixun LI <admin@hifiphile.com>
>> ---
>>  arch/arm/dts/sam9x60.dtsi                        | 14 ++++++++++++++
>>  arch/arm/mach-at91/include/mach/atmel_usba_udc.h |  2 +-
>>  drivers/usb/gadget/atmel_usba_udc.c              |  1 +
>
> Device tree and driver changes should be separate commits.

I agree with Eugen. Could you please split this out, Zixun?

>
>
>>  3 files changed, 16 insertions(+), 1 deletion(-)
>> 
>> diff --git a/arch/arm/dts/sam9x60.dtsi b/arch/arm/dts/sam9x60.dtsi
>> index 3b684fc63d5..96a8faf09b3 100644
>> --- a/arch/arm/dts/sam9x60.dtsi
>> +++ b/arch/arm/dts/sam9x60.dtsi
>> @@ -69,6 +69,20 @@
>>  		#size-cells = <1>;
>>  		ranges;
>>  
>> +		usb0: gadget@500000 {
>> +			compatible = "microchip,sam9x60-udc";
>> +			reg = <0x500000 0x100000>,
>> +				<0xf803c000 0x400>;
>> +			#address-cells = <1>;
>> +			#size-cells = <0>;
> Can you please reorder these to have them in the same order as in Linux
> DTS ? (easier to diff...)

Agreed with Eugen.

>
>> +			interrupts = <23 IRQ_TYPE_LEVEL_HIGH 2>;
>> +			clocks = <&pmc PMC_TYPE_PERIPHERAL 23>, <&pmc PMC_TYPE_CORE 8>;
>> +			clock-names = "pclk", "hclk";
>> +			assigned-clocks = <&pmc PMC_TYPE_CORE 8>;
>> +			assigned-clock-rates = <480000000>;
>> +			status = "disabled";
>> +		};
>> +
>>  		usb1: usb@600000 {
>>  			compatible = "atmel,at91rm9200-ohci", "usb-ohci";
>>  			reg = <0x00600000 0x100000>;
>> diff --git a/arch/arm/mach-at91/include/mach/atmel_usba_udc.h b/arch/arm/mach-at91/include/mach/atmel_usba_udc.h
>> index 835b47d91ba..23c71985c90 100644
>> --- a/arch/arm/mach-at91/include/mach/atmel_usba_udc.h
>> +++ b/arch/arm/mach-at91/include/mach/atmel_usba_udc.h
>> @@ -20,7 +20,7 @@
>>  	}
>>  
>>  #if defined(CONFIG_AT91SAM9G45) || defined(CONFIG_AT91SAM9M10G45) || \
>> -	defined(CONFIG_AT91SAM9X5)
>> +	defined(CONFIG_AT91SAM9X5) || defined(CONFIG_SAM9X60)
>>  static struct usba_ep_data usba_udc_ep[] = {
>>  	EP("ep0", 0, 64, 1, 0, 0),
>>  	EP("ep1", 1, 1024, 2, 1, 1),
>> diff --git a/drivers/usb/gadget/atmel_usba_udc.c b/drivers/usb/gadget/atmel_usba_udc.c
>> index a77037a7094..f9326f0a7e7 100644
>> --- a/drivers/usb/gadget/atmel_usba_udc.c
>> +++ b/drivers/usb/gadget/atmel_usba_udc.c
>> @@ -1443,6 +1443,7 @@ static const struct udevice_id usba_udc_ids[] = {
>>  	{ .compatible = "atmel,at91sam9rl-udc" },
>>  	{ .compatible = "atmel,at91sam9g45-udc" },
>>  	{ .compatible = "atmel,sama5d3-udc" },
>> +	{ .compatible = "microchip,sam9x60-udc" },
>>  	{}
>>  };
>>  

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] usb: gadget: atmel: Add SAM9X60 support
  2025-03-31  9:05   ` Mattijs Korpershoek
@ 2025-03-31  9:26     ` Eugen Hristev
  2025-03-31  9:39       ` Mattijs Korpershoek
  0 siblings, 1 reply; 7+ messages in thread
From: Eugen Hristev @ 2025-03-31  9:26 UTC (permalink / raw)
  To: Mattijs Korpershoek, Zixun LI, Tom Rini, Lukasz Majewski,
	Marek Vasut
  Cc: u-boot



On 3/31/25 12:05, Mattijs Korpershoek wrote:
> Hi Eugen, Zixun,
> 
> On lun., mars 24, 2025 at 11:23, Eugen Hristev <eugen.hristev@linaro.org> wrote:
> 
>> On 3/22/25 22:56, Zixun LI wrote:
>>> Add compatible "microchip,sam9x60-udc" and device tree binding.
>>> Compared to SAM9X5 the only difference is the DPRAM memory from the
>>> USB High Speed Device Port (UDPHS) hardware block was increased,
>>> so we can reuse the same endpoint data.
>>>
>>> Tested on SAM9X60-Curiosity board with nfs and ums commands.
>>
>> Why no patch to enable it on the board as well then ?
> 
> Looking at configs/at91sam9x5ek_mmc_defconfig, I don't see
> CMD_USB_MASS_STORAGE=y in there as well.
> 
> Could you elaborate on why you'd want this to be enabled as part of the
> driver series?
> 
> On one hand, users has more built-in commands available and it eases the
> testing. On the other hand, some users might not be interested in having
> this by default. Enabling it via menuconfig is quite easy.

What I meant is have the node in the board DT (gadget@500000).
That cannot be enabled in the menuconfig.
The Gadget or the Host should be described in the DT as it's a
description of the board, if the board supports both Gadget and Host ,
both should be in the DT.

If there is a hardware limitation, or something that allows only one of
these to work at the same time, this should be detailed, and have both
nodes anyway, with one of them Disabled, possibly two different DTs with
either of the nodes enabled/disabled.

> 
>>
>>>
>>> Signed-off-by: Zixun LI <admin@hifiphile.com>
>>> ---
>>>  arch/arm/dts/sam9x60.dtsi                        | 14 ++++++++++++++
>>>  arch/arm/mach-at91/include/mach/atmel_usba_udc.h |  2 +-
>>>  drivers/usb/gadget/atmel_usba_udc.c              |  1 +
>>
>> Device tree and driver changes should be separate commits.
> 
> I agree with Eugen. Could you please split this out, Zixun?
> 
>>
>>
>>>  3 files changed, 16 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm/dts/sam9x60.dtsi b/arch/arm/dts/sam9x60.dtsi
>>> index 3b684fc63d5..96a8faf09b3 100644
>>> --- a/arch/arm/dts/sam9x60.dtsi
>>> +++ b/arch/arm/dts/sam9x60.dtsi
>>> @@ -69,6 +69,20 @@
>>>  		#size-cells = <1>;
>>>  		ranges;
>>>  
>>> +		usb0: gadget@500000 {
>>> +			compatible = "microchip,sam9x60-udc";
>>> +			reg = <0x500000 0x100000>,
>>> +				<0xf803c000 0x400>;
>>> +			#address-cells = <1>;
>>> +			#size-cells = <0>;
>> Can you please reorder these to have them in the same order as in Linux
>> DTS ? (easier to diff...)
> 
> Agreed with Eugen.
> 
>>
>>> +			interrupts = <23 IRQ_TYPE_LEVEL_HIGH 2>;
>>> +			clocks = <&pmc PMC_TYPE_PERIPHERAL 23>, <&pmc PMC_TYPE_CORE 8>;
>>> +			clock-names = "pclk", "hclk";
>>> +			assigned-clocks = <&pmc PMC_TYPE_CORE 8>;
>>> +			assigned-clock-rates = <480000000>;
>>> +			status = "disabled";
>>> +		};
>>> +
>>>  		usb1: usb@600000 {
>>>  			compatible = "atmel,at91rm9200-ohci", "usb-ohci";
>>>  			reg = <0x00600000 0x100000>;
>>> diff --git a/arch/arm/mach-at91/include/mach/atmel_usba_udc.h b/arch/arm/mach-at91/include/mach/atmel_usba_udc.h
>>> index 835b47d91ba..23c71985c90 100644
>>> --- a/arch/arm/mach-at91/include/mach/atmel_usba_udc.h
>>> +++ b/arch/arm/mach-at91/include/mach/atmel_usba_udc.h
>>> @@ -20,7 +20,7 @@
>>>  	}
>>>  
>>>  #if defined(CONFIG_AT91SAM9G45) || defined(CONFIG_AT91SAM9M10G45) || \
>>> -	defined(CONFIG_AT91SAM9X5)
>>> +	defined(CONFIG_AT91SAM9X5) || defined(CONFIG_SAM9X60)
>>>  static struct usba_ep_data usba_udc_ep[] = {
>>>  	EP("ep0", 0, 64, 1, 0, 0),
>>>  	EP("ep1", 1, 1024, 2, 1, 1),
>>> diff --git a/drivers/usb/gadget/atmel_usba_udc.c b/drivers/usb/gadget/atmel_usba_udc.c
>>> index a77037a7094..f9326f0a7e7 100644
>>> --- a/drivers/usb/gadget/atmel_usba_udc.c
>>> +++ b/drivers/usb/gadget/atmel_usba_udc.c
>>> @@ -1443,6 +1443,7 @@ static const struct udevice_id usba_udc_ids[] = {
>>>  	{ .compatible = "atmel,at91sam9rl-udc" },
>>>  	{ .compatible = "atmel,at91sam9g45-udc" },
>>>  	{ .compatible = "atmel,sama5d3-udc" },
>>> +	{ .compatible = "microchip,sam9x60-udc" },
>>>  	{}
>>>  };
>>>  


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] usb: gadget: atmel: Add SAM9X60 support
  2025-03-31  9:26     ` Eugen Hristev
@ 2025-03-31  9:39       ` Mattijs Korpershoek
  2025-03-31 16:03         ` Zixun LI
  0 siblings, 1 reply; 7+ messages in thread
From: Mattijs Korpershoek @ 2025-03-31  9:39 UTC (permalink / raw)
  To: Eugen Hristev, Zixun LI, Tom Rini, Lukasz Majewski, Marek Vasut; +Cc: u-boot

Hi Eugen,

On lun., mars 31, 2025 at 12:26, Eugen Hristev <eugen.hristev@linaro.org> wrote:

> On 3/31/25 12:05, Mattijs Korpershoek wrote:
>> Hi Eugen, Zixun,
>> 
>> On lun., mars 24, 2025 at 11:23, Eugen Hristev <eugen.hristev@linaro.org> wrote:
>> 
>>> On 3/22/25 22:56, Zixun LI wrote:
>>>> Add compatible "microchip,sam9x60-udc" and device tree binding.
>>>> Compared to SAM9X5 the only difference is the DPRAM memory from the
>>>> USB High Speed Device Port (UDPHS) hardware block was increased,
>>>> so we can reuse the same endpoint data.
>>>>
>>>> Tested on SAM9X60-Curiosity board with nfs and ums commands.
>>>
>>> Why no patch to enable it on the board as well then ?
>> 
>> Looking at configs/at91sam9x5ek_mmc_defconfig, I don't see
>> CMD_USB_MASS_STORAGE=y in there as well.
>> 
>> Could you elaborate on why you'd want this to be enabled as part of the
>> driver series?
>> 
>> On one hand, users has more built-in commands available and it eases the
>> testing. On the other hand, some users might not be interested in having
>> this by default. Enabling it via menuconfig is quite easy.
>
> What I meant is have the node in the board DT (gadget@500000).
> That cannot be enabled in the menuconfig.
> The Gadget or the Host should be described in the DT as it's a
> description of the board, if the board supports both Gadget and Host ,
> both should be in the DT.
>
> If there is a hardware limitation, or something that allows only one of
> these to work at the same time, this should be detailed, and have both
> nodes anyway, with one of them Disabled, possibly two different DTs with
> either of the nodes enabled/disabled.

I see. Sorry I misunderstood your point initially.
I agree with you: we should enable usb0 in
arch/arm/dts/at91-sam9x60_curiosity.dts as part of this series.

Thanks for the clarification!

>
>> 
>>>
>>>>
>>>> Signed-off-by: Zixun LI <admin@hifiphile.com>
>>>> ---

[...]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] usb: gadget: atmel: Add SAM9X60 support
  2025-03-31  9:39       ` Mattijs Korpershoek
@ 2025-03-31 16:03         ` Zixun LI
  0 siblings, 0 replies; 7+ messages in thread
From: Zixun LI @ 2025-03-31 16:03 UTC (permalink / raw)
  To: Mattijs Korpershoek
  Cc: Eugen Hristev, Tom Rini, Lukasz Majewski, Marek Vasut, u-boot

On Mon, Mar 31, 2025 at 11:39 AM Mattijs Korpershoek
<mkorpershoek@baylibre.com> wrote:
>
> Hi Eugen,
>
> On lun., mars 31, 2025 at 12:26, Eugen Hristev <eugen.hristev@linaro.org> wrote:
>
> > On 3/31/25 12:05, Mattijs Korpershoek wrote:
> >> Hi Eugen, Zixun,
> >>
> >> On lun., mars 24, 2025 at 11:23, Eugen Hristev <eugen.hristev@linaro.org> wrote:
> > If there is a hardware limitation, or something that allows only one of
> > these to work at the same time, this should be detailed, and have both
> > nodes anyway, with one of them Disabled, possibly two different DTs with
> > either of the nodes enabled/disabled.
>
> I see. Sorry I misunderstood your point initially.
> I agree with you: we should enable usb0 in
> arch/arm/dts/at91-sam9x60_curiosity.dts as part of this series.

Hi Eugen, Mattijs,

Thank you for the explanation, I was wrong about the gadget host conflict,
in fact on gadget stop it does switch back to host mode. I've also tested
on SAM9X60 that "usb start" works after the ums command is completed.
It's safe to add status=ok in board dts.

Zixun

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2025-03-31 17:00 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-22 20:56 [PATCH] usb: gadget: atmel: Add SAM9X60 support Zixun LI
2025-03-22 22:59 ` Marek Vasut
2025-03-24  9:23 ` Eugen Hristev
2025-03-31  9:05   ` Mattijs Korpershoek
2025-03-31  9:26     ` Eugen Hristev
2025-03-31  9:39       ` Mattijs Korpershoek
2025-03-31 16:03         ` Zixun LI

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox