Re: [PATCH v2 3/5] configs: am62px_evm_a53_defconfig: enable USB DFU support

[Mattijs Korpershoek <mkorpershoek@baylibre.com>]

Hi Siddharth,

Thank you for the patch.

On mer., déc. 18, 2024 at 18:15, Siddharth Vadapalli <s-vadapalli@ti.com> wrote:

> The config fragment "am62x_a53_usbdfu.config" which adds USB DFU support
> for AM62x SoC is applicable to the AM62Px SoC as well. Hence, include it
> in "am62px_evm_a53_defconfig" in order to enable support for USB DFU
> flash and boot. Remove those configs from "am62px_evm_a53_defconfig" which
> are present in the "am62x_a53_usbdfu.config" config fragment that is being
> included.
>
> Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>

Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>

> ---
> This patch has been newly introduced in this series based on the
> discussion at:
> https://patchwork.ozlabs.org/project/uboot/patch/20241217131658.2920799-3-s-vadapalli@ti.com/#3432702
>
>  configs/am62px_evm_a53_defconfig | 24 +-----------------------
>  1 file changed, 1 insertion(+), 23 deletions(-)
>
> diff --git a/configs/am62px_evm_a53_defconfig b/configs/am62px_evm_a53_defconfig
> index 9635beb1b27..9862b1f9a16 100644
> --- a/configs/am62px_evm_a53_defconfig
> +++ b/configs/am62px_evm_a53_defconfig
> @@ -41,14 +41,11 @@ CONFIG_SPL_SYS_MMCSD_RAW_MODE=y
>  CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_USE_SECTOR=y
>  CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR=0x1400
>  CONFIG_SPL_DMA=y
> -CONFIG_SPL_ENV_SUPPORT=y
>  CONFIG_SPL_FS_LOAD_PAYLOAD_NAME="u-boot.img"
>  CONFIG_SPL_I2C=y
>  CONFIG_SPL_DM_MAILBOX=y
>  CONFIG_SPL_DM_SPI_FLASH=y
>  CONFIG_SPL_POWER_DOMAIN=y
> -CONFIG_SPL_RAM_SUPPORT=y
> -CONFIG_SPL_RAM_DEVICE=y
>  # CONFIG_SPL_SPI_FLASH_TINY is not set
>  CONFIG_SPL_SPI_FLASH_SFDP_SUPPORT=y
>  CONFIG_SPL_SPI_LOAD=y
> @@ -58,14 +55,12 @@ CONFIG_SPL_YMODEM_SUPPORT=y
>  CONFIG_CMD_BOOTEFI_SELFTEST=y
>  CONFIG_CMD_NVEDIT_EFI=y
>  CONFIG_CMD_CLK=y
> -CONFIG_CMD_DFU=y
>  CONFIG_CMD_GPIO=y
>  CONFIG_CMD_GPT=y
>  CONFIG_CMD_I2C=y
>  CONFIG_CMD_MMC=y
>  CONFIG_CMD_MTD=y
>  CONFIG_CMD_REMOTEPROC=y
> -CONFIG_CMD_USB=y
>  CONFIG_CMD_USB_MASS_STORAGE=y
>  CONFIG_CMD_EFIDEBUG=y
>  CONFIG_CMD_TIME=y
> @@ -85,17 +80,12 @@ CONFIG_SPL_DM_DEVICE_REMOVE=y
>  CONFIG_SPL_DM_SEQ_ALIAS=y
>  CONFIG_REGMAP=y
>  CONFIG_SPL_REGMAP=y
> -CONFIG_SPL_SYSCON=y
>  CONFIG_SPL_OF_TRANSLATE=y
>  CONFIG_CLK=y
>  CONFIG_SPL_CLK=y
>  CONFIG_CLK_TI_SCI=y
> -CONFIG_DFU_MMC=y
>  CONFIG_DFU_MTD=y
> -CONFIG_DFU_RAM=y
>  CONFIG_DFU_SF=y
> -CONFIG_SYS_DFU_DATA_BUF_SIZE=0x40000
> -CONFIG_SYS_DFU_MAX_FILE_SIZE=0x800000
>  CONFIG_DMA_CHANNELS=y
>  CONFIG_TI_K3_NAVSS_UDMA=y
>  CONFIG_USB_FUNCTION_FASTBOOT=y
> @@ -164,22 +154,10 @@ CONFIG_SYSRESET=y
>  CONFIG_SPL_SYSRESET=y
>  CONFIG_SYSRESET_TI_SCI=y
>  CONFIG_DM_THERMAL=y
> -CONFIG_USB=y
> -CONFIG_DM_USB_GADGET=y
> -CONFIG_SPL_DM_USB_GADGET=y
>  CONFIG_SPL_USB_HOST=y
> -CONFIG_USB_XHCI_HCD=y
> -CONFIG_USB_DWC3=y
> -CONFIG_USB_DWC3_GENERIC=y
> -CONFIG_SPL_USB_DWC3_GENERIC=y
>  CONFIG_SPL_USB_STORAGE=y
> -CONFIG_USB_GADGET=y
> -CONFIG_SPL_USB_GADGET=y
> -CONFIG_USB_GADGET_MANUFACTURER="Texas Instruments"
> -CONFIG_USB_GADGET_VENDOR_NUM=0x0451
> -CONFIG_USB_GADGET_PRODUCT_NUM=0x6165
> -CONFIG_SPL_DFU=y
>  CONFIG_FS_FAT_MAX_CLUSTSIZE=16384
>  CONFIG_EFI_SET_TIME=y
>  
>  #include <configs/k3_efi_capsule.config>
> +#include <configs/am62x_a53_usbdfu.config>
> -- 
> 2.43.0