U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mattijs Korpershoek <mkorpershoek@baylibre.com>
To: Siddharth Vadapalli <s-vadapalli@ti.com>,
	vigneshr@ti.com, bb@ti.com, trini@konsulko.com, lukma@denx.de,
	n-francis@ti.com, afd@ti.com, glaroque@baylibre.com,
	sjoerd@collabora.com, martyn.welch@collabora.com,
	rasmus.villemoes@prevas.dk, caleb.connolly@linaro.org,
	j-humphreys@ti.com, rogerq@kernel.org, nm@ti.com
Cc: u-boot@lists.denx.de, srk@ti.com, s-vadapalli@ti.com
Subject: Re: [PATCH v2 1/5] board: ti: am62px: env: include environment for DFU Boot
Date: Wed, 18 Dec 2024 14:00:13 +0100	[thread overview]
Message-ID: <878qsdw3he.fsf@baylibre.com> (raw)
In-Reply-To: <20241218124542.3519447-2-s-vadapalli@ti.com>

Hi Siddharth,

Thank you for the patch.

On mer., déc. 18, 2024 at 18:15, Siddharth Vadapalli <s-vadapalli@ti.com> wrote:

> Include the TI K3 DFU environment to support DFU Boot and DFU Flash.
> Also add "usb" to the list of "boot_targets". While at it, add a newline
> at the end of the file.
>
> Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>

Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>

> ---
> v1:
> https://patchwork.ozlabs.org/project/uboot/patch/20241217131658.2920799-3-s-vadapalli@ti.com/
> Changes since v1:
> - Updated commit message indicating that a newline is also being added
>   at the end of this file based on feedback from Mattijs Korpershoek on
>   the v1 patch.
>
>  board/ti/am62px/am62px.env | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/board/ti/am62px/am62px.env b/board/ti/am62px/am62px.env
> index 7ef54079aa8..e0838196e3a 100644
> --- a/board/ti/am62px/am62px.env
> +++ b/board/ti/am62px/am62px.env
> @@ -1,5 +1,6 @@
>  #include <env/ti/ti_common.env>
>  #include <env/ti/mmc.env>
> +#include <env/ti/k3_dfu.env>
>  
>  name_kern=Image
>  console=ttyS2,115200n8
> @@ -7,7 +8,7 @@ args_all=setenv optargs ${optargs} earlycon=ns16550a,mmio32,0x02800000
>  	${mtdparts}
>  run_kern=booti ${loadaddr} ${rd_spec} ${fdtaddr}
>  
> -boot_targets=mmc1 mmc0 pxe dhcp
> +boot_targets=mmc1 mmc0 usb pxe dhcp
>  boot=mmc
>  mmcdev=1
>  bootpart=1:2
> @@ -17,4 +18,4 @@ rd_spec=-
>  #if CONFIG_BOOTMETH_ANDROID
>  #include <env/ti/android.env>
>  adtb_idx=3
> -#endif
> \ No newline at end of file
> +#endif
> -- 
> 2.43.0

  reply	other threads:[~2024-12-18 13:00 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-18 12:45 [PATCH v2 0/5] Add support for USB DFU boot on AM62Px Siddharth Vadapalli
2024-12-18 12:45 ` [PATCH v2 1/5] board: ti: am62px: env: include environment for DFU Boot Siddharth Vadapalli
2024-12-18 13:00   ` Mattijs Korpershoek [this message]
2024-12-18 13:48   ` Roger Quadros
2024-12-18 12:45 ` [PATCH v2 2/5] configs: am62x_r5_usbdfu: extend for AM62Px Siddharth Vadapalli
2024-12-18 13:56   ` Roger Quadros
2024-12-18 12:45 ` [PATCH v2 3/5] configs: am62px_evm_a53_defconfig: enable USB DFU support Siddharth Vadapalli
2024-12-18 13:01   ` Mattijs Korpershoek
2024-12-18 13:47   ` Roger Quadros
2024-12-19  5:43     ` Siddharth Vadapalli
2024-12-19  9:38       ` Roger Quadros
2024-12-19 10:00         ` Siddharth Vadapalli
2024-12-18 12:45 ` [PATCH v2 4/5] arm: dts: k3-am62p5-sk-u-boot: enable USB0 for USB DFU boot Siddharth Vadapalli
2024-12-18 14:05   ` Roger Quadros
2024-12-19  5:50     ` Siddharth Vadapalli
2024-12-19  9:41       ` Roger Quadros
2024-12-19 17:00         ` Tom Rini
2024-12-20  4:49           ` Siddharth Vadapalli
2024-12-20  5:49             ` Siddharth Vadapalli
2024-12-20 14:25             ` Tom Rini
2024-12-20 16:19               ` Siddharth Vadapalli
2024-12-20 16:37                 ` Tom Rini
2024-12-21  2:54                   ` Siddharth Vadapalli
2024-12-18 12:45 ` [PATCH v2 5/5] doc: board: document support for USB DFU boot on AM62Px SoC Siddharth Vadapalli
2024-12-18 13:02   ` Mattijs Korpershoek
2024-12-18 14:08   ` Roger Quadros
2024-12-19  6:43     ` Siddharth Vadapalli
2024-12-19  9:42       ` Roger Quadros
2024-12-18 12:59 ` [PATCH v2 0/5] Add support for USB DFU boot on AM62Px Mattijs Korpershoek
2024-12-19  5:37   ` Siddharth Vadapalli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878qsdw3he.fsf@baylibre.com \
    --to=mkorpershoek@baylibre.com \
    --cc=afd@ti.com \
    --cc=bb@ti.com \
    --cc=caleb.connolly@linaro.org \
    --cc=glaroque@baylibre.com \
    --cc=j-humphreys@ti.com \
    --cc=lukma@denx.de \
    --cc=martyn.welch@collabora.com \
    --cc=n-francis@ti.com \
    --cc=nm@ti.com \
    --cc=rasmus.villemoes@prevas.dk \
    --cc=rogerq@kernel.org \
    --cc=s-vadapalli@ti.com \
    --cc=sjoerd@collabora.com \
    --cc=srk@ti.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox