From: Roger Quadros <rogerq@kernel.org>
To: Siddharth Vadapalli <s-vadapalli@ti.com>,
vigneshr@ti.com, bb@ti.com, trini@konsulko.com, lukma@denx.de,
n-francis@ti.com, mkorpershoek@baylibre.com, afd@ti.com,
glaroque@baylibre.com, sjoerd@collabora.com,
martyn.welch@collabora.com, rasmus.villemoes@prevas.dk,
caleb.connolly@linaro.org, j-humphreys@ti.com, nm@ti.com
Cc: u-boot@lists.denx.de, srk@ti.com
Subject: Re: [PATCH v2 4/5] arm: dts: k3-am62p5-sk-u-boot: enable USB0 for USB DFU boot
Date: Wed, 18 Dec 2024 16:05:47 +0200 [thread overview]
Message-ID: <e4b23017-375e-4430-aef2-001c1b6402ca@kernel.org> (raw)
In-Reply-To: <20241218124542.3519447-5-s-vadapalli@ti.com>
Hi Siddharth,
On 18/12/2024 14:45, Siddharth Vadapalli wrote:
> Enable USB0 instance of the USB controller for USB DFU boot functionality
> which requires the "bootph-all" property in order to have USB enabled at
> all stages of the USB DFU boot.
>
> Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
> Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
> ---
> v1:
> https://patchwork.ozlabs.org/project/uboot/patch/20241217131658.2920799-5-s-vadapalli@ti.com/
> Changes since v1:
> - Collected Reviewed-by tag.
>
> arch/arm/dts/k3-am62p5-sk-u-boot.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm/dts/k3-am62p5-sk-u-boot.dtsi b/arch/arm/dts/k3-am62p5-sk-u-boot.dtsi
> index cf087c6e343..c2091fc1a51 100644
> --- a/arch/arm/dts/k3-am62p5-sk-u-boot.dtsi
> +++ b/arch/arm/dts/k3-am62p5-sk-u-boot.dtsi
> @@ -16,3 +16,13 @@
> &dmsc {
> bootph-pre-ram;
> };
> +
> +/* Required for USB DFU boot */
> +&usbss0 {
> + status = "okay";
> +};
This should come via upstream DT sync?
> +
> +/* Required for USB DFU boot */
> +&usb0 {
> + bootph-all;
> +};
This as well? But I don't see it upstream. Do you have a patch for upstream DT?
--
cheers,
-roger
next prev parent reply other threads:[~2024-12-18 14:06 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-18 12:45 [PATCH v2 0/5] Add support for USB DFU boot on AM62Px Siddharth Vadapalli
2024-12-18 12:45 ` [PATCH v2 1/5] board: ti: am62px: env: include environment for DFU Boot Siddharth Vadapalli
2024-12-18 13:00 ` Mattijs Korpershoek
2024-12-18 13:48 ` Roger Quadros
2024-12-18 12:45 ` [PATCH v2 2/5] configs: am62x_r5_usbdfu: extend for AM62Px Siddharth Vadapalli
2024-12-18 13:56 ` Roger Quadros
2024-12-18 12:45 ` [PATCH v2 3/5] configs: am62px_evm_a53_defconfig: enable USB DFU support Siddharth Vadapalli
2024-12-18 13:01 ` Mattijs Korpershoek
2024-12-18 13:47 ` Roger Quadros
2024-12-19 5:43 ` Siddharth Vadapalli
2024-12-19 9:38 ` Roger Quadros
2024-12-19 10:00 ` Siddharth Vadapalli
2024-12-18 12:45 ` [PATCH v2 4/5] arm: dts: k3-am62p5-sk-u-boot: enable USB0 for USB DFU boot Siddharth Vadapalli
2024-12-18 14:05 ` Roger Quadros [this message]
2024-12-19 5:50 ` Siddharth Vadapalli
2024-12-19 9:41 ` Roger Quadros
2024-12-19 17:00 ` Tom Rini
2024-12-20 4:49 ` Siddharth Vadapalli
2024-12-20 5:49 ` Siddharth Vadapalli
2024-12-20 14:25 ` Tom Rini
2024-12-20 16:19 ` Siddharth Vadapalli
2024-12-20 16:37 ` Tom Rini
2024-12-21 2:54 ` Siddharth Vadapalli
2024-12-18 12:45 ` [PATCH v2 5/5] doc: board: document support for USB DFU boot on AM62Px SoC Siddharth Vadapalli
2024-12-18 13:02 ` Mattijs Korpershoek
2024-12-18 14:08 ` Roger Quadros
2024-12-19 6:43 ` Siddharth Vadapalli
2024-12-19 9:42 ` Roger Quadros
2024-12-18 12:59 ` [PATCH v2 0/5] Add support for USB DFU boot on AM62Px Mattijs Korpershoek
2024-12-19 5:37 ` Siddharth Vadapalli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4b23017-375e-4430-aef2-001c1b6402ca@kernel.org \
--to=rogerq@kernel.org \
--cc=afd@ti.com \
--cc=bb@ti.com \
--cc=caleb.connolly@linaro.org \
--cc=glaroque@baylibre.com \
--cc=j-humphreys@ti.com \
--cc=lukma@denx.de \
--cc=martyn.welch@collabora.com \
--cc=mkorpershoek@baylibre.com \
--cc=n-francis@ti.com \
--cc=nm@ti.com \
--cc=rasmus.villemoes@prevas.dk \
--cc=s-vadapalli@ti.com \
--cc=sjoerd@collabora.com \
--cc=srk@ti.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox