Re: [PATCH 25/81] dfu: Remove <common.h> and add needed includes

[Mattijs Korpershoek <mkorpershoek@baylibre.com>]

Hi Tom,

Thank you for the patch.

On mer., mai 01, 2024 at 19:30, Tom Rini <trini@konsulko.com> wrote:

> Remove <common.h> from this driver directory and when needed
> add missing include files directly.
>
> Signed-off-by: Tom Rini <trini@konsulko.com>

Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>

Since this is quite a big series, I'm assuming you will pick it up
yourself.

If it's expected of me to pick this up through u-boot-dfu, let me know.

> ---
> Cc: Lukasz Majewski <lukma@denx.de>
> Cc: Mattijs Korpershoek <mkorpershoek@baylibre.com>
> Cc: Tom Rini <trini@konsulko.com>
> ---
>  drivers/dfu/dfu.c      | 1 -
>  drivers/dfu/dfu_alt.c  | 1 -
>  drivers/dfu/dfu_mmc.c  | 1 -
>  drivers/dfu/dfu_mtd.c  | 1 -
>  drivers/dfu/dfu_nand.c | 1 -
>  drivers/dfu/dfu_ram.c  | 1 -
>  drivers/dfu/dfu_sf.c   | 1 -
>  drivers/dfu/dfu_virt.c | 1 -
>  8 files changed, 8 deletions(-)
>
> diff --git a/drivers/dfu/dfu.c b/drivers/dfu/dfu.c
> index 2adf26e2fe24..540d48fab77d 100644
> --- a/drivers/dfu/dfu.c
> +++ b/drivers/dfu/dfu.c
> @@ -6,7 +6,6 @@
>   * author: Lukasz Majewski <l.majewski@samsung.com>
>   */
>  
> -#include <common.h>
>  #include <env.h>
>  #include <errno.h>
>  #include <log.h>
> diff --git a/drivers/dfu/dfu_alt.c b/drivers/dfu/dfu_alt.c
> index ece3d2236f3d..e9132936a90b 100644
> --- a/drivers/dfu/dfu_alt.c
> +++ b/drivers/dfu/dfu_alt.c
> @@ -4,7 +4,6 @@
>   * Lukasz Majewski <l.majewski@majess.pl>
>   */
>  
> -#include <common.h>
>  #include <log.h>
>  #include <malloc.h>
>  #include <errno.h>
> diff --git a/drivers/dfu/dfu_mmc.c b/drivers/dfu/dfu_mmc.c
> index 12c54e90ef71..cfa6334e4397 100644
> --- a/drivers/dfu/dfu_mmc.c
> +++ b/drivers/dfu/dfu_mmc.c
> @@ -6,7 +6,6 @@
>   * author: Lukasz Majewski <l.majewski@samsung.com>
>   */
>  
> -#include <common.h>
>  #include <log.h>
>  #include <malloc.h>
>  #include <errno.h>
> diff --git a/drivers/dfu/dfu_mtd.c b/drivers/dfu/dfu_mtd.c
> index 485586989c8a..c36ac09189f3 100644
> --- a/drivers/dfu/dfu_mtd.c
> +++ b/drivers/dfu/dfu_mtd.c
> @@ -7,7 +7,6 @@
>   * Based on dfu_nand.c
>   */
>  
> -#include <common.h>
>  #include <dfu.h>
>  #include <mtd.h>
>  #include <linux/err.h>
> diff --git a/drivers/dfu/dfu_nand.c b/drivers/dfu/dfu_nand.c
> index 08e8cf5cdb37..940cfefc986c 100644
> --- a/drivers/dfu/dfu_nand.c
> +++ b/drivers/dfu/dfu_nand.c
> @@ -9,7 +9,6 @@
>   * author: Lukasz Majewski <l.majewski@samsung.com>
>   */
>  
> -#include <common.h>
>  #include <log.h>
>  #include <malloc.h>
>  #include <errno.h>
> diff --git a/drivers/dfu/dfu_ram.c b/drivers/dfu/dfu_ram.c
> index c4f4bd2e482f..043acbf022fc 100644
> --- a/drivers/dfu/dfu_ram.c
> +++ b/drivers/dfu/dfu_ram.c
> @@ -8,7 +8,6 @@
>   * author: Lukasz Majewski <l.majewski@samsung.com>
>   */
>  
> -#include <common.h>
>  #include <malloc.h>
>  #include <mapmem.h>
>  #include <errno.h>
> diff --git a/drivers/dfu/dfu_sf.c b/drivers/dfu/dfu_sf.c
> index 2dae15937064..7c1c0f9e2dc7 100644
> --- a/drivers/dfu/dfu_sf.c
> +++ b/drivers/dfu/dfu_sf.c
> @@ -3,7 +3,6 @@
>   * Copyright (c) 2014, NVIDIA CORPORATION. All rights reserved.
>   */
>  
> -#include <common.h>
>  #include <malloc.h>
>  #include <errno.h>
>  #include <div64.h>
> diff --git a/drivers/dfu/dfu_virt.c b/drivers/dfu/dfu_virt.c
> index 29f7a08f6728..2c31445af12a 100644
> --- a/drivers/dfu/dfu_virt.c
> +++ b/drivers/dfu/dfu_virt.c
> @@ -2,7 +2,6 @@
>  /*
>   * Copyright (C) 2019, STMicroelectronics - All Rights Reserved
>   */
> -#include <common.h>
>  #include <dfu.h>
>  #include <errno.h>
>  #include <log.h>
> -- 
> 2.34.1