Re: [PATCH 14/81] block: Remove <common.h> and add needed includes

[Mattijs Korpershoek <mkorpershoek@baylibre.com>]

Hi Tom,

Thank you for the patch.

On mer., mai 01, 2024 at 19:30, Tom Rini <trini@konsulko.com> wrote:

> Remove <common.h> from this driver directory and when needed
> add missing include files directly.
>
> Signed-off-by: Tom Rini <trini@konsulko.com>

Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>

> ---
> Cc: Tom Rini <trini@konsulko.com>
> Cc: Tobias Waldekranz <tobias@waldekranz.com>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Cc: Marek Vasut <marek.vasut+renesas@mailbox.org>
> Cc: Bin Meng <bmeng@tinylab.org>
> Cc: Johan Jonker <jbx6244@gmail.com>
> Cc: Kever Yang <kever.yang@rock-chips.com>
> Cc: Dan Carpenter <dan.carpenter@linaro.org>
> Cc: Mattijs Korpershoek <mkorpershoek@baylibre.com>
> ---
>  drivers/block/blk-uclass.c       | 1 -
>  drivers/block/blk_legacy.c       | 1 -
>  drivers/block/blkcache.c         | 1 -
>  drivers/block/blkmap.c           | 1 -
>  drivers/block/efi-media-uclass.c | 1 -
>  drivers/block/efi_blk.c          | 1 -
>  drivers/block/host-uclass.c      | 1 -
>  drivers/block/host_dev.c         | 1 -
>  drivers/block/ide.c              | 1 -
>  drivers/block/sandbox.c          | 1 -
>  drivers/block/sb_efi_media.c     | 1 -
>  11 files changed, 11 deletions(-)
>
> diff --git a/drivers/block/blk-uclass.c b/drivers/block/blk-uclass.c
> index 77066da352a3..512c952f4d7a 100644
> --- a/drivers/block/blk-uclass.c
> +++ b/drivers/block/blk-uclass.c
> @@ -6,7 +6,6 @@
>  
>  #define LOG_CATEGORY UCLASS_BLK
>  
> -#include <common.h>
>  #include <blk.h>
>  #include <dm.h>
>  #include <log.h>
> diff --git a/drivers/block/blk_legacy.c b/drivers/block/blk_legacy.c
> index 5bf1d0471524..f36932183d1f 100644
> --- a/drivers/block/blk_legacy.c
> +++ b/drivers/block/blk_legacy.c
> @@ -4,7 +4,6 @@
>   * Written by Simon Glass <sjg@chromium.org>
>   */
>  
> -#include <common.h>
>  #include <blk.h>
>  #include <part.h>
>  #include <linux/err.h>
> diff --git a/drivers/block/blkcache.c b/drivers/block/blkcache.c
> index 26bcbea43533..0e69160249c7 100644
> --- a/drivers/block/blkcache.c
> +++ b/drivers/block/blkcache.c
> @@ -4,7 +4,6 @@
>   * Author: Eric Nelson<eric@nelint.com>
>   *
>   */
> -#include <common.h>
>  #include <blk.h>
>  #include <log.h>
>  #include <malloc.h>
> diff --git a/drivers/block/blkmap.c b/drivers/block/blkmap.c
> index 21201409ed4b..34eed1380dca 100644
> --- a/drivers/block/blkmap.c
> +++ b/drivers/block/blkmap.c
> @@ -4,7 +4,6 @@
>   * Author: Tobias Waldekranz <tobias@waldekranz.com>
>   */
>  
> -#include <common.h>
>  #include <blk.h>
>  #include <blkmap.h>
>  #include <dm.h>
> diff --git a/drivers/block/efi-media-uclass.c b/drivers/block/efi-media-uclass.c
> index e012f6f2f4c4..dc5e4f59b7f3 100644
> --- a/drivers/block/efi-media-uclass.c
> +++ b/drivers/block/efi-media-uclass.c
> @@ -5,7 +5,6 @@
>   * Copyright 2021 Google LLC
>   */
>  
> -#include <common.h>
>  #include <dm.h>
>  
>  UCLASS_DRIVER(efi_media) = {
> diff --git a/drivers/block/efi_blk.c b/drivers/block/efi_blk.c
> index 917a19f60254..9766cd6f8327 100644
> --- a/drivers/block/efi_blk.c
> +++ b/drivers/block/efi_blk.c
> @@ -8,7 +8,6 @@
>   * Copyright 2021 Google LLC
>   */
>  
> -#include <common.h>
>  #include <blk.h>
>  #include <dm.h>
>  #include <efi.h>
> diff --git a/drivers/block/host-uclass.c b/drivers/block/host-uclass.c
> index b3647e3ce335..cf42bd1e07ac 100644
> --- a/drivers/block/host-uclass.c
> +++ b/drivers/block/host-uclass.c
> @@ -9,7 +9,6 @@
>  
>  #define LOG_CATEGORY UCLASS_HOST
>  
> -#include <common.h>
>  #include <blk.h>
>  #include <dm.h>
>  #include <malloc.h>
> diff --git a/drivers/block/host_dev.c b/drivers/block/host_dev.c
> index 52313435a0cb..b3ff3cd1fab9 100644
> --- a/drivers/block/host_dev.c
> +++ b/drivers/block/host_dev.c
> @@ -9,7 +9,6 @@
>  
>  #define LOG_CATEGORY UCLASS_HOST
>  
> -#include <common.h>
>  #include <blk.h>
>  #include <bootdev.h>
>  #include <dm.h>
> diff --git a/drivers/block/ide.c b/drivers/block/ide.c
> index c698f9cbd558..b16623d7a3ab 100644
> --- a/drivers/block/ide.c
> +++ b/drivers/block/ide.c
> @@ -6,7 +6,6 @@
>  
>  #define LOG_CATEGORY UCLASS_IDE
>  
> -#include <common.h>
>  #include <ata.h>
>  #include <blk.h>
>  #include <bootdev.h>
> diff --git a/drivers/block/sandbox.c b/drivers/block/sandbox.c
> index be4e02cb601a..ec34f1ad8c2e 100644
> --- a/drivers/block/sandbox.c
> +++ b/drivers/block/sandbox.c
> @@ -3,7 +3,6 @@
>   * Copyright (C) 2013 Henrik Nordstrom <henrik@henriknordstrom.net>
>   */
>  
> -#include <common.h>
>  #include <blk.h>
>  #include <dm.h>
>  #include <fdtdec.h>
> diff --git a/drivers/block/sb_efi_media.c b/drivers/block/sb_efi_media.c
> index 52af155a6001..3255db064961 100644
> --- a/drivers/block/sb_efi_media.c
> +++ b/drivers/block/sb_efi_media.c
> @@ -5,7 +5,6 @@
>   * Copyright 2021 Google LLC
>   */
>  
> -#include <common.h>
>  #include <dm.h>
>  
>  static const struct udevice_id sandbox_efi_media_ids[] = {
> -- 
> 2.34.1