From: Tom Rini <trini@konsulko.com>
To: Mario Kicherer <dev@kicherer.org>
Cc: u-boot@lists.denx.de, sbabic@denx.de, festevam@gmail.com,
uboot-imx@nxp.com, daniel.schwierzeck@gmail.com,
weijie.gao@mediatek.com, GSS_MTK_Uboot_upstream@mediatek.com,
rick@andestech.com, ycliang@andestech.com
Subject: Re: [PATCH v2 1/2] spl: spl_nor: add BOOT_DEVICE_NOR2 as alternative SPL_LOAD_IMAGE_METHOD
Date: Thu, 26 Jan 2023 14:17:34 -0500 [thread overview]
Message-ID: <Y9LRzntw7PlH+IGR@bill-the-cat> (raw)
In-Reply-To: <20230119152822.1214202-2-dev@kicherer.org>
[-- Attachment #1: Type: text/plain, Size: 860 bytes --]
On Thu, Jan 19, 2023 at 04:28:21PM +0100, Mario Kicherer wrote:
> Add BOOT_DEVICE_NOR2 as a second SPL_LOAD_IMAGE_METHOD to enable a
> board-specific spl_nor_get_uboot_base() function to return an alternative
> address in the NOR flash in case booting from BOOT_DEVICE_NOR fails.
>
> Signed-off-by: Mario Kicherer <dev@kicherer.org>
> ---
> arch/arm/include/asm/spl.h | 1 +
> arch/mips/include/asm/spl.h | 1 +
> arch/riscv/include/asm/spl.h | 1 +
> common/spl/spl_nor.c | 1 +
> 4 files changed, 4 insertions(+)
This breaks a lot of platforms, as it only covers a few of the cases
where BOOT_DEVICE_NOR is listed. I would also really like to see how
this ends up being used in the board specific case as I do wonder if we
can't solve this some other way that won't have impact so many other
platforms. Thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2023-01-26 19:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-19 15:28 [PATCH v2 0/2] spl: spl_nor: add alternative SPL_LOAD_IMAGE_METHOD Mario Kicherer
2023-01-19 15:28 ` [PATCH v2 1/2] spl: spl_nor: add BOOT_DEVICE_NOR2 as " Mario Kicherer
2023-01-26 19:17 ` Tom Rini [this message]
2023-01-27 16:56 ` Mario Kicherer
2023-01-27 17:10 ` Tom Rini
2023-01-27 17:55 ` Mario Kicherer
2023-01-27 17:58 ` Tom Rini
2023-01-30 10:17 ` Mario Kicherer
2023-01-19 15:28 ` [PATCH v2 2/2] spl: spl_nor: add spl_boot_device parameter to spl_nor_get_uboot_base() Mario Kicherer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9LRzntw7PlH+IGR@bill-the-cat \
--to=trini@konsulko.com \
--cc=GSS_MTK_Uboot_upstream@mediatek.com \
--cc=daniel.schwierzeck@gmail.com \
--cc=dev@kicherer.org \
--cc=festevam@gmail.com \
--cc=rick@andestech.com \
--cc=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
--cc=uboot-imx@nxp.com \
--cc=weijie.gao@mediatek.com \
--cc=ycliang@andestech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox