From: Tom Rini <trini@konsulko.com>
To: Mario Kicherer <dev@kicherer.org>
Cc: u-boot@lists.denx.de, sbabic@denx.de, festevam@gmail.com,
uboot-imx@nxp.com, daniel.schwierzeck@gmail.com,
weijie.gao@mediatek.com, GSS_MTK_Uboot_upstream@mediatek.com,
rick@andestech.com, ycliang@andestech.com
Subject: Re: [PATCH v2 1/2] spl: spl_nor: add BOOT_DEVICE_NOR2 as alternative SPL_LOAD_IMAGE_METHOD
Date: Fri, 27 Jan 2023 12:58:07 -0500 [thread overview]
Message-ID: <Y9QQr837x7OSL0S9@bill-the-cat> (raw)
In-Reply-To: <0f606ddab66a5dab3b8f0bcb856a73f3@kicherer.org>
[-- Attachment #1: Type: text/plain, Size: 1537 bytes --]
On Fri, Jan 27, 2023 at 06:55:46PM +0100, Mario Kicherer wrote:
> On 2023-01-27 18:10, Tom Rini wrote:
> > Yes, all of the platforms that define the value (since it roughly means
> > "ROM set this value in something we can check") instead of enum'ing it
> > still compile that file and now fail to build.
>
> Okay, I think I understand your point now. I am not sure what's the best
> way to proceed here. Should I try to build all targets that contain
> BOOT_DEVICE_NOR and add a #define for BOOT_DEVICE_NOR2 if my patch really
> breaks the build? Or should I just add a #define BOOT_DEVICE_NOR2 to every
> #define BOOT_DEVICE_NOR?
>
> It looks like a change would be necessary in these files then:
>
> arch/arm/include/asm/arch-am33xx/spl.h
> arch/arm/include/asm/arch-orion5x/spl.h
> arch/arm/mach-k3/include/mach/j721e_spl.h
> arch/arm/mach-k3/include/mach/j721s2_spl.h
> arch/microblaze/include/asm/spl.h
> arch/powerpc/include/asm/spl.h
>
> > Ah, OK. Keep in mind that MMC1/MMC2 are for different physical MMC
> > devices on a given platform. I think this is more like the case where
> > you should be able to override spl_nor_get_uboot_base at the board level
> > to say if you're loading A or B?
>
> Ah yes, it's been a while since I wrote this patch originally.
> spl_nor_get_uboot_base() chooses between A and B and BOOT_DEVICE_NOR2
> signals that I should choose the other one now.
I think you should be able to solve this problem without making further
changes upstream, yes.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2023-01-27 17:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-19 15:28 [PATCH v2 0/2] spl: spl_nor: add alternative SPL_LOAD_IMAGE_METHOD Mario Kicherer
2023-01-19 15:28 ` [PATCH v2 1/2] spl: spl_nor: add BOOT_DEVICE_NOR2 as " Mario Kicherer
2023-01-26 19:17 ` Tom Rini
2023-01-27 16:56 ` Mario Kicherer
2023-01-27 17:10 ` Tom Rini
2023-01-27 17:55 ` Mario Kicherer
2023-01-27 17:58 ` Tom Rini [this message]
2023-01-30 10:17 ` Mario Kicherer
2023-01-19 15:28 ` [PATCH v2 2/2] spl: spl_nor: add spl_boot_device parameter to spl_nor_get_uboot_base() Mario Kicherer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9QQr837x7OSL0S9@bill-the-cat \
--to=trini@konsulko.com \
--cc=GSS_MTK_Uboot_upstream@mediatek.com \
--cc=daniel.schwierzeck@gmail.com \
--cc=dev@kicherer.org \
--cc=festevam@gmail.com \
--cc=rick@andestech.com \
--cc=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
--cc=uboot-imx@nxp.com \
--cc=weijie.gao@mediatek.com \
--cc=ycliang@andestech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox