From: Ilias Apalodimas <ilias.apalodimas@linaro.org>
To: Bin Meng <bmeng@tinylab.org>
Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>, u-boot@lists.denx.de
Subject: Re: [PATCH 2/5] efi: selftest: Make load_file() and load_file2() static
Date: Wed, 5 Apr 2023 16:09:10 +0300 [thread overview]
Message-ID: <ZC1y9kGyUROIlvKO@hades> (raw)
In-Reply-To: <20230405121519.778846-2-bmeng@tinylab.org>
On Wed, Apr 05, 2023 at 08:15:16PM +0800, Bin Meng wrote:
> load_file() and load_file2() are only referenced in
> efi_selftest_load_file.c
>
> Signed-off-by: Bin Meng <bmeng@tinylab.org>
> ---
>
> lib/efi_selftest/efi_selftest_load_file.c | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/lib/efi_selftest/efi_selftest_load_file.c b/lib/efi_selftest/efi_selftest_load_file.c
> index 8784a76172..14df761172 100644
> --- a/lib/efi_selftest/efi_selftest_load_file.c
> +++ b/lib/efi_selftest/efi_selftest_load_file.c
> @@ -206,11 +206,11 @@ static efi_status_t decompress(u8 **image)
> * @buffer_size: (required) buffer size
> * @buffer: buffer to which the file is to be loaded
> */
> -efi_status_t EFIAPI load_file(struct efi_load_file_protocol *this,
> - struct efi_device_path *file_path,
> - bool boot_policy,
> - efi_uintn_t *buffer_size,
> - void *buffer)
> +static efi_status_t EFIAPI load_file(struct efi_load_file_protocol *this,
> + struct efi_device_path *file_path,
> + bool boot_policy,
> + efi_uintn_t *buffer_size,
> + void *buffer)
> {
> ++load_file_call_count;
> if (memcmp(file_path, dp_lf_file_remainder,
> @@ -243,11 +243,11 @@ efi_status_t EFIAPI load_file(struct efi_load_file_protocol *this,
> * @buffer_size: (required) buffer size
> * @buffer: buffer to which the file is to be loaded
> */
> -efi_status_t EFIAPI load_file2(struct efi_load_file_protocol *this,
> - struct efi_device_path *file_path,
> - bool boot_policy,
> - efi_uintn_t *buffer_size,
> - void *buffer)
> +static efi_status_t EFIAPI load_file2(struct efi_load_file_protocol *this,
> + struct efi_device_path *file_path,
> + bool boot_policy,
> + efi_uintn_t *buffer_size,
> + void *buffer)
> {
> ++load_file2_call_count;
> if (memcmp(file_path, dp_lf2_file_remainder,
> --
> 2.34.1
>
Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
next prev parent reply other threads:[~2023-04-05 13:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-05 12:15 [PATCH 1/5] efi: selftest: Make record static Bin Meng
2023-04-05 12:15 ` [PATCH 2/5] efi: selftest: Make load_file() and load_file2() static Bin Meng
2023-04-05 13:09 ` Ilias Apalodimas [this message]
2023-04-05 12:15 ` [PATCH 3/5] efi: loader: Make efi_event_queue and efi_register_notify_events static Bin Meng
2023-04-05 13:09 ` Ilias Apalodimas
2023-04-05 12:15 ` [PATCH 4/5] efi: loader: Make efi_mem static Bin Meng
2023-04-05 13:09 ` Ilias Apalodimas
2023-04-05 12:15 ` [PATCH 5/5] efi: loader: Make efi_runtime_mmio static Bin Meng
2023-04-05 13:09 ` Ilias Apalodimas
2023-04-05 13:08 ` [PATCH 1/5] efi: selftest: Make record static Ilias Apalodimas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZC1y9kGyUROIlvKO@hades \
--to=ilias.apalodimas@linaro.org \
--cc=bmeng@tinylab.org \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox