Re: [PATCH 3/5] efi: loader: Make efi_event_queue and efi_register_notify_events static

[Ilias Apalodimas <ilias.apalodimas@linaro.org>]

On Wed, Apr 05, 2023 at 08:15:17PM +0800, Bin Meng wrote:
> efi_event_queue and efi_register_notify_events are only referenced
> in efi_boottime.c
> 
> Signed-off-by: Bin Meng <bmeng@tinylab.org>
> ---
> 
>  include/efi_loader.h          | 3 ---
>  lib/efi_loader/efi_boottime.c | 4 ++--
>  2 files changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/include/efi_loader.h b/include/efi_loader.h
> index 1542b4b625..0a2083c39a 100644
> --- a/include/efi_loader.h
> +++ b/include/efi_loader.h
> @@ -509,9 +509,6 @@ struct efi_register_notify_event {
>  	struct list_head handles;
>  };
>  
> -/* List of all events registered by RegisterProtocolNotify() */
> -extern struct list_head efi_register_notify_events;
> -
>  /* called at pre-initialization */
>  int efi_init_early(void);
>  /* Initialize efi execution environment */
> diff --git a/lib/efi_loader/efi_boottime.c b/lib/efi_loader/efi_boottime.c
> index caaab685ee..d5065f296a 100644
> --- a/lib/efi_loader/efi_boottime.c
> +++ b/lib/efi_loader/efi_boottime.c
> @@ -35,7 +35,7 @@ LIST_HEAD(efi_obj_list);
>  __efi_runtime_data LIST_HEAD(efi_events);
>  
>  /* List of queued events */
> -LIST_HEAD(efi_event_queue);
> +static LIST_HEAD(efi_event_queue);
>  
>  /* Flag to disable timer activity in ExitBootServices() */
>  static bool timers_enabled = true;
> @@ -44,7 +44,7 @@ static bool timers_enabled = true;
>  bool efi_st_keep_devices;
>  
>  /* List of all events registered by RegisterProtocolNotify() */
> -LIST_HEAD(efi_register_notify_events);
> +static LIST_HEAD(efi_register_notify_events);
>  
>  /* Handle of the currently executing image */
>  static efi_handle_t current_image;
> -- 
> 2.34.1
> 
Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>