* [PATCH] drivers: musb_gadget: Save endpoint desc to usb_ep->desc
@ 2021-11-16 0:30 qianfanguijin
2021-11-16 0:43 ` Sean Anderson
2022-01-18 17:39 ` Tom Rini
0 siblings, 2 replies; 5+ messages in thread
From: qianfanguijin @ 2021-11-16 0:30 UTC (permalink / raw)
To: u-boot, seanga2; +Cc: lukma, qianfan Zhao
From: qianfan Zhao <qianfanguijin@163.com>
Fix fastboot flash bug.
If the downloading file size is equal to the partition size, "fastboot
flash" can't work, at least in sunxi platform, because used an
uninitalized point: ep->desc.
This patch also fixed 'data abort' bug in am335x platform.
Reproduce: fastboot flash loader1 spl/sunxi-spl.bin.
Signed-off-by: qianfan Zhao <qianfanguijin@163.com>
---
drivers/usb/musb-new/musb_gadget.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/usb/musb-new/musb_gadget.c b/drivers/usb/musb-new/musb_gadget.c
index 1fef00b292..7cca92b970 100644
--- a/drivers/usb/musb-new/musb_gadget.c
+++ b/drivers/usb/musb-new/musb_gadget.c
@@ -1188,6 +1188,7 @@ static int musb_gadget_enable(struct usb_ep *ep,
} else
musb_ep->dma = NULL;
+ musb_ep->end_point.desc = desc;
musb_ep->desc = desc;
musb_ep->busy = 0;
musb_ep->wedged = 0;
@@ -1245,9 +1246,7 @@ static int musb_gadget_disable(struct usb_ep *ep)
}
musb_ep->desc = NULL;
-#ifndef __UBOOT__
musb_ep->end_point.desc = NULL;
-#endif
/* abort all pending DMA and requests */
nuke(musb_ep, -ESHUTDOWN);
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] drivers: musb_gadget: Save endpoint desc to usb_ep->desc
2021-11-16 0:30 [PATCH] drivers: musb_gadget: Save endpoint desc to usb_ep->desc qianfanguijin
@ 2021-11-16 0:43 ` Sean Anderson
2022-01-18 17:39 ` Tom Rini
1 sibling, 0 replies; 5+ messages in thread
From: Sean Anderson @ 2021-11-16 0:43 UTC (permalink / raw)
To: qianfanguijin, u-boot; +Cc: lukma, qianfan Zhao
On 11/15/21 7:30 PM, qianfanguijin@qq.com wrote:
> From: qianfan Zhao <qianfanguijin@163.com>
>
> Fix fastboot flash bug.
>
> If the downloading file size is equal to the partition size, "fastboot
> flash" can't work, at least in sunxi platform, because used an
> uninitalized point: ep->desc.
>
> This patch also fixed 'data abort' bug in am335x platform.
>
> Reproduce: fastboot flash loader1 spl/sunxi-spl.bin.
>
> Signed-off-by: qianfan Zhao <qianfanguijin@163.com>
> ---
> drivers/usb/musb-new/musb_gadget.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/usb/musb-new/musb_gadget.c b/drivers/usb/musb-new/musb_gadget.c
> index 1fef00b292..7cca92b970 100644
> --- a/drivers/usb/musb-new/musb_gadget.c
> +++ b/drivers/usb/musb-new/musb_gadget.c
> @@ -1188,6 +1188,7 @@ static int musb_gadget_enable(struct usb_ep *ep,
> } else
> musb_ep->dma = NULL;
>
> + musb_ep->end_point.desc = desc;
> musb_ep->desc = desc;
> musb_ep->busy = 0;
> musb_ep->wedged = 0;
> @@ -1245,9 +1246,7 @@ static int musb_gadget_disable(struct usb_ep *ep)
> }
>
> musb_ep->desc = NULL;
> -#ifndef __UBOOT__
> musb_ep->end_point.desc = NULL;
> -#endif
>
> /* abort all pending DMA and requests */
> nuke(musb_ep, -ESHUTDOWN);
>
Reviewed-by: Sean Anderson <seanga2@gmail.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drivers: musb_gadget: Save endpoint desc to usb_ep->desc
2021-11-16 0:30 [PATCH] drivers: musb_gadget: Save endpoint desc to usb_ep->desc qianfanguijin
2021-11-16 0:43 ` Sean Anderson
@ 2022-01-18 17:39 ` Tom Rini
1 sibling, 0 replies; 5+ messages in thread
From: Tom Rini @ 2022-01-18 17:39 UTC (permalink / raw)
To: qianfanguijin; +Cc: u-boot, seanga2, lukma, qianfan Zhao
[-- Attachment #1: Type: text/plain, Size: 611 bytes --]
On Tue, Nov 16, 2021 at 08:30:12AM +0800, qianfanguijin@qq.com wrote:
> From: qianfan Zhao <qianfanguijin@163.com>
>
> Fix fastboot flash bug.
>
> If the downloading file size is equal to the partition size, "fastboot
> flash" can't work, at least in sunxi platform, because used an
> uninitalized point: ep->desc.
>
> This patch also fixed 'data abort' bug in am335x platform.
>
> Reproduce: fastboot flash loader1 spl/sunxi-spl.bin.
>
> Signed-off-by: qianfan Zhao <qianfanguijin@163.com>
> Reviewed-by: Sean Anderson <seanga2@gmail.com>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] drivers: musb_gadget: Save endpoint desc to usb_ep->desc
@ 2021-11-08 3:04 qianfanguijin
2021-11-15 13:14 ` Sean Anderson
0 siblings, 1 reply; 5+ messages in thread
From: qianfanguijin @ 2021-11-08 3:04 UTC (permalink / raw)
To: u-boot; +Cc: seanga2, lukma, marex, qianfan Zhao
From: qianfan Zhao <qianfanguijin@163.com>
Fix fastboot flash bug.
If the downloading file size is equal to the partition size, "fastboot
flash" can't work, at least in sunxi platform, because used an
uninitalized point: ep->desc.
Reproduce: fastboot flash loader1 spl/sunxi-spl.bin.
Signed-off-by: qianfan Zhao <qianfanguijin@163.com>
---
drivers/usb/musb-new/musb_gadget.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/musb-new/musb_gadget.c b/drivers/usb/musb-new/musb_gadget.c
index 5b149dac6d..12d9911ecd 100644
--- a/drivers/usb/musb-new/musb_gadget.c
+++ b/drivers/usb/musb-new/musb_gadget.c
@@ -1188,6 +1188,7 @@ static int musb_gadget_enable(struct usb_ep *ep,
} else
musb_ep->dma = NULL;
+ musb_ep->end_point.desc = desc;
musb_ep->desc = desc;
musb_ep->busy = 0;
musb_ep->wedged = 0;
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] drivers: musb_gadget: Save endpoint desc to usb_ep->desc
2021-11-08 3:04 qianfanguijin
@ 2021-11-15 13:14 ` Sean Anderson
0 siblings, 0 replies; 5+ messages in thread
From: Sean Anderson @ 2021-11-15 13:14 UTC (permalink / raw)
To: qianfanguijin, u-boot; +Cc: lukma, marex, qianfan Zhao
On 11/7/21 10:04 PM, qianfanguijin@qq.com wrote:
> From: qianfan Zhao <qianfanguijin@163.com>
>
> Fix fastboot flash bug.
>
> If the downloading file size is equal to the partition size, "fastboot
> flash" can't work, at least in sunxi platform, because used an
> uninitalized point: ep->desc.
>
> Reproduce: fastboot flash loader1 spl/sunxi-spl.bin.
>
> Signed-off-by: qianfan Zhao <qianfanguijin@163.com>
> ---
> drivers/usb/musb-new/musb_gadget.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/musb-new/musb_gadget.c b/drivers/usb/musb-new/musb_gadget.c
> index 5b149dac6d..12d9911ecd 100644
> --- a/drivers/usb/musb-new/musb_gadget.c
> +++ b/drivers/usb/musb-new/musb_gadget.c
> @@ -1188,6 +1188,7 @@ static int musb_gadget_enable(struct usb_ep *ep,
> } else
> musb_ep->dma = NULL;
>
> + musb_ep->end_point.desc = desc;
> musb_ep->desc = desc;
> musb_ep->busy = 0;
> musb_ep->wedged = 0;
>
This also needs to be set to NULL in disabled.
--Sean
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-01-18 17:39 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-16 0:30 [PATCH] drivers: musb_gadget: Save endpoint desc to usb_ep->desc qianfanguijin
2021-11-16 0:43 ` Sean Anderson
2022-01-18 17:39 ` Tom Rini
-- strict thread matches above, loose matches on Subject: below --
2021-11-08 3:04 qianfanguijin
2021-11-15 13:14 ` Sean Anderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox