Re: [PATCH 04/10] ram: thead: Add initial DDR controller support for TH1520

[Leo Liang <ycliang@andestech.com>]

On Sat, Apr 26, 2025 at 05:09:16PM +0000, Yao Zi wrote:
> [EXTERNAL MAIL]
> 
> On Sat, Apr 26, 2025 at 04:56:58PM +0000, Yao Zi wrote:
> > This patch cleans the vendor code of DDR initialization up, converts the
> > driver to fit in DM framework and use a firmware[1] packaged by binman to
> > ship PHY configuration.
> >
> > Currently the driver is only capable of initializing the controller to
> > work with dual-rank 3733MHz LPDDR4, which is shipped by 16GiB variants
> > of LicheePi 4A boards and I could test with. Support for other
> > configurations could be easily added later.
> 
> I wrongly repeated this patch twice when sending the series, sorry for
> the noise.
> 
> > Link: https://github.com/ziyao233/th1520-firmware # [1]
> > Signed-off-by: Yao Zi <ziyao@disroot.org>
> > ---
> >  drivers/ram/Kconfig            |   1 +
> >  drivers/ram/Makefile           |   4 +
> >  drivers/ram/thead/Kconfig      |   5 +
> >  drivers/ram/thead/Makefile     |   1 +
> >  drivers/ram/thead/th1520_ddr.c | 781 +++++++++++++++++++++++++++++++++
> >  5 files changed, 792 insertions(+)
> >  create mode 100644 drivers/ram/thead/Kconfig
> >  create mode 100644 drivers/ram/thead/Makefile
> >  create mode 100644 drivers/ram/thead/th1520_ddr.c
> 
> And here is missing an SPDX license header and a copyright notice. I'll
> add them in v2.

Hi Yao,

You could add my reviewed-by tag when sending v2 patch.

Best regards,
Leo

> 
> Thanks,
> Yao Zi