From: e <e@freeshell.de>
To: Leo Liang <ycliang@andestech.com>
Cc: Yao Zi <ziyao@disroot.org>, Rick Chen <rick@andestech.com>,
Tom Rini <trini@konsulko.com>, Wei Fu <wefu@redhat.com>,
Yixun Lan <dlan@gentoo.org>,
Maksim Kiselev <bigunclemax@gmail.com>,
Jaehoon Chung <jh80.chung@samsung.com>,
Simon Glass <sjg@chromium.org>,
Heinrich Schuchardt <xypron.glpk@gmx.de>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Neha Malcom Francis <n-francis@ti.com>,
Jayesh Choudhary <j-choudhary@ti.com>,
Wadim Egorov <w.egorov@phytec.de>,
Vaishnav Achath <vaishnav.a@ti.com>, Andrew Davis <afd@ti.com>,
Chia-Wei Wang <chiawei_wang@aspeedtech.com>,
u-boot@lists.denx.de, Han Gao <rabenda.cn@gmail.com>,
Han Gao <gaohan@iscas.ac.cn>
Subject: Re: [PATCH 02/10] riscv: dts: th1520: Add clock-frequency for UART0
Date: Mon, 12 May 2025 07:53:01 -0400 [thread overview]
Message-ID: <c37ce687674984589e56d2edb0184e48@freeshell.de> (raw)
In-Reply-To: <aCHF-zLg41oOXdTl@swlinux02>
On 2025-05-12 05:57, Leo Liang wrote:
> On Sat, Apr 26, 2025 at 04:56:56PM +0000, Yao Zi wrote:
>> [EXTERNAL MAIL]
>>
>> The BROM of TH1520 always initializes its clock and configure the
>> baudrate to 115200. Add a clock-frequency property to provide such
>> information without introducing CCF to SPL.
>>
>> Signed-off-by: Yao Zi <ziyao@disroot.org>
>> ---
>> arch/riscv/dts/th1520.dtsi | 1 +
>> 1 file changed, 1 insertion(+)
>
> Reviewed-by: Leo Yu-Chi Liang <ycliang@andestech.com>
NAK from me. Quoting Emil "The uart0 node already has a reference to the
uart0_core clock, so it shouldn't
need this property." If SPL does not support the clock framework to do
this parent node lookup properly from device-tree then we should not be
adjusting the device-tree in this way; use instead the codepath in
serial driver that checks a compile-time define.
See for example:
https://lore.kernel.org/u-boot/20250503115301.972550-1-e@freeshell.de/
- E
next prev parent reply other threads:[~2025-05-12 11:53 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-26 16:56 [PATCH 00/10] Initial SPL support for T-Head TH1520 SoC Yao Zi
2025-04-26 16:56 ` [PATCH 01/10] riscv: lib: Split out support for T-Head cache management operations Yao Zi
2025-05-12 9:56 ` Leo Liang
2025-04-26 16:56 ` [PATCH 02/10] riscv: dts: th1520: Add clock-frequency for UART0 Yao Zi
2025-05-12 9:57 ` Leo Liang
2025-05-12 11:53 ` e [this message]
2025-05-13 4:06 ` Yao Zi
2025-04-26 16:56 ` [PATCH 03/10] riscv: cpu: Add TH1520 CPU support Yao Zi
2025-05-12 9:59 ` Leo Liang
2025-04-26 16:56 ` [PATCH 04/10] ram: thead: Add initial DDR controller support for TH1520 Yao Zi
2025-04-26 17:09 ` Yao Zi
2025-05-12 17:55 ` Leo Liang
2025-05-12 17:47 ` Leo Liang
2025-05-24 19:16 ` Drew Fustini
2025-04-26 17:00 ` Yao Zi
2025-04-26 17:00 ` [PATCH 05/10] riscv: dts: th1520: Preserve necessary devices for SPL Yao Zi
2025-05-12 18:02 ` Leo Liang
2025-04-26 17:00 ` [PATCH 06/10] riscv: dts: lichee-module-4a: Preserve memory node " Yao Zi
2025-05-12 18:03 ` Leo Liang
2025-04-26 17:00 ` [PATCH 07/10] riscv: dts: th1520: Add DRAM controller Yao Zi
2025-05-12 18:04 ` Leo Liang
2025-04-26 17:00 ` [PATCH 08/10] riscv: dts: th1520: Add binman configuration Yao Zi
2025-05-12 18:04 ` Leo Liang
2025-04-26 17:03 ` [PATCH 09/10] board: thead: licheepi4a: Enable SPL support Yao Zi
2025-05-12 18:05 ` Leo Liang
2025-04-26 17:03 ` [PATCH 10/10] doc: thead: lpi4a: Update documentation Yao Zi
2025-05-12 18:06 ` Leo Liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c37ce687674984589e56d2edb0184e48@freeshell.de \
--to=e@freeshell.de \
--cc=afd@ti.com \
--cc=bigunclemax@gmail.com \
--cc=chiawei_wang@aspeedtech.com \
--cc=dlan@gentoo.org \
--cc=gaohan@iscas.ac.cn \
--cc=ilias.apalodimas@linaro.org \
--cc=j-choudhary@ti.com \
--cc=jh80.chung@samsung.com \
--cc=n-francis@ti.com \
--cc=rabenda.cn@gmail.com \
--cc=rick@andestech.com \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=vaishnav.a@ti.com \
--cc=w.egorov@phytec.de \
--cc=wefu@redhat.com \
--cc=xypron.glpk@gmx.de \
--cc=ycliang@andestech.com \
--cc=ziyao@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox