[PATCH] cmd: env: select: Add output for available evironment targets

[PATCH] cmd: env: select: Add output for available evironment targets

[Christoph Niedermaier]

If "env select" is called without a target parameter the result is
"Select Environment on <NULL>: driver not found". Improve the output
by showing a list of available evironment targets, where the active
target is marked with an asterisk.

Signed-off-by: Christoph Niedermaier <cniedermaier@dh-electronics.com>

Cc: Marek Vasut <marex@denx.de>
Cc: Patrick Delaunay <patrick.delaunay@foss.st.com>
Cc: Joe Hershberger <joe.hershberger@ni.com>
Cc: Tom Rini <trini@konsulko.com>
---
 env/env.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/env/env.c b/env/env.c
index bcc189e14db..999c2031c40 100644
--- a/env/env.c
+++ b/env/env.c
@@ -355,6 +355,18 @@ int env_select(const char *name)
 	int prio;
 	bool found = false;
 
+	if (!name) {
+		printf("Available Environment targets:\n");
+		for (prio = 0; (drv = env_driver_lookup(ENVOP_INIT, prio)); prio++) {
+			if (gd->env_load_prio == prio)
+				printf("* ");
+			else
+				printf("  ");
+			printf("%s\n", drv->name);
+		}
+		return 0;
+	}
+
 	printf("Select Environment on %s: ", name);
 
 	/* search ENV driver by name */
-- 
2.30.2

Re: [PATCH] cmd: env: select: Add output for available evironment targets

[Marek Vasut]

On 3/20/25 11:32 AM, Christoph Niedermaier wrote:
> If "env select" is called without a target parameter the result is
> "Select Environment on <NULL>: driver not found".

Why is this not the correct output ?

> Improve the output
> by showing a list of available evironment targets, where the active
> target is marked with an asterisk.

If the goal is to add support for listing available env options for 'env 
select' , then better modify cmd/nvedit.c do_env_select() and implement 
some 'env select -l' .

RE: [PATCH] cmd: env: select: Add output for available evironment targets

[Christoph Niedermaier]

From: Marek Vasut <marex@denx.de>
Sent: Thursday, March 20, 2025 12:56 PM
> On 3/20/25 11:32 AM, Christoph Niedermaier wrote:
>> If "env select" is called without a target parameter the result is
>> "Select Environment on <NULL>: driver not found".
> 
> Why is this not the correct output ?

I think it would be better to print an usage message here.

>> Improve the output
>> by showing a list of available evironment targets, where the active
>> target is marked with an asterisk.
> 
> If the goal is to add support for listing available env options for 'env
> select' , then better modify cmd/nvedit.c do_env_select() and implement
> some 'env select -l' .

I could do this in v2.


Regards
Christoph