[U-Boot] [PATCH v4 1/4] armv8: ls1028a: The ls1028a platform supports the I2C driver model

[U-Boot] [PATCH v4 1/4] armv8: ls1028a: The ls1028a platform supports the I2C driver model

[Chuanhua Han]

DM_I2C_COMPAT is a compatibility layer that allows using the non-DM
I2C API when DM_I2C is used.When DM_I2C_COMPAT is not enabled for
compilation, a compilation error will be generated. This patch
solves the problem that the i2c-related api of the ls1028a platform
does not support dm.

Signed-off-by: Chuanhua Han <chuanhua.han@nxp.com>
---
depends on:
	- https://patchwork.ozlabs.org/project/uboot/list/?series=113364
	- https://patchwork.ozlabs.org/project/uboot/list/?series=110856
	- https://patchwork.ozlabs.org/project/uboot/list/?series=109677

Changes in v4:
	- No change.
Changes in v3:
	- No change.
Changes in v2:
	- No change.

 arch/arm/cpu/armv8/fsl-layerscape/Kconfig |    8 --------
 board/freescale/ls1028a/ls1028a.c         |    8 ++++++++
 include/configs/ls1028a_common.h          |    3 ---
 include/configs/ls1028ardb.h              |    1 -
 4 files changed, 8 insertions(+), 12 deletions(-)

diff --git a/arch/arm/cpu/armv8/fsl-layerscape/Kconfig b/arch/arm/cpu/armv8/fsl-layerscape/Kconfig
index ffda02a..d6ef7fc 100644
--- a/arch/arm/cpu/armv8/fsl-layerscape/Kconfig
+++ b/arch/arm/cpu/armv8/fsl-layerscape/Kconfig
@@ -40,14 +40,6 @@ config ARCH_LS1028A
 	select ARCH_EARLY_INIT_R
 	select BOARD_EARLY_INIT_F
 	select SYS_I2C_MXC
-	select SYS_I2C_MXC_I2C1
-	select SYS_I2C_MXC_I2C2
-	select SYS_I2C_MXC_I2C3
-	select SYS_I2C_MXC_I2C4
-	select SYS_I2C_MXC_I2C5
-	select SYS_I2C_MXC_I2C6
-	select SYS_I2C_MXC_I2C7
-	select SYS_I2C_MXC_I2C8
 	select SYS_FSL_ERRATUM_A008997
 	select SYS_FSL_ERRATUM_A009007
 	select SYS_FSL_ERRATUM_A008514 if !TFABOOT
diff --git a/board/freescale/ls1028a/ls1028a.c b/board/freescale/ls1028a/ls1028a.c
index e5de4eb..49a9292 100644
--- a/board/freescale/ls1028a/ls1028a.c
+++ b/board/freescale/ls1028a/ls1028a.c
@@ -73,7 +73,15 @@ int board_init(void)
 #if defined(CONFIG_TARGET_LS1028ARDB)
 	u8 val = I2C_MUX_CH_DEFAULT;
 
+#ifndef CONFIG_DM_I2C
 	i2c_write(I2C_MUX_PCA_ADDR_PRI, 0x0b, 1, &val, 1);
+#else
+	struct udevice *dev;
+
+	if (!i2c_get_chip_for_busnum(0, I2C_MUX_PCA_ADDR_PRI, 1, &dev))
+		dm_i2c_write(dev, 0x0b, &val, 1);
+#endif
+
 #endif
 	return 0;
 }
diff --git a/include/configs/ls1028a_common.h b/include/configs/ls1028a_common.h
index d3d787f..0fa5095 100644
--- a/include/configs/ls1028a_common.h
+++ b/include/configs/ls1028a_common.h
@@ -41,9 +41,6 @@
 /* Size of malloc() pool */
 #define CONFIG_SYS_MALLOC_LEN		(CONFIG_ENV_SIZE + 2048 * 1024)
 
-/* I2C */
-#define CONFIG_SYS_I2C
-
 /* Serial Port */
 #define CONFIG_CONS_INDEX       1
 #define CONFIG_SYS_NS16550_SERIAL
diff --git a/include/configs/ls1028ardb.h b/include/configs/ls1028ardb.h
index 10791be..b77c36d 100644
--- a/include/configs/ls1028ardb.h
+++ b/include/configs/ls1028ardb.h
@@ -22,7 +22,6 @@
 #define CONFIG_SYS_MONITOR_BASE CONFIG_SYS_TEXT_BASE
 
 #define CONFIG_QIXIS_I2C_ACCESS
-#define CONFIG_SYS_I2C_EARLY_INIT
 
 /*
  * QIXIS Definitions
-- 
1.7.1

[U-Boot] [PATCH v4 2/4] gpio: do not include <asm/arch/gpio.h> on ARCH_LS1028A

[Chuanhua Han]

As no gpio.h is defined for this architecture, to avoid
compilation failure, do not include <asm/arch/gpio.h> for
arch ls1028a.

Signed-off-by: Chuanhua Han <chuanhua.han@nxp.com>
---
depends on: 
	- https://patchwork.ozlabs.org/project/uboot/list/?series=113364
	- https://patchwork.ozlabs.org/project/uboot/list/?series=110856
	- https://patchwork.ozlabs.org/project/uboot/list/?series=109677

Changes in v4:
	- No change.
Changes in v3:
	- No change.
Changes in v2: 
	- No change.

 arch/arm/include/asm/gpio.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/include/asm/gpio.h b/arch/arm/include/asm/gpio.h
index f78b976..b5adf5c 100644
--- a/arch/arm/include/asm/gpio.h
+++ b/arch/arm/include/asm/gpio.h
@@ -1,7 +1,7 @@
 #if !defined(CONFIG_ARCH_UNIPHIER) && !defined(CONFIG_ARCH_STI) && \
 	!defined(CONFIG_ARCH_K3) && !defined(CONFIG_ARCH_BCM6858) && \
 	!defined(CONFIG_ARCH_BCM63158) && !defined(CONFIG_ARCH_ROCKCHIP) && \
-	!defined(CONFIG_ARCH_LX2160A)
+	!defined(CONFIG_ARCH_LX2160A) && !defined(CONFIG_ARCH_LS1028A)
 #include <asm/arch/gpio.h>
 #endif
 #include <asm-generic/gpio.h>
-- 
1.7.1

[U-Boot] [PATCH v4 2/4] gpio: do not include <asm/arch/gpio.h> on ARCH_LS1028A

[Alex Marginean]

On 7/10/2019 4:16 PM, Chuanhua Han wrote:
> As no gpio.h is defined for this architecture, to avoid
> compilation failure, do not include <asm/arch/gpio.h> for
> arch ls1028a.
> 
> Signed-off-by: Chuanhua Han <chuanhua.han@nxp.com>
> ---
> depends on:
> 	- https://patchwork.ozlabs.org/project/uboot/list/?series=113364
> 	- https://patchwork.ozlabs.org/project/uboot/list/?series=110856
> 	- https://patchwork.ozlabs.org/project/uboot/list/?series=109677
> 
> Changes in v4:
> 	- No change.
> Changes in v3:
> 	- No change.
> Changes in v2:
> 	- No change.
> 
>   arch/arm/include/asm/gpio.h |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
> 

Reviewed-by: Alex Marginean <alexm.osslist@gmail.com>

[U-Boot] [PATCH v4 2/4] gpio: do not include <asm/arch/gpio.h> on ARCH_LS1028A

[Prabhakar Kushwaha]

> -----Original Message-----
> From: Alex Marginean <alexm.osslist@gmail.com>
> Sent: Friday, July 12, 2019 5:18 PM
> To: Chuanhua Han <chuanhua.han@nxp.com>; albert.u.boot at aribaud.net;
> Sudhanshu Gupta <sudhanshu.gupta@nxp.com>; Harninder Rai
> <harninder.rai@nxp.com>; Rajesh Bhagat <rajesh.bhagat@nxp.com>; Andy
> Tang <andy.tang@nxp.com>; Prabhakar Kushwaha
> <prabhakar.kushwaha@nxp.com>
> Cc: u-boot at lists.denx.de
> Subject: Re: [U-Boot] [PATCH v4 2/4] gpio: do not include <asm/arch/gpio.h>
> on ARCH_LS1028A
> 
> On 7/10/2019 4:16 PM, Chuanhua Han wrote:
> > As no gpio.h is defined for this architecture, to avoid compilation
> > failure, do not include <asm/arch/gpio.h> for arch ls1028a.
> >
> > Signed-off-by: Chuanhua Han <chuanhua.han@nxp.com>
> > ---

This patch has been applied to fsl-qoriq master, awaiting upstream.

--pk

[U-Boot] [PATCH v4 3/4] configs: ls1028a: enable DM support for pcf2127 rtc

[Chuanhua Han]

Enable related configs to support pcf2127 rtc DM feature for
ls1028ardb board.

Signed-off-by: Chuanhua Han <chuanhua.han@nxp.com>
---
depends on: 
	- https://patchwork.ozlabs.org/project/uboot/list/?series=113364
	- https://patchwork.ozlabs.org/project/uboot/list/?series=110856
	- https://patchwork.ozlabs.org/project/uboot/list/?series=109677    

Changes in v4:
	- Add configuration options for i2c dm to set default bus number Settings.
Changes in v3:
	- No change.
Changes in v2: 
	-  Enable secure boot defconfig to support pcf2127 rtc DM
feature for ls1028ardb board.

 configs/ls1028ardb_tfa_SECURE_BOOT_defconfig |    11 ++++++++++-
 configs/ls1028ardb_tfa_defconfig             |    11 ++++++++++-
 2 files changed, 20 insertions(+), 2 deletions(-)

diff --git a/configs/ls1028ardb_tfa_SECURE_BOOT_defconfig b/configs/ls1028ardb_tfa_SECURE_BOOT_defconfig
index 3432f90..c101a33 100644
--- a/configs/ls1028ardb_tfa_SECURE_BOOT_defconfig
+++ b/configs/ls1028ardb_tfa_SECURE_BOOT_defconfig
@@ -1,5 +1,6 @@
 CONFIG_ARM=y
 CONFIG_TARGET_LS1028ARDB=y
+CONFIG_SYS_MALLOC_F_LEN=0x6000
 CONFIG_SECURE_BOOT=y
 CONFIG_SYS_FSL_SDHC_CLK_DIV=1
 CONFIG_TFABOOT=y
@@ -8,7 +9,6 @@ CONFIG_ARMV8_SEC_FIRMWARE_SUPPORT=y
 CONFIG_SEC_FIRMWARE_ARMV8_PSCI=y
 CONFIG_AHCI=y
 CONFIG_DISTRO_DEFAULTS=y
-# CONFIG_SYS_MALLOC_F is not set
 CONFIG_FIT_VERBOSE=y
 CONFIG_OF_BOARD_SETUP=y
 CONFIG_OF_STDOUT_VIA_ALIAS=y
@@ -60,3 +60,12 @@ CONFIG_WDT=y
 CONFIG_WDT_SP805=y
 CONFIG_RSA=y
 CONFIG_EFI_LOADER_BOUNCE_BUFFER=y
+CONFIG_DM_I2C=y
+CONFIG_I2C_SET_DEFAULT_BUS_NUM=y
+CONFIG_I2C_DEFAULT_BUS_NUMBER=0
+CONFIG_DM_RTC=y
+CONFIG_DM_GPIO=y
+CONFIG_CMD_DATE=y
+CONFIG_RTC_PCF2127=y
+CONFIG_I2C_MUX=y
+CONFIG_I2C_MUX_PCA954x=y
diff --git a/configs/ls1028ardb_tfa_defconfig b/configs/ls1028ardb_tfa_defconfig
index c65e37d..a2fe8d6 100644
--- a/configs/ls1028ardb_tfa_defconfig
+++ b/configs/ls1028ardb_tfa_defconfig
@@ -1,5 +1,6 @@
 CONFIG_ARM=y
 CONFIG_TARGET_LS1028ARDB=y
+CONFIG_SYS_MALLOC_F_LEN=0x6000
 CONFIG_SYS_FSL_SDHC_CLK_DIV=1
 CONFIG_TFABOOT=y
 CONFIG_NR_DRAM_BANKS=2
@@ -7,7 +8,6 @@ CONFIG_ARMV8_SEC_FIRMWARE_SUPPORT=y
 CONFIG_SEC_FIRMWARE_ARMV8_PSCI=y
 CONFIG_AHCI=y
 CONFIG_DISTRO_DEFAULTS=y
-# CONFIG_SYS_MALLOC_F is not set
 CONFIG_FIT_VERBOSE=y
 CONFIG_OF_BOARD_SETUP=y
 CONFIG_OF_STDOUT_VIA_ALIAS=y
@@ -63,3 +63,12 @@ CONFIG_USB_XHCI_DWC3=y
 CONFIG_WDT=y
 CONFIG_WDT_SP805=y
 CONFIG_EFI_LOADER_BOUNCE_BUFFER=y
+CONFIG_DM_I2C=y
+CONFIG_I2C_SET_DEFAULT_BUS_NUM=y
+CONFIG_I2C_DEFAULT_BUS_NUMBER=0
+CONFIG_DM_RTC=y
+CONFIG_DM_GPIO=y
+CONFIG_CMD_DATE=y
+CONFIG_RTC_PCF2127=y
+CONFIG_I2C_MUX=y
+CONFIG_I2C_MUX_PCA954x=y
-- 
1.7.1

[U-Boot] [PATCH v4 3/4] configs: ls1028a: enable DM support for pcf2127 rtc

[Alex Marginean]

On 7/10/2019 4:16 PM, Chuanhua Han wrote:
> Enable related configs to support pcf2127 rtc DM feature for
> ls1028ardb board.
> 
> Signed-off-by: Chuanhua Han <chuanhua.han@nxp.com>
> ---
> depends on:
> 	- https://patchwork.ozlabs.org/project/uboot/list/?series=113364
> 	- https://patchwork.ozlabs.org/project/uboot/list/?series=110856
> 	- https://patchwork.ozlabs.org/project/uboot/list/?series=109677
> 
> Changes in v4:
> 	- Add configuration options for i2c dm to set default bus number Settings.
> Changes in v3:
> 	- No change.
> Changes in v2:
> 	-  Enable secure boot defconfig to support pcf2127 rtc DM
> feature for ls1028ardb board.
> 
>   configs/ls1028ardb_tfa_SECURE_BOOT_defconfig |    11 ++++++++++-
>   configs/ls1028ardb_tfa_defconfig             |    11 ++++++++++-
>   2 files changed, 20 insertions(+), 2 deletions(-)
> 

Reviewed-by: Alex Marginean <alexm.osslist@gmail.com>

[U-Boot] [PATCH v4 4/4] armv8: dts: ls1028ardb: Add slave nodes under the i2c0 controller

[Chuanhua Han]

This patch adds some slave nodes to support the i2c dm on the device
side under the i2c0 controller.

Signed-off-by: Chuanhua Han <chuanhua.han@nxp.com>
---
depends on: 
	- https://patchwork.ozlabs.org/project/uboot/list/?series=113364
	- https://patchwork.ozlabs.org/project/uboot/list/?series=110856
	- https://patchwork.ozlabs.org/project/uboot/list/?series=109677

Changes in v4:
	- No change.
Changes in v3:
	- Delete unnecessary i2c slave nodes.
Changes in v2: 
	- Delete unnecessary aliases about i2c.

 arch/arm/dts/fsl-ls1028a-rdb.dts |   20 ++++++++++++++++++++
 1 files changed, 20 insertions(+), 0 deletions(-)

diff --git a/arch/arm/dts/fsl-ls1028a-rdb.dts b/arch/arm/dts/fsl-ls1028a-rdb.dts
index 932cfa2..541c9bf 100644
--- a/arch/arm/dts/fsl-ls1028a-rdb.dts
+++ b/arch/arm/dts/fsl-ls1028a-rdb.dts
@@ -37,6 +37,26 @@
 
 &i2c0 {
 	status = "okay";
+	u-boot,dm-pre-reloc;
+
+	 i2c-mux at 77 {
+
+		compatible = "nxp,pca9547";
+		reg = <0x77>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		i2c at 3 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <0x3>;
+
+			rtc at 51 {
+				compatible = "pcf2127-rtc";
+				reg = <0x51>;
+			};
+		};
+	};
 };
 
 &i2c1 {
-- 
1.7.1

[U-Boot] [PATCH v4 4/4] armv8: dts: ls1028ardb: Add slave nodes under the i2c0 controller

[Alex Marginean]

On 7/10/2019 4:16 PM, Chuanhua Han wrote:
> This patch adds some slave nodes to support the i2c dm on the device
> side under the i2c0 controller.
> 
> Signed-off-by: Chuanhua Han <chuanhua.han@nxp.com>
> ---
> depends on:
> 	- https://patchwork.ozlabs.org/project/uboot/list/?series=113364
> 	- https://patchwork.ozlabs.org/project/uboot/list/?series=110856
> 	- https://patchwork.ozlabs.org/project/uboot/list/?series=109677
> 
> Changes in v4:
> 	- No change.
> Changes in v3:
> 	- Delete unnecessary i2c slave nodes.
> Changes in v2:
> 	- Delete unnecessary aliases about i2c.
> 
>   arch/arm/dts/fsl-ls1028a-rdb.dts |   20 ++++++++++++++++++++
>   1 files changed, 20 insertions(+), 0 deletions(-)
> 
Reviewed-by: Alex Marginean <alexm.osslist@gmail.com>

Thank you!
Alex

[U-Boot] [PATCH v4 4/4] armv8: dts: ls1028ardb: Add slave nodes under the i2c0 controller

[Prabhakar Kushwaha]

> -----Original Message-----
> From: Alex Marginean <alexm.osslist@gmail.com>
> Sent: Friday, July 12, 2019 5:20 PM
> To: Chuanhua Han <chuanhua.han@nxp.com>; albert.u.boot at aribaud.net;
> Sudhanshu Gupta <sudhanshu.gupta@nxp.com>; Harninder Rai
> <harninder.rai@nxp.com>; Rajesh Bhagat <rajesh.bhagat@nxp.com>; Andy
> Tang <andy.tang@nxp.com>; Prabhakar Kushwaha
> <prabhakar.kushwaha@nxp.com>
> Cc: u-boot at lists.denx.de
> Subject: Re: [U-Boot] [PATCH v4 4/4] armv8: dts: ls1028ardb: Add slave nodes
> under the i2c0 controller
> 
> On 7/10/2019 4:16 PM, Chuanhua Han wrote:
> > This patch adds some slave nodes to support the i2c dm on the device
> > side under the i2c0 controller.
> >
> > Signed-off-by: Chuanhua Han <chuanhua.han@nxp.com>
> > ---
> > depends on:
> > 	-
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatch
> work.ozlabs.org%2Fproject%2Fuboot%2Flist%2F%3Fseries%3D113364&amp;
> data=02%7C01%7Cprabhakar.kushwaha%40nxp.com%7Ca2d0631084b247e95
> eb108d706bf1061%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636
> 985290003973466&amp;sdata=YY%2BM1Dn8uiiLbEg2UST0qZyNrJMy4PUPeU
> pBBOQvSxg%3D&amp;reserved=0
> > 	-
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatch
> work.ozlabs.org%2Fproject%2Fuboot%2Flist%2F%3Fseries%3D110856&amp;
> data=02%7C01%7Cprabhakar.kushwaha%40nxp.com%7Ca2d0631084b247e95
> eb108d706bf1061%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636
> 985290003973466&amp;sdata=E3BJoHt8hAeeiGDb22wj7wTPQ9anaENhhoW8
> FjB9hGk%3D&amp;reserved=0
> > 	-
> >
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatc
> >
> hwork.ozlabs.org%2Fproject%2Fuboot%2Flist%2F%3Fseries%3D109677&amp
> ;dat
> >
> a=02%7C01%7Cprabhakar.kushwaha%40nxp.com%7Ca2d0631084b247e95eb
> 108d706b
> >
> f1061%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6369852900039
> 73466&
> >
> amp;sdata=CjygPbOON9WEKCrsIyG1TCclJuiCsEbBZPrDvuz9c0o%3D&amp;res
> erved=
> > 0
> >
> > Changes in v4:
> > 	- No change.
> > Changes in v3:
> > 	- Delete unnecessary i2c slave nodes.
> > Changes in v2:
> > 	- Delete unnecessary aliases about i2c.
> >
> >   arch/arm/dts/fsl-ls1028a-rdb.dts |   20 ++++++++++++++++++++
> >   1 files changed, 20 insertions(+), 0 deletions(-)
> >
> Reviewed-by: Alex Marginean <alexm.osslist@gmail.com>
> 
> Thank you!
> Alex


This patch has been applied to fsl-qoriq master, awaiting upstream.

--pk

[U-Boot] [PATCH v4 4/4] armv8: dts: ls1028ardb: Add slave nodes under the i2c0 controller

[Prabhakar Kushwaha]

> -----Original Message-----
> From: Chuanhua Han <chuanhua.han@nxp.com>
> Sent: Wednesday, July 10, 2019 6:47 PM
> To: albert.u.boot at aribaud.net; Sudhanshu Gupta
> <sudhanshu.gupta@nxp.com>; Harninder Rai <harninder.rai@nxp.com>;
> Rajesh Bhagat <rajesh.bhagat@nxp.com>; Andy Tang
> <andy.tang@nxp.com>; Prabhakar Kushwaha
> <prabhakar.kushwaha@nxp.com>
> Cc: u-boot at lists.denx.de; Chuanhua Han <chuanhua.han@nxp.com>
> Subject: [PATCH v4 4/4] armv8: dts: ls1028ardb: Add slave nodes under the
> i2c0 controller
> 
> This patch adds some slave nodes to support the i2c dm on the device side
> under the i2c0 controller.
> 
> Signed-off-by: Chuanhua Han <chuanhua.han@nxp.com>
> ---

This patch has been applied to fsl-qoriq master, awaiting upstream.

--pk

[U-Boot] [PATCH v4 1/4] armv8: ls1028a: The ls1028a platform supports the I2C driver model

[Alex Marginean]

On 7/10/2019 4:16 PM, Chuanhua Han wrote:
> DM_I2C_COMPAT is a compatibility layer that allows using the non-DM
> I2C API when DM_I2C is used.When DM_I2C_COMPAT is not enabled for
> compilation, a compilation error will be generated. This patch
> solves the problem that the i2c-related api of the ls1028a platform
> does not support dm.

I wouldn't mention DM_I2C_COMPAT at all in the commit message, it's not
currently enabled and after this patch set it's not needed either.
You could just mention that the patch is updating ls1028a board init
code to support DM_I2C.

> 
> Signed-off-by: Chuanhua Han <chuanhua.han@nxp.com>
> ---
> depends on:
> 	- https://patchwork.ozlabs.org/project/uboot/list/?series=113364
> 	- https://patchwork.ozlabs.org/project/uboot/list/?series=110856
> 	- https://patchwork.ozlabs.org/project/uboot/list/?series=109677
> 
> Changes in v4:
> 	- No change.
> Changes in v3:
> 	- No change.
> Changes in v2:
> 	- No change.
> 
>   arch/arm/cpu/armv8/fsl-layerscape/Kconfig |    8 --------
>   board/freescale/ls1028a/ls1028a.c         |    8 ++++++++
>   include/configs/ls1028a_common.h          |    3 ---
>   include/configs/ls1028ardb.h              |    1 -
>   4 files changed, 8 insertions(+), 12 deletions(-)
> 

code changes look OK to me.

Reviewed-by: Alex Marginean <alexm.osslist@gmail.com>

[U-Boot] [PATCH v4 1/4] armv8: ls1028a: The ls1028a platform supports the I2C driver model

[Prabhakar Kushwaha]

> -----Original Message-----
> From: Alex Marginean <alexm.osslist@gmail.com>
> Sent: Friday, July 12, 2019 5:17 PM
> To: Chuanhua Han <chuanhua.han@nxp.com>; albert.u.boot at aribaud.net;
> Sudhanshu Gupta <sudhanshu.gupta@nxp.com>; Harninder Rai
> <harninder.rai@nxp.com>; Rajesh Bhagat <rajesh.bhagat@nxp.com>; Andy
> Tang <andy.tang@nxp.com>; Prabhakar Kushwaha
> <prabhakar.kushwaha@nxp.com>
> Cc: u-boot at lists.denx.de
> Subject: Re: [U-Boot] [PATCH v4 1/4] armv8: ls1028a: The ls1028a platform
> supports the I2C driver model
> 
> On 7/10/2019 4:16 PM, Chuanhua Han wrote:
> > DM_I2C_COMPAT is a compatibility layer that allows using the non-DM
> > I2C API when DM_I2C is used.When DM_I2C_COMPAT is not enabled for
> > compilation, a compilation error will be generated. This patch solves
> > the problem that the i2c-related api of the ls1028a platform does not
> > support dm.
> 
> I wouldn't mention DM_I2C_COMPAT at all in the commit message, it's not
> currently enabled and after this patch set it's not needed either.
> You could just mention that the patch is updating ls1028a board init code to
> support DM_I2C.
> 
> >
> > Signed-off-by: Chuanhua Han <chuanhua.han@nxp.com>
> > ---
> > depends on:
> > 	-
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatch
> work.ozlabs.org%2Fproject%2Fuboot%2Flist%2F%3Fseries%3D113364&amp;
> data=02%7C01%7Cprabhakar.kushwaha%40nxp.com%7C6f4831088b7844837
> 72d08d706bea74c%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636
> 985288233302816&amp;sdata=Fca4rUVC9A%2BemvycTWnILNfGvlg42iOlwozk
> c0ngIwM%3D&amp;reserved=0
> > 	-
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatch
> work.ozlabs.org%2Fproject%2Fuboot%2Flist%2F%3Fseries%3D110856&amp;
> data=02%7C01%7Cprabhakar.kushwaha%40nxp.com%7C6f4831088b7844837
> 72d08d706bea74c%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636
> 985288233302816&amp;sdata=9%2F1FmA0GZqnODbYvuX3SERC8TDcYF8eMX
> mLzILb3wH0%3D&amp;reserved=0
> > 	-
> >
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatc
> >
> hwork.ozlabs.org%2Fproject%2Fuboot%2Flist%2F%3Fseries%3D109677&amp
> ;dat
> >
> a=02%7C01%7Cprabhakar.kushwaha%40nxp.com%7C6f4831088b784483772d
> 08d706b
> >
> ea74c%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6369852882333
> 02816&
> >
> amp;sdata=HYgFDC9knJz3HdY5BLAHwotg5OutAWWEbz6xmm%2FTXzs%3D&
> amp;reserve
> > d=0
> >
> > Changes in v4:
> > 	- No change.
> > Changes in v3:
> > 	- No change.
> > Changes in v2:
> > 	- No change.
> >
> >   arch/arm/cpu/armv8/fsl-layerscape/Kconfig |    8 --------
> >   board/freescale/ls1028a/ls1028a.c         |    8 ++++++++
> >   include/configs/ls1028a_common.h          |    3 ---
> >   include/configs/ls1028ardb.h              |    1 -
> >   4 files changed, 8 insertions(+), 12 deletions(-)
> >
> 
> code changes look OK to me.
> 
> Reviewed-by: Alex Marginean <alexm.osslist@gmail.com>

This patch has been applied to fsl-qoriq master, awaiting upstream.

--pk