From: Sami Kerola <kerolasa@iki.fi>
To: util-linux@vger.kernel.org
Cc: kerolasa@iki.fi
Subject: [PATCH 00/11] pull: cal(1) spring clean up
Date: Sun, 28 Apr 2013 18:10:56 +0100 [thread overview]
Message-ID: <1367169067-23705-1-git-send-email-kerolasa@iki.fi> (raw)
Hi all,
Occasionally I wonder why cal(1) does not have --week option to include
week numbers to print out. So I decided to have a closer look of the
cal, and found out that it could made a little cleaner. These patches
are about that, and hopefully rather uninteresting. Only patch that has
any implications to users is 0010 which removes of trailing white spaces
from three month print out.
But back to the question. Would it make sense to try add week number
printing? It would work much like 'gcal --with-week-number
--iso-week-number=yes', which brings me to next question. If week
numbers are preferred should both 'standard' and 'iso' week numbers be
implemented? Hearing that the week numbers are not really needed is also
fine. It's not often I need such, the feature would be more like 'nice
to have'.
The following changes since commit a48c321dd175d043fb4572bab625631b2055075e:
textual: fixing typos in a warning and an error message (2013-04-26 13:55:29 +0200)
are available in the git repository at:
git://github.com/kerolasa/lelux-utiliteetit.git 2013wk16
for you to fetch changes up to 0ec2cbe22ef73a0f3b1814a08510c8a30e76ee07:
cal: move global variables to local scope (2013-04-28 17:55:40 +0100)
----------------------------------------------------------------
Sami Kerola (11):
cal: fix preprocessor directive indendation
cal: convert function like definitions to functions
cal: clean up use of constants
tests: add calendar reformation check
cal: simplify calendar reformat calculations
cal: remove unnecessary initializations
cal: de-duplicate julian specific functions
cal: allow day highlight testing
tests: add cal day highlight corner cases
cal: trim three month display trailing white spaces
cal: move global variables to local scope
misc-utils/Makemodule.am | 8 +
misc-utils/cal.c | 517 +++++++++++++++++++++----------------------
tests/commands.sh | 2 +-
tests/expected/cal/1m | 8 +-
tests/expected/cal/3m | 24 +-
tests/expected/cal/highlight | 55 +++++
tests/expected/cal/sep1752 | 198 +++++++++++++++++
tests/expected/cal/year | 8 +-
tests/ts/cal/highlight | 70 ++++++
tests/ts/cal/sep1752 | 95 ++++++++
10 files changed, 702 insertions(+), 283 deletions(-)
create mode 100644 tests/expected/cal/highlight
create mode 100644 tests/expected/cal/sep1752
create mode 100755 tests/ts/cal/highlight
create mode 100755 tests/ts/cal/sep1752
next reply other threads:[~2013-04-28 17:11 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-28 17:10 Sami Kerola [this message]
2013-04-28 17:10 ` [PATCH 01/11] cal: fix preprocessor directive indendation Sami Kerola
2013-04-28 17:10 ` [PATCH 02/11] cal: convert function like definitions to functions Sami Kerola
2013-04-28 17:28 ` Dave Reisner
2013-04-28 20:20 ` Sami Kerola
2013-04-29 15:21 ` Thomas Bächler
2013-04-29 20:21 ` Sami Kerola
2013-04-28 17:10 ` [PATCH 03/11] cal: clean up use of constants Sami Kerola
2013-04-29 15:51 ` Thomas Bächler
2013-04-29 21:05 ` Sami Kerola
2013-04-28 17:11 ` [PATCH 04/11] tests: add calendar reformation check Sami Kerola
2013-04-28 17:11 ` [PATCH 05/11] cal: simplify calendar reformat calculations Sami Kerola
2013-04-28 17:11 ` [PATCH 06/11] cal: remove unnecessary initializations Sami Kerola
2013-04-28 17:11 ` [PATCH 07/11] cal: de-duplicate julian specific functions Sami Kerola
2013-04-28 17:11 ` [PATCH 08/11] cal: allow day highlight testing Sami Kerola
2013-04-29 0:24 ` Pádraig Brady
2013-04-29 8:59 ` Sami Kerola
2013-04-29 9:58 ` Karel Zak
2013-04-28 17:11 ` [PATCH 09/11] tests: add cal day highlight corner cases Sami Kerola
2013-04-28 17:11 ` [PATCH 10/11] cal: trim three month display trailing white spaces Sami Kerola
2013-04-29 0:32 ` Pádraig Brady
2013-04-29 9:11 ` Sami Kerola
2013-04-29 13:40 ` Pádraig Brady
2013-04-29 18:01 ` Sami Kerola
2013-05-01 0:54 ` Pádraig Brady
2013-04-28 17:11 ` [PATCH 11/11] cal: move global variables to local scope Sami Kerola
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1367169067-23705-1-git-send-email-kerolasa@iki.fi \
--to=kerolasa@iki.fi \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox