Re: [PATCH 08/11] cal: allow day highlight testing

[Karel Zak <kzak@redhat.com>]

On Mon, Apr 29, 2013 at 09:59:15AM +0100, Sami Kerola wrote:
> On 29 April 2013 01:24, Pádraig Brady <P@draigbrady.com> wrote:
> > On 04/28/2013 06:11 PM, Sami Kerola wrote:
> >> Requires similar trick as done with more to by pass check whether a
> >> session is or isn't interactive.
> >
> > I wonder should we have an option or env variable to force highlighting?
> > I've wanted a couple of times to pipe output like:
> >   cal --color=always | ansi2html.sh

 yep, coreutils way:

   --color[=WHEN]

 where WHEN is 'auto', 'never' or 'always'. 
 
 Sami, see lib/colors.c. It would be nice to have WHEN evaluation
 (conversion to some enum value) on one place and use the code 
 in dmesg --color[=WHEN] too.

> Your proposal makes totally sense. Karel, please wait a moment (till
> tomorrow) that I have a change to rewrite this change to be more
> useful. I'll send new patch to the list, and update my git sometime
> off-work-hour.

 Maybe we can use more colors in the cal(1) output. What about a
 weekend days, month name, week days line etc. ?


 I personally believe that there is still a lot of places where we can
 improve command line usability and readability. (See for example
 "dmesg -H" in the latest release.)

    Karel
 

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com