From: "Thomas Bächler" <thomas@archlinux.org>
To: Sami Kerola <kerolasa-X3B1VOXEql0@public.gmane.org>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH 02/11] cal: convert function like definitions to functions
Date: Mon, 29 Apr 2013 17:21:32 +0200 [thread overview]
Message-ID: <517E8FFC.2040109@archlinux.org> (raw)
In-Reply-To: <1367169067-23705-3-git-send-email-kerolasa@iki.fi>
[-- Attachment #1: Type: text/plain, Size: 634 bytes --]
Am 28.04.2013 19:10, schrieb Sami Kerola:
> -/* leap year -- account for gregorian reformation in 1752 */
> -#define leap_year(yr) \
> - ((yr) <= 1752 ? !((yr) % 4) : \
> - (!((yr) % 4) && ((yr) % 100)) || !((yr) % 400))
> [...]
> +/* leap year -- account for gregorian reformation in 1752 */
> +int leap_year(int year)
> +{
> + if (year <= 1752)
> + return !(year % 4);
> + else
> + return !(year % 4 && (year % 100 || year % 400));
> +}
This formula is incorrect, there's a difference between the old version
and yours. The original (correct) version is:
( !(year % 4) && (year % 100) ) || !(year % 400)
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
next prev parent reply other threads:[~2013-04-29 15:29 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-28 17:10 [PATCH 00/11] pull: cal(1) spring clean up Sami Kerola
2013-04-28 17:10 ` [PATCH 01/11] cal: fix preprocessor directive indendation Sami Kerola
2013-04-28 17:10 ` [PATCH 02/11] cal: convert function like definitions to functions Sami Kerola
2013-04-28 17:28 ` Dave Reisner
2013-04-28 20:20 ` Sami Kerola
2013-04-29 15:21 ` Thomas Bächler [this message]
2013-04-29 20:21 ` Sami Kerola
2013-04-28 17:10 ` [PATCH 03/11] cal: clean up use of constants Sami Kerola
2013-04-29 15:51 ` Thomas Bächler
2013-04-29 21:05 ` Sami Kerola
2013-04-28 17:11 ` [PATCH 04/11] tests: add calendar reformation check Sami Kerola
2013-04-28 17:11 ` [PATCH 05/11] cal: simplify calendar reformat calculations Sami Kerola
2013-04-28 17:11 ` [PATCH 06/11] cal: remove unnecessary initializations Sami Kerola
2013-04-28 17:11 ` [PATCH 07/11] cal: de-duplicate julian specific functions Sami Kerola
2013-04-28 17:11 ` [PATCH 08/11] cal: allow day highlight testing Sami Kerola
2013-04-29 0:24 ` Pádraig Brady
2013-04-29 8:59 ` Sami Kerola
2013-04-29 9:58 ` Karel Zak
2013-04-28 17:11 ` [PATCH 09/11] tests: add cal day highlight corner cases Sami Kerola
2013-04-28 17:11 ` [PATCH 10/11] cal: trim three month display trailing white spaces Sami Kerola
2013-04-29 0:32 ` Pádraig Brady
2013-04-29 9:11 ` Sami Kerola
2013-04-29 13:40 ` Pádraig Brady
2013-04-29 18:01 ` Sami Kerola
2013-05-01 0:54 ` Pádraig Brady
2013-04-28 17:11 ` [PATCH 11/11] cal: move global variables to local scope Sami Kerola
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=517E8FFC.2040109@archlinux.org \
--to=thomas@archlinux.org \
--cc=kerolasa-X3B1VOXEql0@public.gmane.org \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox