* [PATCH] script.c: drop libintl.h include
@ 2011-09-05 20:02 Peter Korsgaard
2011-09-07 5:33 ` Karel Zak
0 siblings, 1 reply; 4+ messages in thread
From: Peter Korsgaard @ 2011-09-05 20:02 UTC (permalink / raw)
To: util-linux, kerolasa; +Cc: Peter Korsgaard
Commit 8fb810ff26 (script: include-what-you-use header check) added a
<libintl.h> #include, which isn't needed as nls.h includes it (if
enabled) - But worse, breaks the build for systems without libintl.h
(like some uClibc configurations).
Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
---
term-utils/script.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/term-utils/script.c b/term-utils/script.c
index d96ca2f..f708e91 100644
--- a/term-utils/script.c
+++ b/term-utils/script.c
@@ -55,7 +55,6 @@
#include <getopt.h>
#include <unistd.h>
#include <fcntl.h>
-#include <libintl.h>
#include <limits.h>
#include <locale.h>
#include <stddef.h>
--
1.7.5.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] script.c: drop libintl.h include
2011-09-05 20:02 [PATCH] script.c: drop libintl.h include Peter Korsgaard
@ 2011-09-07 5:33 ` Karel Zak
2011-09-07 11:52 ` Peter Korsgaard
0 siblings, 1 reply; 4+ messages in thread
From: Karel Zak @ 2011-09-07 5:33 UTC (permalink / raw)
To: Peter Korsgaard; +Cc: util-linux, kerolasa
On Mon, Sep 05, 2011 at 10:02:55PM +0200, Peter Korsgaard wrote:
> Commit 8fb810ff26 (script: include-what-you-use header check) added a
> <libintl.h> #include, which isn't needed as nls.h includes it (if
> enabled) - But worse, breaks the build for systems without libintl.h
> (like some uClibc configurations).
Already fixed by patch from Natanael Copa.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] script.c: drop libintl.h include
2011-09-07 5:33 ` Karel Zak
@ 2011-09-07 11:52 ` Peter Korsgaard
2011-09-07 14:32 ` Karel Zak
0 siblings, 1 reply; 4+ messages in thread
From: Peter Korsgaard @ 2011-09-07 11:52 UTC (permalink / raw)
To: Karel Zak; +Cc: util-linux, kerolasa
>>>>> "Karel" == Karel Zak <kzak@redhat.com> writes:
Karel> On Mon, Sep 05, 2011 at 10:02:55PM +0200, Peter Korsgaard wrote:
>> Commit 8fb810ff26 (script: include-what-you-use header check) added a
>> <libintl.h> #include, which isn't needed as nls.h includes it (if
>> enabled) - But worse, breaks the build for systems without libintl.h
>> (like some uClibc configurations).
Karel> Already fixed by patch from Natanael Copa.
Ahh, didn't notice it because of the kernel.org issue. While that patch
also fixes the problem, it is more complicated than needed as nls.h
already includes libintl.h - E.G. the explicit include can just be
removed.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] script.c: drop libintl.h include
2011-09-07 11:52 ` Peter Korsgaard
@ 2011-09-07 14:32 ` Karel Zak
0 siblings, 0 replies; 4+ messages in thread
From: Karel Zak @ 2011-09-07 14:32 UTC (permalink / raw)
To: Peter Korsgaard; +Cc: util-linux, kerolasa
On Wed, Sep 07, 2011 at 01:52:19PM +0200, Peter Korsgaard wrote:
> >>>>> "Karel" == Karel Zak <kzak@redhat.com> writes:
>
> Karel> On Mon, Sep 05, 2011 at 10:02:55PM +0200, Peter Korsgaard wrote:
> >> Commit 8fb810ff26 (script: include-what-you-use header check) added a
> >> <libintl.h> #include, which isn't needed as nls.h includes it (if
> >> enabled) - But worse, breaks the build for systems without libintl.h
> >> (like some uClibc configurations).
>
> Karel> Already fixed by patch from Natanael Copa.
>
> Ahh, didn't notice it because of the kernel.org issue. While that patch
> also fixes the problem, it is more complicated than needed as nls.h
> already includes libintl.h - E.G. the explicit include can just be
> removed.
Yes, good point. Fixed.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-09-07 16:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-05 20:02 [PATCH] script.c: drop libintl.h include Peter Korsgaard
2011-09-07 5:33 ` Karel Zak
2011-09-07 11:52 ` Peter Korsgaard
2011-09-07 14:32 ` Karel Zak
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox