Compile failure due to use of qsort_r

Compile failure due to use of qsort_r

[Paul Barker]

Hi all,

I'm using util-linux as part of the OpenEmbedded build system and
we've ran into two places where the use of qsort_r in util-linux is
causing a compile failure:

- CentOS 5.10 is using an old version of glibc which doesn't provide qsort_r

- We're experimenting with musl-libc and this also doesn't provide qsort_r

qsort_r is only used in one place in libfdisk/src/sun.c to my knowledge.

Personally I think a good solution would be to add a configure check
on whether qsort_r is provided and to either error out at that stage
or provide a workaround.

I'm pretty starved for time myself so sadly all I can do is report the failure.

Thanks,

-- 
Paul Barker

Email: paul@paulbarker.me.uk
http://www.paulbarker.me.uk

Re: Compile failure due to use of qsort_r

[Karel Zak]

On Tue, Apr 01, 2014 at 01:03:10PM +0100, Paul Barker wrote:
> Hi all,
> 
> I'm using util-linux as part of the OpenEmbedded build system and
> we've ran into two places where the use of qsort_r in util-linux is
> causing a compile failure:
> 
> - CentOS 5.10 is using an old version of glibc which doesn't provide qsort_r

 Well, I don't like this kind of arguments -- it's almost always
 problematic to update only small subset of distro...

> - We're experimenting with musl-libc and this also doesn't provide qsort_r

 This is better, I'll add #ifdef to the code. Thanks.

    Karel

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com

Re: Compile failure due to use of qsort_r

[Karel Zak]

On Tue, Apr 01, 2014 at 01:03:10PM +0100, Paul Barker wrote:
> Personally I think a good solution would be to add a configure check
> on whether qsort_r is provided and to either error out at that stage
> or provide a workaround.

Fixed.

The code in libfdisk is not so important, I've made it optional by #ifdef
HAVE_QSORT_R.

    Karel

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com

Re: Compile failure due to use of qsort_r

[Paul Barker]

On 4 April 2014 15:09, Karel Zak <kzak@redhat.com> wrote:
> On Tue, Apr 01, 2014 at 01:03:10PM +0100, Paul Barker wrote:
>> Personally I think a good solution would be to add a configure check
>> on whether qsort_r is provided and to either error out at that stage
>> or provide a workaround.
>
> Fixed.
>
> The code in libfdisk is not so important, I've made it optional by #ifdef
> HAVE_QSORT_R.
>
>     Karel
>

Many thanks!

-- 
Paul Barker

Email: paul@paulbarker.me.uk
http://www.paulbarker.me.uk