* Compile failure due to use of qsort_r
@ 2014-04-01 12:03 Paul Barker
2014-04-01 13:45 ` Karel Zak
2014-04-04 14:09 ` Karel Zak
0 siblings, 2 replies; 4+ messages in thread
From: Paul Barker @ 2014-04-01 12:03 UTC (permalink / raw)
To: util-linux
Hi all,
I'm using util-linux as part of the OpenEmbedded build system and
we've ran into two places where the use of qsort_r in util-linux is
causing a compile failure:
- CentOS 5.10 is using an old version of glibc which doesn't provide qsort_r
- We're experimenting with musl-libc and this also doesn't provide qsort_r
qsort_r is only used in one place in libfdisk/src/sun.c to my knowledge.
Personally I think a good solution would be to add a configure check
on whether qsort_r is provided and to either error out at that stage
or provide a workaround.
I'm pretty starved for time myself so sadly all I can do is report the failure.
Thanks,
--
Paul Barker
Email: paul@paulbarker.me.uk
http://www.paulbarker.me.uk
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Compile failure due to use of qsort_r
2014-04-01 12:03 Compile failure due to use of qsort_r Paul Barker
@ 2014-04-01 13:45 ` Karel Zak
2014-04-04 14:09 ` Karel Zak
1 sibling, 0 replies; 4+ messages in thread
From: Karel Zak @ 2014-04-01 13:45 UTC (permalink / raw)
To: Paul Barker; +Cc: util-linux
On Tue, Apr 01, 2014 at 01:03:10PM +0100, Paul Barker wrote:
> Hi all,
>
> I'm using util-linux as part of the OpenEmbedded build system and
> we've ran into two places where the use of qsort_r in util-linux is
> causing a compile failure:
>
> - CentOS 5.10 is using an old version of glibc which doesn't provide qsort_r
Well, I don't like this kind of arguments -- it's almost always
problematic to update only small subset of distro...
> - We're experimenting with musl-libc and this also doesn't provide qsort_r
This is better, I'll add #ifdef to the code. Thanks.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: Compile failure due to use of qsort_r
2014-04-01 12:03 Compile failure due to use of qsort_r Paul Barker
2014-04-01 13:45 ` Karel Zak
@ 2014-04-04 14:09 ` Karel Zak
2014-04-04 16:37 ` Paul Barker
1 sibling, 1 reply; 4+ messages in thread
From: Karel Zak @ 2014-04-04 14:09 UTC (permalink / raw)
To: Paul Barker; +Cc: util-linux
On Tue, Apr 01, 2014 at 01:03:10PM +0100, Paul Barker wrote:
> Personally I think a good solution would be to add a configure check
> on whether qsort_r is provided and to either error out at that stage
> or provide a workaround.
Fixed.
The code in libfdisk is not so important, I've made it optional by #ifdef
HAVE_QSORT_R.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: Compile failure due to use of qsort_r
2014-04-04 14:09 ` Karel Zak
@ 2014-04-04 16:37 ` Paul Barker
0 siblings, 0 replies; 4+ messages in thread
From: Paul Barker @ 2014-04-04 16:37 UTC (permalink / raw)
To: Karel Zak; +Cc: util-linux
On 4 April 2014 15:09, Karel Zak <kzak@redhat.com> wrote:
> On Tue, Apr 01, 2014 at 01:03:10PM +0100, Paul Barker wrote:
>> Personally I think a good solution would be to add a configure check
>> on whether qsort_r is provided and to either error out at that stage
>> or provide a workaround.
>
> Fixed.
>
> The code in libfdisk is not so important, I've made it optional by #ifdef
> HAVE_QSORT_R.
>
> Karel
>
Many thanks!
--
Paul Barker
Email: paul@paulbarker.me.uk
http://www.paulbarker.me.uk
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-04-04 16:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-01 12:03 Compile failure due to use of qsort_r Paul Barker
2014-04-01 13:45 ` Karel Zak
2014-04-04 14:09 ` Karel Zak
2014-04-04 16:37 ` Paul Barker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox