From: Ruediger Meier <sweet_f_a@gmx.de>
To: util-linux@vger.kernel.org
Subject: [PATCH 1/6] tests: fix fincore, don't use variable COLUMNS
Date: Mon, 12 Jun 2017 10:49:53 +0200 [thread overview]
Message-ID: <20170612084958.22054-2-sweet_f_a@gmx.de> (raw)
In-Reply-To: <20170612084958.22054-1-sweet_f_a@gmx.de>
From: Ruediger Meier <ruediger.meier@ga-group.nl>
COLUMNS is automatically set by bash and may result in stupid
errors like
fincore: unknown column: 160
Signed-off-by: Ruediger Meier <ruediger.meier@ga-group.nl>
---
tests/ts/fincore/count | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/tests/ts/fincore/count b/tests/ts/fincore/count
index 7a1c5d426..0151016ee 100755
--- a/tests/ts/fincore/count
+++ b/tests/ts/fincore/count
@@ -70,7 +70,7 @@ function run_dd_test
_dd if=/dev/zero of=$input count=1 bs=$bs $flags || return
fi
- $TS_CMD_FINCORE --output $COLUMNS --bytes --noheadings $input
+ $TS_CMD_FINCORE --output $OUT_COLUMNS --bytes --noheadings $input
footer "$?"
}
@@ -90,7 +90,7 @@ function run_dd_dd_test
_dd if=/dev/zero of=$input count=1 bs=$bs $flags0 || return
_dd if=/dev/zero of=$input count=1 bs=$bs $flags1 || return
- $TS_CMD_FINCORE --output $COLUMNS --bytes --noheadings $input
+ $TS_CMD_FINCORE --output $OUT_COLUMNS --bytes --noheadings $input
footer "$?"
}
@@ -102,10 +102,10 @@ WINDOW_SIZE=$(( 32 * 1024 * PAGE_SIZE ))
# we use PAGE_SIZE dependent output for a few systems
if test -f "$TS_EXPECTED.$PAGE_SIZE"; then
TS_EXPECTED+=".$PAGE_SIZE"
- COLUMNS="PAGES,SIZE,FILE"
+ OUT_COLUMNS="PAGES,SIZE,FILE"
else
TS_EXPECTED+=".nosize"
- COLUMNS="PAGES,FILE"
+ OUT_COLUMNS="PAGES,FILE"
fi
@@ -122,7 +122,7 @@ input=
INPUT="${INPUT} ${input}"
header "NO EXCITING FILE"
- $TS_CMD_FINCORE --output $COLUMNS --bytes --noheadings $input
+ $TS_CMD_FINCORE --output $OUT_COLUMNS --bytes --noheadings $input
footer "$?"
} >> $TS_OUTPUT 2>&1
@@ -220,7 +220,7 @@ input=
{
header "MULTIPLE FILES"
- $TS_CMD_FINCORE --output $COLUMNS --bytes $INPUT
+ $TS_CMD_FINCORE --output $OUT_COLUMNS --bytes $INPUT
footer "$?"
} >> $TS_OUTPUT 2>&1
--
2.12.3
next prev parent reply other threads:[~2017-06-12 8:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-12 8:49 [PATCH 0/6] fix various minor issues and warnings Ruediger Meier
2017-06-12 8:49 ` Ruediger Meier [this message]
2017-06-12 8:49 ` [PATCH 2/6] libmount: btrfs, remove unused setter functions Ruediger Meier
2017-06-12 8:49 ` [PATCH 3/6] hwclock: fix warning [-Winvalid-noreturn] Ruediger Meier
2017-06-12 8:49 ` [PATCH 4/6] misc: fix gcc-7 sprintf warnings -Wformat-overflow Ruediger Meier
2017-06-12 8:49 ` [PATCH 5/6] misc: fix gcc-7 snprintf warnings -Wformat-truncation Ruediger Meier
2017-06-12 19:27 ` Rüdiger Meier
2017-06-12 8:49 ` [PATCH 6/6] libblkid: fix gcc-7 warning -Wint-in-bool-context Ruediger Meier
2017-06-13 13:47 ` [PATCH 0/6] fix various minor issues and warnings Karel Zak
2017-06-13 15:18 ` Rüdiger Meier
2017-06-14 10:10 ` Karel Zak
2017-06-14 11:06 ` Ruediger Meier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170612084958.22054-2-sweet_f_a@gmx.de \
--to=sweet_f_a@gmx.de \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox