util-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Rüdiger Meier" <sweet_f_a@gmx.de>
To: util-linux@vger.kernel.org
Subject: Re: [PATCH 5/6] misc: fix gcc-7 snprintf warnings -Wformat-truncation
Date: Mon, 12 Jun 2017 21:27:58 +0200	[thread overview]
Message-ID: <64d3bf7c-84b8-1f5b-663f-82860b3d2d56@gmx.de> (raw)
In-Reply-To: <20170612084958.22054-6-sweet_f_a@gmx.de>

BTW there is another of these warnings left, see below. I'm not sure here what
to do. Note, it's pssible to silent this warning also by _using_ snprintf's
return value.

../libblkid/src/partitions/partitions.c:1371:45: warning: '%02x' directive output may be truncated writing between 2 and 8 bytes into a region of size between 0 and 36 [-Wformat-truncation=]
   snprintf(par->uuid, sizeof(par->uuid), "%s-%02x",
                                              ^~~~
../libblkid/src/partitions/partitions.c:1371:41: note: using the range [0, 4294967295] for directive argument
   snprintf(par->uuid, sizeof(par->uuid), "%s-%02x",
                                          ^~~~~~~~~
../libblkid/src/partitions/partitions.c:1371:2: note: 'snprintf' output between 4 and 46 bytes into a destination of size 37
   snprintf(par->uuid, sizeof(par->uuid), "%s-%02x",
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     par->tab->id, par->partno);
     ~~~~~~~~~~~~~~~~~~~~~~~~~~


  reply	other threads:[~2017-06-12 19:28 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-12  8:49 [PATCH 0/6] fix various minor issues and warnings Ruediger Meier
2017-06-12  8:49 ` [PATCH 1/6] tests: fix fincore, don't use variable COLUMNS Ruediger Meier
2017-06-12  8:49 ` [PATCH 2/6] libmount: btrfs, remove unused setter functions Ruediger Meier
2017-06-12  8:49 ` [PATCH 3/6] hwclock: fix warning [-Winvalid-noreturn] Ruediger Meier
2017-06-12  8:49 ` [PATCH 4/6] misc: fix gcc-7 sprintf warnings -Wformat-overflow Ruediger Meier
2017-06-12  8:49 ` [PATCH 5/6] misc: fix gcc-7 snprintf warnings -Wformat-truncation Ruediger Meier
2017-06-12 19:27   ` Rüdiger Meier [this message]
2017-06-12  8:49 ` [PATCH 6/6] libblkid: fix gcc-7 warning -Wint-in-bool-context Ruediger Meier
2017-06-13 13:47 ` [PATCH 0/6] fix various minor issues and warnings Karel Zak
2017-06-13 15:18   ` Rüdiger Meier
2017-06-14 10:10     ` Karel Zak
2017-06-14 11:06       ` Ruediger Meier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=64d3bf7c-84b8-1f5b-663f-82860b3d2d56@gmx.de \
    --to=sweet_f_a@gmx.de \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).