Util-Linux package development
 help / color / mirror / Atom feed
From: Ruediger Meier <sweet_f_a@gmx.de>
To: Karel Zak <kzak@redhat.com>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH 0/6] fix various minor issues and warnings
Date: Wed, 14 Jun 2017 13:06:46 +0200	[thread overview]
Message-ID: <201706141306.46931.sweet_f_a@gmx.de> (raw)
In-Reply-To: <20170614101014.qnttyscgvcsruh4m@ws.net.home>

On Wednesday 14 June 2017, Karel Zak wrote:
> On Tue, Jun 13, 2017 at 05:18:33PM +0200, R=FCdiger Meier wrote:
> > On 06/13/2017 03:47 PM, Karel Zak wrote:
> > > On Mon, Jun 12, 2017 at 10:49:52AM +0200, Ruediger Meier wrote:
> > > > From: Ruediger Meier <ruediger.meier@ga-group.nl>
> > > >
> > > > Ruediger Meier (6):
> > > >    tests: fix fincore, don't use variable COLUMNS
> > > >    libmount: btrfs, remove unused setter functions
> > > >    hwclock: fix warning [-Winvalid-noreturn]
> > > >    misc: fix gcc-7 sprintf warnings -Wformat-overflow
> > > >    misc: fix gcc-7 snprintf warnings -Wformat-truncation
> > > >    libblkid: fix gcc-7 warning -Wint-in-bool-context
> > > >
> > > >   lib/loopdev.c                    |  2 +-
> > > >   lib/sysfs.c                      |  4 ++--
> > > >   libblkid/src/devname.c           |  2 +-
> > > >   libblkid/src/superblocks/exfat.c |  4 ++--
> > > >   libmount/src/btrfs.c             |  4 ----
> > > >   login-utils/last.c               |  2 +-
> > > >   sys-utils/hwclock.c              |  2 +-
> > > >   sys-utils/hwclock.h              |  3 ++-
> > > >   tests/ts/fincore/count           | 12 ++++++------
> > > >   9 files changed, 16 insertions(+), 19 deletions(-)
> > >
> > > Seems better than the previous version from Sami (May 27).
> >
> > These fixed are completely independent/unrelated to the other pull
> > request from Sami. Sami's PR just motivated me to try out gcc-7
> > too.
>
> Yep, you both tried to fix the sprintf warnings, your version with
> NAME_MAX seems better.

Ooops, I didn't even noticed and could merge all together without=20
confilcts.

> Applied, thanks.
>
>     Karel

      reply	other threads:[~2017-06-14 11:06 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-12  8:49 [PATCH 0/6] fix various minor issues and warnings Ruediger Meier
2017-06-12  8:49 ` [PATCH 1/6] tests: fix fincore, don't use variable COLUMNS Ruediger Meier
2017-06-12  8:49 ` [PATCH 2/6] libmount: btrfs, remove unused setter functions Ruediger Meier
2017-06-12  8:49 ` [PATCH 3/6] hwclock: fix warning [-Winvalid-noreturn] Ruediger Meier
2017-06-12  8:49 ` [PATCH 4/6] misc: fix gcc-7 sprintf warnings -Wformat-overflow Ruediger Meier
2017-06-12  8:49 ` [PATCH 5/6] misc: fix gcc-7 snprintf warnings -Wformat-truncation Ruediger Meier
2017-06-12 19:27   ` Rüdiger Meier
2017-06-12  8:49 ` [PATCH 6/6] libblkid: fix gcc-7 warning -Wint-in-bool-context Ruediger Meier
2017-06-13 13:47 ` [PATCH 0/6] fix various minor issues and warnings Karel Zak
2017-06-13 15:18   ` Rüdiger Meier
2017-06-14 10:10     ` Karel Zak
2017-06-14 11:06       ` Ruediger Meier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201706141306.46931.sweet_f_a@gmx.de \
    --to=sweet_f_a@gmx.de \
    --cc=kzak@redhat.com \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox