* [PATCH] virtio-mem: Fix build error due to improper use 'select'
@ 2020-06-19 8:03 Weilong Chen
2020-06-19 7:54 ` Jason Wang
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Weilong Chen @ 2020-06-19 8:03 UTC (permalink / raw)
To: mst, jasowang, virtualization, lizefan; +Cc: linux-kernel
As noted in:
https://www.kernel.org/doc/Documentation/kbuild/kconfig-language.txt
"select should be used with care. select will force a symbol to a
value without visiting the dependencies."
Config VIRTIO_MEM should not select CONTIG_ALLOC directly.
Otherwise it will cause an error:
https://bugzilla.kernel.org/show_bug.cgi?id=208245
Signed-off-by: Weilong Chen <chenweilong@huawei.com>
---
drivers/virtio/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
index 5809e5f5b157..5c92e4a50882 100644
--- a/drivers/virtio/Kconfig
+++ b/drivers/virtio/Kconfig
@@ -85,7 +85,7 @@ config VIRTIO_MEM
depends on VIRTIO
depends on MEMORY_HOTPLUG_SPARSE
depends on MEMORY_HOTREMOVE
- select CONTIG_ALLOC
+ depends on CONTIG_ALLOC
help
This driver provides access to virtio-mem paravirtualized memory
devices, allowing to hotplug and hotunplug memory.
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] virtio-mem: Fix build error due to improper use 'select'
2020-06-19 8:03 [PATCH] virtio-mem: Fix build error due to improper use 'select' Weilong Chen
@ 2020-06-19 7:54 ` Jason Wang
2020-06-19 11:39 ` Michael S. Tsirkin
2020-06-19 11:49 ` David Hildenbrand
2 siblings, 0 replies; 4+ messages in thread
From: Jason Wang @ 2020-06-19 7:54 UTC (permalink / raw)
To: Weilong Chen, mst, virtualization, lizefan; +Cc: linux-kernel
On 2020/6/19 下午4:03, Weilong Chen wrote:
> As noted in:
> https://www.kernel.org/doc/Documentation/kbuild/kconfig-language.txt
> "select should be used with care. select will force a symbol to a
> value without visiting the dependencies."
> Config VIRTIO_MEM should not select CONTIG_ALLOC directly.
> Otherwise it will cause an error:
> https://bugzilla.kernel.org/show_bug.cgi?id=208245
>
> Signed-off-by: Weilong Chen <chenweilong@huawei.com>
> ---
> drivers/virtio/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
> index 5809e5f5b157..5c92e4a50882 100644
> --- a/drivers/virtio/Kconfig
> +++ b/drivers/virtio/Kconfig
> @@ -85,7 +85,7 @@ config VIRTIO_MEM
> depends on VIRTIO
> depends on MEMORY_HOTPLUG_SPARSE
> depends on MEMORY_HOTREMOVE
> - select CONTIG_ALLOC
> + depends on CONTIG_ALLOC
> help
> This driver provides access to virtio-mem paravirtualized memory
> devices, allowing to hotplug and hotunplug memory.
Acked-by: Jason Wang <jasowang@redhat.com>
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] virtio-mem: Fix build error due to improper use 'select'
2020-06-19 8:03 [PATCH] virtio-mem: Fix build error due to improper use 'select' Weilong Chen
2020-06-19 7:54 ` Jason Wang
@ 2020-06-19 11:39 ` Michael S. Tsirkin
2020-06-19 11:49 ` David Hildenbrand
2 siblings, 0 replies; 4+ messages in thread
From: Michael S. Tsirkin @ 2020-06-19 11:39 UTC (permalink / raw)
To: Weilong Chen
Cc: jasowang, virtualization, lizefan, linux-kernel,
David Hildenbrand
On Fri, Jun 19, 2020 at 04:03:33PM +0800, Weilong Chen wrote:
> As noted in:
> https://www.kernel.org/doc/Documentation/kbuild/kconfig-language.txt
> "select should be used with care. select will force a symbol to a
> value without visiting the dependencies."
> Config VIRTIO_MEM should not select CONTIG_ALLOC directly.
> Otherwise it will cause an error:
> https://bugzilla.kernel.org/show_bug.cgi?id=208245
>
> Signed-off-by: Weilong Chen <chenweilong@huawei.com>
Cc virtio mem maintainer:
M: David Hildenbrand <david@redhat.com>
> ---
> drivers/virtio/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
> index 5809e5f5b157..5c92e4a50882 100644
> --- a/drivers/virtio/Kconfig
> +++ b/drivers/virtio/Kconfig
> @@ -85,7 +85,7 @@ config VIRTIO_MEM
> depends on VIRTIO
> depends on MEMORY_HOTPLUG_SPARSE
> depends on MEMORY_HOTREMOVE
> - select CONTIG_ALLOC
> + depends on CONTIG_ALLOC
> help
> This driver provides access to virtio-mem paravirtualized memory
> devices, allowing to hotplug and hotunplug memory.
> --
> 2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] virtio-mem: Fix build error due to improper use 'select'
2020-06-19 8:03 [PATCH] virtio-mem: Fix build error due to improper use 'select' Weilong Chen
2020-06-19 7:54 ` Jason Wang
2020-06-19 11:39 ` Michael S. Tsirkin
@ 2020-06-19 11:49 ` David Hildenbrand
2 siblings, 0 replies; 4+ messages in thread
From: David Hildenbrand @ 2020-06-19 11:49 UTC (permalink / raw)
To: Weilong Chen, mst, jasowang, virtualization, lizefan; +Cc: linux-kernel
On 19.06.20 10:03, Weilong Chen wrote:
> As noted in:
> https://www.kernel.org/doc/Documentation/kbuild/kconfig-language.txt
> "select should be used with care. select will force a symbol to a
> value without visiting the dependencies."
Right, rings a bell.
> Config VIRTIO_MEM should not select CONTIG_ALLOC directly.
> Otherwise it will cause an error:
> https://bugzilla.kernel.org/show_bug.cgi?id=208245
Thanks!
Acked-by: David Hildenbrand <david@redhat.com>
>
> Signed-off-by: Weilong Chen <chenweilong@huawei.com>
> ---
> drivers/virtio/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
> index 5809e5f5b157..5c92e4a50882 100644
> --- a/drivers/virtio/Kconfig
> +++ b/drivers/virtio/Kconfig
> @@ -85,7 +85,7 @@ config VIRTIO_MEM
> depends on VIRTIO
> depends on MEMORY_HOTPLUG_SPARSE
> depends on MEMORY_HOTREMOVE
> - select CONTIG_ALLOC
> + depends on CONTIG_ALLOC
> help
> This driver provides access to virtio-mem paravirtualized memory
> devices, allowing to hotplug and hotunplug memory.
>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-06-19 11:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-19 8:03 [PATCH] virtio-mem: Fix build error due to improper use 'select' Weilong Chen
2020-06-19 7:54 ` Jason Wang
2020-06-19 11:39 ` Michael S. Tsirkin
2020-06-19 11:49 ` David Hildenbrand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox