From: Dave Hansen <dave.hansen@linux.intel.com>
To: linux-kernel@vger.kernel.org
Cc: Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Borislav Petkov <bp@alien8.de>,
x86@kernel.org, Juergen Gross <jgross@suse.com>,
virtualization@lists.linux.dev,
Dave Hansen <dave.hansen@linux.intel.com>
Subject: [PATCH v2 1/8] x86/msr: Use paravirt "calls" in common code
Date: Wed, 29 Apr 2026 11:45:19 -0700 [thread overview]
Message-ID: <20260429184519.A701C74E@davehans-spike.ostc.intel.com> (raw)
In-Reply-To: <20260429184517.7E078510@davehans-spike.ostc.intel.com>
From: Dave Hansen <dave.hansen@linux.intel.com>
Currently, the paravirt and native code define a common set of MSR
functions. But, some of the code is duplicated between the two. For
instance, the packing and unpacking of the 64-bit MSR value into two
32-bit values is done in both.
Prepare to consolidate the two copies. Have common code use the
paravirt_{rd,wr}msr*() naming and short-circuit the paravirt
infrastructure with the preprocessor to do paravirt=>native without
any paravirt overhead.
Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
---
b/arch/x86/include/asm/msr.h | 21 ++++++++++++++-------
1 file changed, 14 insertions(+), 7 deletions(-)
diff -puN arch/x86/include/asm/msr.h~raw_msr_names arch/x86/include/asm/msr.h
--- a/arch/x86/include/asm/msr.h~raw_msr_names 2026-04-01 14:32:55.572415984 -0700
+++ b/arch/x86/include/asm/msr.h 2026-04-01 14:32:55.575416096 -0700
@@ -173,6 +173,13 @@ static inline u64 native_read_pmc(int co
#include <asm/paravirt.h>
#else
#include <linux/errno.h>
+
+/* Short-circuit the paravirt MSR infrastructure when it is disabled: */
+#define paravirt_read_msr native_read_msr
+#define paravirt_read_msr_safe native_read_msr_safe
+#define paravirt_write_msr native_write_msr
+#define paravirt_write_msr_safe native_write_msr_safe
+
/*
* Access to machine-specific registers (available on 586 and better only)
* Note: the rd* operations modify the parameters directly (without using
@@ -181,35 +188,35 @@ static inline u64 native_read_pmc(int co
#define rdmsr(msr, low, high) \
do { \
- u64 __val = native_read_msr((msr)); \
+ u64 __val = paravirt_read_msr((msr)); \
(void)((low) = (u32)__val); \
(void)((high) = (u32)(__val >> 32)); \
} while (0)
static inline void wrmsr(u32 msr, u32 low, u32 high)
{
- native_write_msr(msr, (u64)high << 32 | low);
+ paravirt_write_msr(msr, (u64)high << 32 | low);
}
#define rdmsrq(msr, val) \
- ((val) = native_read_msr((msr)))
+ ((val) = paravirt_read_msr((msr)))
static inline void wrmsrq(u32 msr, u64 val)
{
- native_write_msr(msr, val);
+ paravirt_write_msr(msr, val);
}
/* wrmsr with exception handling */
static inline int wrmsrq_safe(u32 msr, u64 val)
{
- return native_write_msr_safe(msr, val);
+ return paravirt_write_msr_safe(msr, val);
}
/* rdmsr with exception handling */
#define rdmsr_safe(msr, low, high) \
({ \
u64 __val; \
- int __err = native_read_msr_safe((msr), &__val); \
+ int __err = paravirt_read_msr_safe((msr), &__val); \
(*low) = (u32)__val; \
(*high) = (u32)(__val >> 32); \
__err; \
@@ -217,7 +224,7 @@ static inline int wrmsrq_safe(u32 msr, u
static inline int rdmsrq_safe(u32 msr, u64 *p)
{
- return native_read_msr_safe(msr, p);
+ return paravirt_read_msr_safe(msr, p);
}
static __always_inline u64 rdpmc(int counter)
_
next prev parent reply other threads:[~2026-04-29 18:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-29 18:45 [PATCH v2 0/8] x86/msr: Consolidate native/paravirt MSR functions Dave Hansen
2026-04-29 18:45 ` Dave Hansen [this message]
2026-04-29 18:45 ` [PATCH v2 2/8] x86/msr: Consolidate rdmsr() definitions Dave Hansen
2026-05-06 2:03 ` Yan Zhao
2026-05-06 10:25 ` Yan Zhao
2026-05-06 11:09 ` Jürgen Groß
2026-05-07 8:21 ` Yan Zhao
2026-04-29 18:45 ` [PATCH v2 3/8] x86/msr: Consolidate rdmsr_safe() implementations Dave Hansen
2026-04-30 19:43 ` Maciej Wieczor-Retman
2026-04-29 18:45 ` [PATCH v2 4/8] x86/msr: Consolidate rdmsrq() implementations Dave Hansen
2026-04-29 18:45 ` [PATCH v2 5/8] x86/msr: Consolidate {rd,wr}msr[q]_safe() implementations Dave Hansen
2026-04-29 18:45 ` [PATCH v2 6/8] x86/msr: Consolidate rdpmc() implementations Dave Hansen
2026-04-29 18:45 ` [PATCH v2 7/8] x86/msr: Remove old crusty comment Dave Hansen
2026-04-29 18:45 ` [PATCH v2 8/8] x86/msr: Remove duplicate #include Dave Hansen
2026-04-30 7:20 ` Jürgen Groß
2026-04-30 17:42 ` Dave Hansen
2026-04-30 19:22 ` Jürgen Groß
2026-04-30 7:21 ` [PATCH v2 0/8] x86/msr: Consolidate native/paravirt MSR functions Jürgen Groß
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260429184519.A701C74E@davehans-spike.ostc.intel.com \
--to=dave.hansen@linux.intel.com \
--cc=bp@alien8.de \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@kernel.org \
--cc=virtualization@lists.linux.dev \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox