Re: [PATCH v2 8/8] x86/msr: Remove duplicate #include

["Jürgen Groß" <jgross@suse.com>]

[-- Attachment #1.1.1: Type: text/plain, Size: 1032 bytes --]

On 29.04.26 20:45, Dave Hansen wrote:
> From: Dave Hansen <dave.hansen@linux.intel.com>
> 
> errno.h is already included for C code at the top of the header.

I'm seeing only asm/errno.h being included.

I don't say linux/errno.h is needed, but the reasoning is not really
convincing.


Juergen

> Zap the duplicate.
> 
> Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
> ---
> 
>   b/arch/x86/include/asm/msr.h |    1 -
>   1 file changed, 1 deletion(-)
> 
> diff -puN arch/x86/include/asm/msr.h~rdmsr-dups-11 arch/x86/include/asm/msr.h
> --- a/arch/x86/include/asm/msr.h~rdmsr-dups-11	2026-04-29 11:38:57.838732405 -0700
> +++ b/arch/x86/include/asm/msr.h	2026-04-29 11:38:57.841732519 -0700
> @@ -172,7 +172,6 @@ static inline u64 native_read_pmc(int co
>   #ifdef CONFIG_PARAVIRT_XXL
>   #include <asm/paravirt.h>
>   #else
> -#include <linux/errno.h>
>   
>   /* Short-circuit the paravirt MSR infrastructure when it is disabled: */
>   #define paravirt_read_msr	native_read_msr
> _


[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3743 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]