Keep scripts/create-pull-request and send-pull-request ?

Keep scripts/create-pull-request and send-pull-request ?

[Michael Opdenacker]

Greetings,

I'm reviewing 
https://docs.yoctoproject.org/next/contributor-guide/submit-change.html#using-scripts-to-push-a-change-upstream-and-request-a-pull 
and trying to simplify it.

Do people still use scripts/create-pull-request and send-pull-request? I 
see some obsolete URLs in the first script, and mostly old commits to 
their code.

I'm also asking because I'm wondering whether it's better to document 
how to create and send pull requests from standard git tools. This way, 
people also learn how to submit pull requests to other upstreams.

What do you think?

Thanks in advance
Michael.

-- 
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [docs] Keep scripts/create-pull-request and send-pull-request ?

[Bruce Ashfield]

On Thu, Aug 10, 2023 at 10:04 AM Michael Opdenacker via
lists.yoctoproject.org
<michael.opdenacker=bootlin.com@lists.yoctoproject.org> wrote:
>
> Greetings,
>
> I'm reviewing
> https://docs.yoctoproject.org/next/contributor-guide/submit-change.html#using-scripts-to-push-a-change-upstream-and-request-a-pull
> and trying to simplify it.
>
> Do people still use scripts/create-pull-request and send-pull-request? I
> see some obsolete URLs in the first script, and mostly old commits to
> their code.

I use create-pull-request for all my series, so the scripts still do
work and are in at least in use here.

But I send with git send-email directly.

Bruce

>
> I'm also asking because I'm wondering whether it's better to document
> how to create and send pull requests from standard git tools. This way,
> people also learn how to submit pull requests to other upstreams.
>
> What do you think?
>
> Thanks in advance
> Michael.
>
> --
> Michael Opdenacker, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#4135): https://lists.yoctoproject.org/g/docs/message/4135
> Mute This Topic: https://lists.yoctoproject.org/mt/100663723/1050810
> Group Owner: docs+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/docs/unsub [bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>


-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

Re: [docs] Keep scripts/create-pull-request and send-pull-request ?

[Michael Opdenacker]

Hi Bruce

On 10.08.23 at 16:09, Bruce Ashfield wrote:
> On Thu, Aug 10, 2023 at 10:04 AM Michael Opdenacker via
> lists.yoctoproject.org
> <michael.opdenacker=bootlin.com@lists.yoctoproject.org> wrote:
>> Greetings,
>>
>> I'm reviewing
>> https://docs.yoctoproject.org/next/contributor-guide/submit-change.html#using-scripts-to-push-a-change-upstream-and-request-a-pull
>> and trying to simplify it.
>>
>> Do people still use scripts/create-pull-request and send-pull-request? I
>> see some obsolete URLs in the first script, and mostly old commits to
>> their code.
> I use create-pull-request for all my series, so the scripts still do
> work and are in at least in use here.
>
> But I send with git send-email directly.


Good to know, thanks!
So, we need to keep at least the first one. I'll send a patch to it then.

I'm not saying we should keep documenting them though ;-)

Thanks
Michael.

-- 
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [docs] Keep scripts/create-pull-request and send-pull-request ?

[Bruce Ashfield]

On Thu, Aug 10, 2023 at 10:13 AM Michael Opdenacker
<michael.opdenacker@bootlin.com> wrote:
>
> Hi Bruce
>
> On 10.08.23 at 16:09, Bruce Ashfield wrote:
> > On Thu, Aug 10, 2023 at 10:04 AM Michael Opdenacker via
> > lists.yoctoproject.org
> > <michael.opdenacker=bootlin.com@lists.yoctoproject.org> wrote:
> >> Greetings,
> >>
> >> I'm reviewing
> >> https://docs.yoctoproject.org/next/contributor-guide/submit-change.html#using-scripts-to-push-a-change-upstream-and-request-a-pull
> >> and trying to simplify it.
> >>
> >> Do people still use scripts/create-pull-request and send-pull-request? I
> >> see some obsolete URLs in the first script, and mostly old commits to
> >> their code.
> > I use create-pull-request for all my series, so the scripts still do
> > work and are in at least in use here.
> >
> > But I send with git send-email directly.
>
>
> Good to know, thanks!
> So, we need to keep at least the first one. I'll send a patch to it then.
>
> I'm not saying we should keep documenting them though ;-)

Agreed!

Bruce

>
> Thanks
> Michael.
>
> --
> Michael Opdenacker, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
>


-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

Re: [docs] Keep scripts/create-pull-request and send-pull-request ?

[Frédéric Martinsons]

[-- Attachment #1: Type: text/plain, Size: 1980 bytes --]

Le jeu. 10 août 2023, 16:09, Bruce Ashfield <bruce.ashfield@gmail.com> a
écrit :

> On Thu, Aug 10, 2023 at 10:04 AM Michael Opdenacker via
> lists.yoctoproject.org
> <michael.opdenacker=bootlin.com@lists.yoctoproject.org> wrote:
> >
> > Greetings,
> >
> > I'm reviewing
> >
> https://docs.yoctoproject.org/next/contributor-guide/submit-change.html#using-scripts-to-push-a-change-upstream-and-request-a-pull
> > and trying to simplify it.
> >
> > Do people still use scripts/create-pull-request and send-pull-request? I
> > see some obsolete URLs in the first script, and mostly old commits to
> > their code.
>
> I use create-pull-request for all my series, so the scripts still do
> work and are in at least in use here.
>
> But I send with git send-email directly.
>


Same here, I use the both scripts for patch series but I can perfectly use
git tools directly with some documentations (or if I opened those scripts)


>
> Bruce
>
> >
> > I'm also asking because I'm wondering whether it's better to document
> > how to create and send pull requests from standard git tools. This way,
> > people also learn how to submit pull requests to other upstreams.
> >
> > What do you think?
> >
> > Thanks in advance
> > Michael.
> >
> > --
> > Michael Opdenacker, Bootlin
> > Embedded Linux and Kernel engineering
> > https://bootlin.com
> >
> >
> >
> >
>
>
> --
> - Thou shalt not follow the NULL pointer, for chaos and madness await
> thee at its end
> - "Use the force Harry" - Gandalf, Star Trek II
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#4136):
> https://lists.yoctoproject.org/g/docs/message/4136
> Mute This Topic: https://lists.yoctoproject.org/mt/100663723/6213388
> Group Owner: docs+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/docs/unsub [
> frederic.martinsons@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>

[-- Attachment #2: Type: text/html, Size: 3679 bytes --]

Re: [OE-core] Keep scripts/create-pull-request and send-pull-request ?

[Michael Opdenacker]

Hello,

On 10.08.23 at 16:18, Cliff Brake wrote:
> On 8/10/23 10:04, Michael Opdenacker via lists.openembedded.org wrote:
>> I'm wondering whether it's better to document how to create and send 
>> pull requests from standard git tools.
>
> +1
>
> Cliff


All things considered, since scripts/create-pull-request is still in 
use, in particular by Steve and Bruce, I'm leaning towards documenting 
both variants:

  * Creating a simple pull request using the standard git tools, as
    several of us are doing. Richard doesn't seem to mind. At least in
    my case, this applies to changes I previously submitted through the
    lists.
  * Creating a more elaborate pull request from a branch containing
    commits that haven't been shared yet, typically like what Steve
    does. This way, people can review each patch individually by e-mail.

Unless we want to standardize our pull requests, and make sure each 
commit is submitted (sometimes once again) as a separate patch. In that 
case, we'd only document the use of scripts/create-pull-request.

Cheers
Michael.

-- 
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [docs] [OE-core] Keep scripts/create-pull-request and send-pull-request ?

[Alexander Kanavin]

On Thu, 10 Aug 2023 at 18:36, Michael Opdenacker via
lists.yoctoproject.org
<michael.opdenacker=bootlin.com@lists.yoctoproject.org> wrote:
> All things considered, since scripts/create-pull-request is still in
> use, in particular by Steve and Bruce, I'm leaning towards documenting
> both variants:
>
>   * Creating a simple pull request using the standard git tools, as
>     several of us are doing. Richard doesn't seem to mind. At least in
>     my case, this applies to changes I previously submitted through the
>     lists.
>   * Creating a more elaborate pull request from a branch containing
>     commits that haven't been shared yet, typically like what Steve
>     does. This way, people can review each patch individually by e-mail.
>
> Unless we want to standardize our pull requests, and make sure each
> commit is submitted (sometimes once again) as a separate patch. In that
> case, we'd only document the use of scripts/create-pull-request.

FWIW, I haven't used either tool for years, and I do send large
patchsets. Standard git tooling is fully adequate, except for
management of cover letters which I'd like to get help with.

Alex