From: "Jingoo Han" <jingoohan1@gmail.com>
To: "'Dongdong Liu'" <liudongdong3@huawei.com>,
"'Khuong Dinh'" <kdinh@apm.com>,
"'Jon Masters'" <jcm@jonmasters.org>,
"'Lorenzo Pieralisi'" <lorenzo.pieralisi@arm.com>,
<linux-pci@vger.kernel.org>
Cc: 'Pratyush Anand' <pratyush.anand@gmail.com>,
'Gabriele Paoloni' <gabriele.paoloni@huawei.com>,
'Catalin Marinas' <catalin.marinas@arm.com>,
'Shawn Lin' <shawn.lin@rock-chips.com>,
'Will Deacon' <will.deacon@arm.com>,
'Linuxarm' <linuxarm@huawei.com>,
'Michal Simek' <michal.simek@xilinx.com>,
'Thierry Reding' <thierry.reding@gmail.com>,
'Tanmay Inamdar' <tinamdar@apm.com>,
'Zhou Wang' <wangzhou1@hisilicon.com>,
'Joao Pinto' <Joao.Pinto@synopsys.com>,
'Jonathan Corbet' <corbet@lwn.net>,
'Wenrui Li' <wenrui.li@rock-chips.com>,
'Russell King' <linux@armlinux.org.uk>,
'Bharat Kumar Gogada' <bharat.kumar.gogada@xilinx.com>,
'Murali Karicheri' <m-karicheri2@ti.com>,
'Benjamin Herrenschmidt' <benh@kernel.crashing.org>,
'Arnd Bergmann' <arnd@arndb.de>,
'Jon Mason' <jonmason@broadcom.com>,
'Ray Jui' <rjui@broadcom.com>,
'John Garry' <john.garry@huawei.com>,
'Bjorn Helgaas' <bhelgaas@google.com>,
'Mingkai Hu' <mingkai.hu@freescale.com>,
linux-arm-kernel@lists.infradead.org,
'Thomas Petazzoni' <thomas.petazzoni@free-electrons.com>,
linux-kernel@vger.kernel.org,
'Stanimir Varbanov' <svarbanov@mm-sol.com>,
'Minghuan Lian' <minghuan.Lian@freescale.com>,
"'Luis R . Rodriguez'" <mcgrof@kernel.org>,
'Roy Zang' <tie-fei.zang@freescale.com>
Subject: Re: [PATCH v4 00/21] PCI: fix config space memory mappings
Date: Wed, 26 Apr 2017 13:24:48 -0400 [thread overview]
Message-ID: <000501d2beb2$023b9100$06b2b300$@gmail.com> (raw)
In-Reply-To: <361fde15-5ba3-d33b-f946-003e89ba071f@huawei.com>
T24gV2VkbmVzZGF5LCBBcHJpbCAyNiwgMjAxNyA2OjU0IEFNLCBEb25nZG9uZyBMaXUgd3JvdGU7
Cj4gCj4gVGVzdGVkLWJ5OiBEb25nZG9uZyBMaXUgPGxpdWRvbmdkb25nM0BodWF3ZWkuY29tPgo+
IAo+IEkgdGVzdGVkIHRoZSBwYXRjaHNldCBvbiBIaVNpbGljb24gQVJNNjQgRDA1IGJvYXJkLkl0
IHdvcmtzIG9rIHdpdGggODI1OTkKPiBuZXRjYXJkLgoKVGhhbmsgeW91IGZvciB0ZXN0aW5nIHRo
ZXNlIHBhdGNoZXMuIEhpU2lsaWNvbiBQQ0llIG1heSB1c2UgRGVzaWdud2FyZS1iYXNlZApQQ0ll
IGNvbnRyb2xsZXIuIEluIG15IG9waW5pb24sIG90aGVyIERlc2lnbndhcmUtYmFzZWQgUENJZSBj
b250cm9sbGVyIHdpbGwKd29yayBwcm9wZXJseS4KClRvIERvbmdkb25nIExpdSwgS2h1b25nIERp
bmgsIGFuZCBvdGhlciBwZW9wbGUsCklmIHBvc3NpYmxlLCBjYW4geW91IGNoZWNrIHRoZSBvdXRw
dXQgb2YgJ2xzcGNpIC12Jz8KSWYgeW91IGZpbmQgc29tZXRoaW5nIGRpZmZlcmVudCwgcGxlYXNl
IHNoYXJlIGl0IHdpdGggdXMuCkdvb2QgbHVjay4KCkJlc3QgcmVnYXJkcywKSmluZ29vIEhhbgoK
PiAKPiBUaGFua3MsCj4gRG9uZ2RvbmcKPiDlnKggMjAxNy80LzI1IDE0OjQwLCBKb24gTWFzdGVy
cyDlhpnpgZM6Cj4gPiBPbiAwNC8xOS8yMDE3IDEyOjQ4IFBNLCBMb3JlbnpvIFBpZXJhbGlzaSB3
cm90ZToKPiA+Cj4gPj4gT24gc29tZSBwbGF0Zm9ybXMgKGllIEFSTS9BUk02NCkgaW9yZW1hcCBm
YWlscyB0byBjb21wbHkgd2l0aCB0aGUgUENJCj4gPj4gY29uZmlndXJhdGlvbiBub24tcG9zdGVk
IHdyaXRlIHRyYW5zYWN0aW9ucyByZXF1aXJlbWVudCwgYmVjYXVzZSBpdAo+ID4+IHByb3ZpZGVz
IGEgbWVtb3J5IG1hcHBpbmcgdGhhdCBpc3N1ZXMgImJ1ZmZlcmFibGUiIG9yLCBpbiBQQ0kgdGVy
bXMKPiA+PiAicG9zdGVkIiB3cml0ZSB0cmFuc2FjdGlvbnMuIExpa2V3aXNlLCB0aGUgY3VycmVu
dCBwY2lfcmVtYXBfaW9zcGFjZSgpCj4gPj4gaW1wbGVtZW50YXRpb24gbWFwcyB0aGUgcGh5c2lj
YWwgYWRkcmVzcyByYW5nZSB0aGF0IHRoZSBQQ0kgdHJhbnNsYXRlcwo+ID4+IHRvIEkvTyBzcGFj
ZSBjeWNsZXMgdG8gdmlydHVhbCBhZGRyZXNzIHNwYWNlIHRocm91Z2ggcGdwcm90X2RldmljZSgp
Cj4gPj4gYXR0cmlidXRlcyB0aGF0IG9uIGVnIEFSTTY0IHByb3ZpZGVzIGEgbWVtb3J5IG1hcHBp
bmcgaXNzdWluZwo+ID4+IHBvc3RlZCB3cml0ZXMgdHJhbnNhY3Rpb25zLCB3aGljaCBpcyBub3Qg
UENJIHNwZWNpZmljYXRpb25zIGNvbXBsaWFudC4KPiA+Cj4gPiBTaWRlIG5vdGUgdGhhdCBJJ3Zl
IHBpbmdlZCBhbGwgb2YgdGhlIEFSTSBzZXJ2ZXIgdmVuZG9ycyBhbmQgYXNrZWQgdGhlbQo+ID4g
dG8gdmVyaWZ5IHRoaXMgcGF0Y2ggc2VyaWVzIG9uIHRoZWlyIHBsYXRmb3Jtcy4KPiA+Cj4gPiBK
b24uCj4gPgo+ID4gLgo+ID4KCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVs
QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9s
aXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==
WARNING: multiple messages have this Message-ID (diff)
From: jingoohan1@gmail.com (Jingoo Han)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 00/21] PCI: fix config space memory mappings
Date: Wed, 26 Apr 2017 13:24:48 -0400 [thread overview]
Message-ID: <000501d2beb2$023b9100$06b2b300$@gmail.com> (raw)
In-Reply-To: <361fde15-5ba3-d33b-f946-003e89ba071f@huawei.com>
On Wednesday, April 26, 2017 6:54 AM, Dongdong Liu wrote;
>
> Tested-by: Dongdong Liu <liudongdong3@huawei.com>
>
> I tested the patchset on HiSilicon ARM64 D05 board.It works ok with 82599
> netcard.
Thank you for testing these patches. HiSilicon PCIe may use Designware-based
PCIe controller. In my opinion, other Designware-based PCIe controller will
work properly.
To Dongdong Liu, Khuong Dinh, and other people,
If possible, can you check the output of 'lspci -v'?
If you find something different, please share it with us.
Good luck.
Best regards,
Jingoo Han
>
> Thanks,
> Dongdong
> ? 2017/4/25 14:40, Jon Masters ??:
> > On 04/19/2017 12:48 PM, Lorenzo Pieralisi wrote:
> >
> >> On some platforms (ie ARM/ARM64) ioremap fails to comply with the PCI
> >> configuration non-posted write transactions requirement, because it
> >> provides a memory mapping that issues "bufferable" or, in PCI terms
> >> "posted" write transactions. Likewise, the current pci_remap_iospace()
> >> implementation maps the physical address range that the PCI translates
> >> to I/O space cycles to virtual address space through pgprot_device()
> >> attributes that on eg ARM64 provides a memory mapping issuing
> >> posted writes transactions, which is not PCI specifications compliant.
> >
> > Side note that I've pinged all of the ARM server vendors and asked them
> > to verify this patch series on their platforms.
> >
> > Jon.
> >
> > .
> >
WARNING: multiple messages have this Message-ID (diff)
From: "Jingoo Han" <jingoohan1@gmail.com>
To: "'Dongdong Liu'" <liudongdong3@huawei.com>,
"'Khuong Dinh'" <kdinh@apm.com>,
"'Jon Masters'" <jcm@jonmasters.org>,
"'Lorenzo Pieralisi'" <lorenzo.pieralisi@arm.com>,
<linux-pci@vger.kernel.org>
Cc: <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
"'Pratyush Anand'" <pratyush.anand@gmail.com>,
"'Arnd Bergmann'" <arnd@arndb.de>,
"'Jonathan Corbet'" <corbet@lwn.net>,
"'Will Deacon'" <will.deacon@arm.com>,
"'Bjorn Helgaas'" <bhelgaas@google.com>,
"'Mingkai Hu'" <mingkai.hu@freescale.com>,
"'Tanmay Inamdar'" <tinamdar@apm.com>,
"'Murali Karicheri'" <m-karicheri2@ti.com>,
"'Russell King'" <linux@armlinux.org.uk>,
"'Bharat Kumar Gogada'" <bharat.kumar.gogada@xilinx.com>,
"'Ray Jui'" <rjui@broadcom.com>,
"'Wenrui Li'" <wenrui.li@rock-chips.com>,
"'Shawn Lin'" <shawn.lin@rock-chips.com>,
"'Minghuan Lian'" <minghuan.Lian@freescale.com>,
"'Catalin Marinas'" <catalin.marinas@arm.com>,
"'Jon Mason'" <jonmason@broadcom.com>,
"'Gabriele Paoloni'" <gabriele.paoloni@huawei.com>,
"'Thomas Petazzoni'" <thomas.petazzoni@free-electrons.com>,
"'Joao Pinto'" <Joao.Pinto@synopsys.com>,
"'Thierry Reding'" <thierry.reding@gmail.com>,
"'Luis R . Rodriguez'" <mcgrof@kernel.org>,
"'Michal Simek'" <michal.simek@xilinx.com>,
"'Stanimir Varbanov'" <svarbanov@mm-sol.com>,
"'Zhou Wang'" <wangzhou1@hisilicon.com>,
"'Roy Zang'" <tie-fei.zang@freescale.com>,
"'Benjamin Herrenschmidt'" <benh@kernel.crashing.org>,
"'John Garry'" <john.garry@huawei.com>,
"'Linuxarm'" <linuxarm@huawei.com>
Subject: Re: [PATCH v4 00/21] PCI: fix config space memory mappings
Date: Wed, 26 Apr 2017 13:24:48 -0400 [thread overview]
Message-ID: <000501d2beb2$023b9100$06b2b300$@gmail.com> (raw)
In-Reply-To: <361fde15-5ba3-d33b-f946-003e89ba071f@huawei.com>
On Wednesday, April 26, 2017 6:54 AM, Dongdong Liu wrote;
>
> Tested-by: Dongdong Liu <liudongdong3@huawei.com>
>
> I tested the patchset on HiSilicon ARM64 D05 board.It works ok with 82599
> netcard.
Thank you for testing these patches. HiSilicon PCIe may use Designware-based
PCIe controller. In my opinion, other Designware-based PCIe controller will
work properly.
To Dongdong Liu, Khuong Dinh, and other people,
If possible, can you check the output of 'lspci -v'?
If you find something different, please share it with us.
Good luck.
Best regards,
Jingoo Han
>
> Thanks,
> Dongdong
> 在 2017/4/25 14:40, Jon Masters 写道:
> > On 04/19/2017 12:48 PM, Lorenzo Pieralisi wrote:
> >
> >> On some platforms (ie ARM/ARM64) ioremap fails to comply with the PCI
> >> configuration non-posted write transactions requirement, because it
> >> provides a memory mapping that issues "bufferable" or, in PCI terms
> >> "posted" write transactions. Likewise, the current pci_remap_iospace()
> >> implementation maps the physical address range that the PCI translates
> >> to I/O space cycles to virtual address space through pgprot_device()
> >> attributes that on eg ARM64 provides a memory mapping issuing
> >> posted writes transactions, which is not PCI specifications compliant.
> >
> > Side note that I've pinged all of the ARM server vendors and asked them
> > to verify this patch series on their platforms.
> >
> > Jon.
> >
> > .
> >
next prev parent reply other threads:[~2017-04-26 17:24 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-19 16:48 [PATCH v4 00/21] PCI: fix config space memory mappings Lorenzo Pieralisi
2017-04-19 16:48 ` Lorenzo Pieralisi
2017-04-19 16:48 ` Lorenzo Pieralisi
2017-04-19 16:48 ` [PATCH v4 01/21] PCI: remove __weak tag from pci_remap_iospace() Lorenzo Pieralisi
2017-04-19 16:48 ` Lorenzo Pieralisi
2017-04-19 16:48 ` Lorenzo Pieralisi
2017-04-19 16:48 ` [PATCH v4 02/21] linux/io.h: add PCI config space remap interface Lorenzo Pieralisi
2017-04-19 16:48 ` Lorenzo Pieralisi
2017-04-19 16:48 ` Lorenzo Pieralisi
2017-04-20 10:51 ` Lorenzo Pieralisi
2017-04-20 10:51 ` Lorenzo Pieralisi
2017-04-20 10:51 ` Lorenzo Pieralisi
2017-04-20 13:12 ` Bjorn Helgaas
2017-04-20 13:12 ` Bjorn Helgaas
2017-04-20 13:12 ` Bjorn Helgaas
2017-04-19 16:48 ` [PATCH v4 03/21] ARM64: implement pci_remap_cfgspace() interface Lorenzo Pieralisi
2017-04-19 16:48 ` Lorenzo Pieralisi
2017-04-20 10:33 ` Catalin Marinas
2017-04-20 10:33 ` Catalin Marinas
2017-04-20 10:33 ` Catalin Marinas
2017-04-19 16:48 ` [PATCH v4 04/21] ARM: " Lorenzo Pieralisi
2017-04-19 16:48 ` Lorenzo Pieralisi
2017-04-19 16:48 ` [PATCH v4 05/21] lib: fix Devres devm_ioremap_* offset parameter kerneldoc description Lorenzo Pieralisi
2017-04-19 16:48 ` Lorenzo Pieralisi
2017-04-19 16:48 ` Lorenzo Pieralisi
2017-04-28 21:20 ` Tejun Heo
2017-04-28 21:20 ` Tejun Heo
2017-04-28 21:20 ` Tejun Heo
2017-04-19 16:48 ` [PATCH v4 06/21] PCI: implement Devres interface to map PCI config space Lorenzo Pieralisi
2017-04-19 16:48 ` Lorenzo Pieralisi
2017-04-19 16:48 ` Lorenzo Pieralisi
2017-04-19 16:48 ` [PATCH v4 07/21] PCI: ECAM: use pci_remap_cfgspace() to map config region Lorenzo Pieralisi
2017-04-19 16:48 ` Lorenzo Pieralisi
2017-04-19 16:48 ` [PATCH v4 08/21] PCI: xilinx: update PCI config space remap function Lorenzo Pieralisi
2017-04-19 16:48 ` Lorenzo Pieralisi
2017-04-19 16:48 ` [PATCH v4 09/21] PCI: xilinx-nwl: " Lorenzo Pieralisi
2017-04-19 16:48 ` Lorenzo Pieralisi
2017-04-19 16:48 ` [PATCH v4 10/21] PCI: spear13xx: " Lorenzo Pieralisi
2017-04-19 16:48 ` Lorenzo Pieralisi
2017-04-19 16:48 ` Lorenzo Pieralisi
2017-04-19 16:49 ` [PATCH v4 11/21] PCI: rockchip: " Lorenzo Pieralisi
2017-04-19 16:49 ` Lorenzo Pieralisi
2017-04-19 16:49 ` [PATCH v4 12/21] PCI: qcom: " Lorenzo Pieralisi
2017-04-19 16:49 ` Lorenzo Pieralisi
2017-04-19 16:49 ` [PATCH v4 13/21] PCI: iproc-platform: " Lorenzo Pieralisi
2017-04-19 16:49 ` Lorenzo Pieralisi
2017-04-19 16:49 ` Lorenzo Pieralisi
2017-04-19 16:49 ` [PATCH v4 14/21] PCI: designware: " Lorenzo Pieralisi
2017-04-19 16:49 ` Lorenzo Pieralisi
2017-04-21 22:02 ` Jingoo Han
2017-04-21 22:02 ` Jingoo Han
2017-04-21 22:02 ` Jingoo Han
2017-04-19 16:49 ` [PATCH v4 15/21] PCI: armada8k: " Lorenzo Pieralisi
2017-04-19 16:49 ` Lorenzo Pieralisi
2017-04-19 16:49 ` Lorenzo Pieralisi
2017-04-19 16:49 ` [PATCH v4 16/21] PCI: xgene: " Lorenzo Pieralisi
2017-04-19 16:49 ` Lorenzo Pieralisi
2017-04-19 16:49 ` [PATCH v4 17/21] PCI: tegra: " Lorenzo Pieralisi
2017-04-19 16:49 ` Lorenzo Pieralisi
2017-04-19 16:49 ` [PATCH v4 18/21] PCI: hisi: " Lorenzo Pieralisi
2017-04-19 16:49 ` Lorenzo Pieralisi
2017-04-19 16:49 ` [PATCH v4 19/21] PCI: layerscape: " Lorenzo Pieralisi
2017-04-19 16:49 ` Lorenzo Pieralisi
2017-04-19 16:49 ` [PATCH v4 20/21] PCI: keystone-dw: " Lorenzo Pieralisi
2017-04-19 16:49 ` Lorenzo Pieralisi
2017-04-19 16:49 ` Lorenzo Pieralisi
2017-04-19 16:49 ` [PATCH v4 21/21] PCI: versatile: " Lorenzo Pieralisi
2017-04-19 16:49 ` Lorenzo Pieralisi
2017-04-20 13:25 ` [PATCH v4 00/21] PCI: fix config space memory mappings Bjorn Helgaas
2017-04-20 13:25 ` Bjorn Helgaas
2017-04-20 13:25 ` Bjorn Helgaas
2017-04-25 6:40 ` Jon Masters
2017-04-25 6:40 ` Jon Masters
2017-04-25 6:40 ` Jon Masters
2017-04-25 16:20 ` Jingoo Han
2017-04-25 16:20 ` Jingoo Han
2017-04-25 16:20 ` Jingoo Han
2017-04-25 18:31 ` Khuong Dinh
2017-04-25 18:31 ` Khuong Dinh
2017-04-26 10:53 ` Dongdong Liu
2017-04-26 10:53 ` Dongdong Liu
2017-04-26 10:53 ` Dongdong Liu
2017-04-26 17:24 ` Jingoo Han [this message]
2017-04-26 17:24 ` Jingoo Han
2017-04-26 17:24 ` Jingoo Han
2017-04-27 1:46 ` Dongdong Liu
2017-04-27 1:46 ` Dongdong Liu
2017-04-27 1:46 ` Dongdong Liu
2017-04-27 16:42 ` Khuong Dinh
2017-04-27 16:42 ` Khuong Dinh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000501d2beb2$023b9100$06b2b300$@gmail.com' \
--to=jingoohan1@gmail.com \
--cc=Joao.Pinto@synopsys.com \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=bharat.kumar.gogada@xilinx.com \
--cc=bhelgaas@google.com \
--cc=catalin.marinas@arm.com \
--cc=corbet@lwn.net \
--cc=gabriele.paoloni@huawei.com \
--cc=jcm@jonmasters.org \
--cc=john.garry@huawei.com \
--cc=jonmason@broadcom.com \
--cc=kdinh@apm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linuxarm@huawei.com \
--cc=liudongdong3@huawei.com \
--cc=lorenzo.pieralisi@arm.com \
--cc=m-karicheri2@ti.com \
--cc=mcgrof@kernel.org \
--cc=michal.simek@xilinx.com \
--cc=minghuan.Lian@freescale.com \
--cc=mingkai.hu@freescale.com \
--cc=pratyush.anand@gmail.com \
--cc=rjui@broadcom.com \
--cc=shawn.lin@rock-chips.com \
--cc=svarbanov@mm-sol.com \
--cc=thierry.reding@gmail.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=tie-fei.zang@freescale.com \
--cc=tinamdar@apm.com \
--cc=wangzhou1@hisilicon.com \
--cc=wenrui.li@rock-chips.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.