From: Matthew Rosato <mjrosato@linux.ibm.com>
To: Zhuoying Cai <zycai@linux.ibm.com>,
qemu-devel@nongnu.org, qemu-s390x@nongnu.org
Cc: mst@redhat.com, jrossi@linux.ibm.com, borntraeger@linux.ibm.com,
jjherne@linux.ibm.com, cohuck@redhat.com, farman@linux.ibm.com,
pasic@linux.ibm.com, farosas@suse.de, lvivier@redhat.com,
pbonzini@redhat.com
Subject: Re: [PATCH v1 3/7] pc-bios/s390-ccw: Introduce virtio_tswap helpers
Date: Wed, 26 Aug 2026 13:44:29 -0400 [thread overview]
Message-ID: <085b7ab3-a8a0-4170-8a35-bd1a723c8f02@linux.ibm.com> (raw)
In-Reply-To: <20260818205324.580199-4-zycai@linux.ibm.com>
On 8/18/26 4:53 PM, Zhuoying Cai wrote:
> Replace the repeated pattern:
>
> be_ipl() ? x : bswapN(x)
>
> with helpers that conditionally byte-swap based on the virtio transport
> endianness.
>
Maybe worth a mention that while the 16 variant is used immediately, the
32 and 64 variants are setup for later use -- since they will
technically be dead code at this point in git history.
Otherwise:
Reviewed-by: Matthew Rosato <mjrosato@linux.ibm.com>
next prev parent reply other threads:[~2026-08-26 17:44 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-18 20:53 [PATCH v1 0/7] s390x: Add support for virtio-net-pci boot device Zhuoying Cai
2026-08-18 20:53 ` [PATCH v1 1/7] pc-bios/s390-ccw: Split virtio-ccw and generic virtio net Zhuoying Cai
2026-08-26 16:26 ` Jason J. Herne
2026-08-26 17:33 ` Matthew Rosato
2026-08-26 19:30 ` Jared Rossi
2026-08-26 19:41 ` Matthew Rosato
2026-08-26 20:23 ` Jared Rossi
2026-08-26 20:49 ` Matthew Rosato
2026-08-31 17:17 ` Zhuoying Cai
2026-08-18 20:53 ` [PATCH v1 2/7] pc-bios/s390-ccw: Add dynamic net header size handling Zhuoying Cai
2026-08-26 17:01 ` Jason J. Herne
2026-08-26 17:34 ` Matthew Rosato
2026-08-18 20:53 ` [PATCH v1 3/7] pc-bios/s390-ccw: Introduce virtio_tswap helpers Zhuoying Cai
2026-08-26 17:20 ` Jason J. Herne
2026-08-26 17:44 ` Matthew Rosato [this message]
2026-08-18 20:53 ` [PATCH v1 4/7] pc-bios/s390-ccw: Add support for virtio-net-pci IPL Zhuoying Cai
2026-08-26 14:31 ` Zhuoying Cai
2026-08-26 16:44 ` Jared Rossi
2026-08-31 18:36 ` Zhuoying Cai
2026-09-02 10:12 ` Eric Farman
2026-08-28 16:51 ` Jason J. Herne
2026-08-18 20:53 ` [PATCH v1 5/7] hw/virtio: Add "loadparm" property to virtio net PCI devices booting on s390x Zhuoying Cai
2026-08-28 17:00 ` Jason J. Herne
2026-08-18 20:53 ` [PATCH v1 6/7] tests/qtest: Add s390x virtio net PCI test to pxe-test.c Zhuoying Cai
2026-08-26 18:28 ` Joshua Daley
2026-08-18 20:53 ` [PATCH v1 7/7] tests/functional/s390x: Add tests for virtio net PCI in test_pxelinux.py Zhuoying Cai
2026-08-26 18:17 ` Joshua Daley
2026-08-26 18:22 ` Joshua Daley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=085b7ab3-a8a0-4170-8a35-bd1a723c8f02@linux.ibm.com \
--to=mjrosato@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=farman@linux.ibm.com \
--cc=farosas@suse.de \
--cc=jjherne@linux.ibm.com \
--cc=jrossi@linux.ibm.com \
--cc=lvivier@redhat.com \
--cc=mst@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=zycai@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.