Re: [PATCH v1 5/7] hw/virtio: Add "loadparm" property to virtio net PCI devices booting on s390x

["Jason J. Herne" <jjherne@linux.ibm.com>]

On 8/18/26 4:53 PM, Zhuoying Cai wrote:
> s390x PCI IPL devices require a "loadparm" property. Add it to virtio-net-pci
> to support booting from it on s390x.
> 
> Signed-off-by: Zhuoying Cai <zycai@linux.ibm.com>
> ---
>   hw/virtio/virtio-net-pci.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/hw/virtio/virtio-net-pci.c b/hw/virtio/virtio-net-pci.c
> index fd3e0303f5..893d1905a9 100644
> --- a/hw/virtio/virtio-net-pci.c
> +++ b/hw/virtio/virtio-net-pci.c
> @@ -77,6 +77,7 @@ static void virtio_net_pci_class_init(ObjectClass *klass, const void *data)
>       k->sriov_vf_user_creatable = true;
>       set_bit(DEVICE_CATEGORY_NETWORK, dc->categories);
>       device_class_set_props(dc, virtio_net_properties);
> +    pci_qdev_property_add_specifics(dc);
>       vpciklass->realize = virtio_net_pci_realize;
>   }
>   

Should this patch be integrated into the last patch? If pci netboot 
breaks without it, then the answer is likely yes.

If, however, loadparm is not required (I suspect this to be the case), 
then the commit message should be changed as it implies that pci netboot 
will fail without a valid loadparm:

Add optional loadparm property to virtio-net-pci to allow boot entry 
selection on s390x, consistent with virtio-blk-pci.