From: Eric Farman <farman@linux.ibm.com>
To: Zhuoying Cai <zycai@linux.ibm.com>,
Jared Rossi <jrossi@linux.ibm.com>,
qemu-devel@nongnu.org, qemu-s390x@nongnu.org
Cc: mst@redhat.com, borntraeger@linux.ibm.com, jjherne@linux.ibm.com,
cohuck@redhat.com, mjrosato@linux.ibm.com, pasic@linux.ibm.com,
farosas@suse.de, lvivier@redhat.com, pbonzini@redhat.com
Subject: Re: [PATCH v1 4/7] pc-bios/s390-ccw: Add support for virtio-net-pci IPL
Date: Wed, 2 Sep 2026 06:12:27 -0400 [thread overview]
Message-ID: <be81c658-56a7-4383-bf5f-06401da84d4c@linux.ibm.com> (raw)
In-Reply-To: <bbbdc3cd-9389-4c32-a9d7-0e1c9336841a@linux.ibm.com>
On 8/31/26 2:36 PM, Zhuoying Cai wrote:
> One thing worth noting is that virtio_net_init() calls virtio_*_setup(),
> which performs virtio_is_supported() as its first step. However, the
> return value of virtio_*_setup() is currently ignored in
> virtio_net_init(). This is pre-existing behavior and applies to both the
> CCW and PCI paths. If setup fails, execution still proceeds to MAC
> negotiation and buffer allocation.
>
> Since we are removing the network-specific setup from the PCI path,
> would it make sense to also fix virtio_net_init() to check and propagate
> the return value of virtio_*_setup()? The error is already reported by
> virtio_*_setup(), but execution currently continues into MAC negotiation
> and buffer allocation even when device initialization has failed.
Yes, I would recommend making that change here as well, just as Jared is
doing in the virtio-scsi path.
next prev parent reply other threads:[~2026-09-02 10:12 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-18 20:53 [PATCH v1 0/7] s390x: Add support for virtio-net-pci boot device Zhuoying Cai
2026-08-18 20:53 ` [PATCH v1 1/7] pc-bios/s390-ccw: Split virtio-ccw and generic virtio net Zhuoying Cai
2026-08-26 16:26 ` Jason J. Herne
2026-08-26 17:33 ` Matthew Rosato
2026-08-26 19:30 ` Jared Rossi
2026-08-26 19:41 ` Matthew Rosato
2026-08-26 20:23 ` Jared Rossi
2026-08-26 20:49 ` Matthew Rosato
2026-08-31 17:17 ` Zhuoying Cai
2026-08-18 20:53 ` [PATCH v1 2/7] pc-bios/s390-ccw: Add dynamic net header size handling Zhuoying Cai
2026-08-26 17:01 ` Jason J. Herne
2026-08-26 17:34 ` Matthew Rosato
2026-08-18 20:53 ` [PATCH v1 3/7] pc-bios/s390-ccw: Introduce virtio_tswap helpers Zhuoying Cai
2026-08-26 17:20 ` Jason J. Herne
2026-08-26 17:44 ` Matthew Rosato
2026-08-18 20:53 ` [PATCH v1 4/7] pc-bios/s390-ccw: Add support for virtio-net-pci IPL Zhuoying Cai
2026-08-26 14:31 ` Zhuoying Cai
2026-08-26 16:44 ` Jared Rossi
2026-08-31 18:36 ` Zhuoying Cai
2026-09-02 10:12 ` Eric Farman [this message]
2026-08-28 16:51 ` Jason J. Herne
2026-08-18 20:53 ` [PATCH v1 5/7] hw/virtio: Add "loadparm" property to virtio net PCI devices booting on s390x Zhuoying Cai
2026-08-28 17:00 ` Jason J. Herne
2026-08-18 20:53 ` [PATCH v1 6/7] tests/qtest: Add s390x virtio net PCI test to pxe-test.c Zhuoying Cai
2026-08-26 18:28 ` Joshua Daley
2026-08-18 20:53 ` [PATCH v1 7/7] tests/functional/s390x: Add tests for virtio net PCI in test_pxelinux.py Zhuoying Cai
2026-08-26 18:17 ` Joshua Daley
2026-08-26 18:22 ` Joshua Daley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be81c658-56a7-4383-bf5f-06401da84d4c@linux.ibm.com \
--to=farman@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=farosas@suse.de \
--cc=jjherne@linux.ibm.com \
--cc=jrossi@linux.ibm.com \
--cc=lvivier@redhat.com \
--cc=mjrosato@linux.ibm.com \
--cc=mst@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=zycai@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.