Re: [PATCH 1/7] clk: sunxi-ng: a523: add missing usb related clocks

From: Krzysztof Kozlowski <krzk@kernel.org>
To: iuncuim <iuncuim@gmail.com>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Samuel Holland <samuel@sholland.org>,
	Andre Przywara <andre.przywara@arm.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>, Vinod Koul <vkoul@kernel.org>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-phy@lists.infradead.org, linux-clk@vger.kernel.org,
	linux-sunxi@lists.linux.dev
Subject: Re: [PATCH 1/7] clk: sunxi-ng: a523: add missing usb related clocks
Date: Sat, 16 Aug 2025 11:30:01 +0200	[thread overview]
Message-ID: <0e149bdb-8830-42a2-927b-a489b4195015@kernel.org> (raw)
In-Reply-To: <20250816084700.569524-2-iuncuim@gmail.com>

On 16/08/2025 10:46, iuncuim wrote:
> From: Mikhail Kalashnikov <iuncuim@gmail.com>
> 
> Several clocks were omitted when adding the original driver. These clocks
> are necessary for USB 3.0 to work correctly. I added these declarations
> according to the driver's BSP code.
> 
> Signed-off-by: Mikhail Kalashnikov <iuncuim@gmail.com>
> ---
>  drivers/clk/sunxi-ng/ccu-sun55i-a523.c      | 32 +++++++++++++++++++++
>  drivers/clk/sunxi-ng/ccu-sun55i-a523.h      |  2 +-
>  include/dt-bindings/clock/sun55i-a523-ccu.h |  4 +++

Bindings should be a separate patch. Checkpatch should also suggest that.

Best regards,
Krzysztof