From: iuncuim <iuncuim@gmail.com>
To: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>,
Andre Przywara <andre.przywara@arm.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-phy@lists.infradead.org, linux-clk@vger.kernel.org,
linux-sunxi@lists.linux.dev
Subject: [PATCH 2/7] arm64: dts: allwinner: a523: add third usb2 phy
Date: Sat, 16 Aug 2025 16:46:55 +0800 [thread overview]
Message-ID: <20250816084700.569524-3-iuncuim@gmail.com> (raw)
In-Reply-To: <20250816084700.569524-1-iuncuim@gmail.com>
From: Mikhail Kalashnikov <iuncuim@gmail.com>
It seems that there are actually three usb2 phys in the processor, which
makes it incompatible with D1.
The third phy is used together with USB3/PCIe combophy with DWC3
controller. In the BSP code, the third PHY requires a separate glue
driver, but it seems that it is not needed.
According to the BSP code, the third phy does not have a reset line; the
only reset is declared in the DWC3 node, but none of this is documented.
Since sun4i-usb-phy driver requires a reset, I added RST_BUS_3 here.
Signed-off-by: Mikhail Kalashnikov <iuncuim@gmail.com>
---
.../arm64/boot/dts/allwinner/sun55i-a523.dtsi | 21 ++++++++++++-------
1 file changed, 13 insertions(+), 8 deletions(-)
diff --git a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
index 6b6f2296b..e4ed4fa82 100644
--- a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
@@ -503,22 +503,27 @@ usb_otg: usb@4100000 {
};
usbphy: phy@4100400 {
- compatible = "allwinner,sun55i-a523-usb-phy",
- "allwinner,sun20i-d1-usb-phy";
+ compatible = "allwinner,sun55i-a523-usb-phy";
reg = <0x4100400 0x100>,
<0x4101800 0x100>,
- <0x4200800 0x100>;
+ <0x4200800 0x100>,
+ <0x4e00000 0x100>;
reg-names = "phy_ctrl",
"pmu0",
- "pmu1";
+ "pmu1",
+ "pmu2";
clocks = <&osc24M>,
- <&osc24M>;
+ <&osc24M>,
+ <&ccu CLK_USB2>;
clock-names = "usb0_phy",
- "usb1_phy";
+ "usb1_phy",
+ "usb2_phy";
resets = <&ccu RST_USB_PHY0>,
- <&ccu RST_USB_PHY1>;
+ <&ccu RST_USB_PHY1>,
+ <&ccu RST_BUS_3>;
reset-names = "usb0_reset",
- "usb1_reset";
+ "usb1_reset",
+ "usb2_reset";
status = "disabled";
#phy-cells = <1>;
};
--
2.50.1
WARNING: multiple messages have this Message-ID (diff)
From: iuncuim <iuncuim@gmail.com>
To: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>,
Andre Przywara <andre.przywara@arm.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-phy@lists.infradead.org, linux-clk@vger.kernel.org,
linux-sunxi@lists.linux.dev
Subject: [PATCH 2/7] arm64: dts: allwinner: a523: add third usb2 phy
Date: Sat, 16 Aug 2025 16:46:55 +0800 [thread overview]
Message-ID: <20250816084700.569524-3-iuncuim@gmail.com> (raw)
In-Reply-To: <20250816084700.569524-1-iuncuim@gmail.com>
From: Mikhail Kalashnikov <iuncuim@gmail.com>
It seems that there are actually three usb2 phys in the processor, which
makes it incompatible with D1.
The third phy is used together with USB3/PCIe combophy with DWC3
controller. In the BSP code, the third PHY requires a separate glue
driver, but it seems that it is not needed.
According to the BSP code, the third phy does not have a reset line; the
only reset is declared in the DWC3 node, but none of this is documented.
Since sun4i-usb-phy driver requires a reset, I added RST_BUS_3 here.
Signed-off-by: Mikhail Kalashnikov <iuncuim@gmail.com>
---
.../arm64/boot/dts/allwinner/sun55i-a523.dtsi | 21 ++++++++++++-------
1 file changed, 13 insertions(+), 8 deletions(-)
diff --git a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
index 6b6f2296b..e4ed4fa82 100644
--- a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
@@ -503,22 +503,27 @@ usb_otg: usb@4100000 {
};
usbphy: phy@4100400 {
- compatible = "allwinner,sun55i-a523-usb-phy",
- "allwinner,sun20i-d1-usb-phy";
+ compatible = "allwinner,sun55i-a523-usb-phy";
reg = <0x4100400 0x100>,
<0x4101800 0x100>,
- <0x4200800 0x100>;
+ <0x4200800 0x100>,
+ <0x4e00000 0x100>;
reg-names = "phy_ctrl",
"pmu0",
- "pmu1";
+ "pmu1",
+ "pmu2";
clocks = <&osc24M>,
- <&osc24M>;
+ <&osc24M>,
+ <&ccu CLK_USB2>;
clock-names = "usb0_phy",
- "usb1_phy";
+ "usb1_phy",
+ "usb2_phy";
resets = <&ccu RST_USB_PHY0>,
- <&ccu RST_USB_PHY1>;
+ <&ccu RST_USB_PHY1>,
+ <&ccu RST_BUS_3>;
reset-names = "usb0_reset",
- "usb1_reset";
+ "usb1_reset",
+ "usb2_reset";
status = "disabled";
#phy-cells = <1>;
};
--
2.50.1
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2025-08-16 8:55 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-16 8:46 [PATCH 0/7] arm64: allwinner: a523: add USB3.0 support iuncuim
2025-08-16 8:46 ` iuncuim
2025-08-16 8:46 ` [PATCH 1/7] clk: sunxi-ng: a523: add missing usb related clocks iuncuim
2025-08-16 8:46 ` iuncuim
2025-08-16 9:30 ` Krzysztof Kozlowski
2025-08-16 9:30 ` Krzysztof Kozlowski
2025-08-16 8:46 ` iuncuim [this message]
2025-08-16 8:46 ` [PATCH 2/7] arm64: dts: allwinner: a523: add third usb2 phy iuncuim
2025-08-16 9:31 ` Krzysztof Kozlowski
2025-08-16 9:31 ` Krzysztof Kozlowski
2025-08-16 13:38 ` Andre Przywara
2025-08-16 13:38 ` Andre Przywara
2025-08-16 8:46 ` [PATCH 3/7] phy: sun4i-usb: a523: add support for the USB2 PHY iuncuim
2025-08-16 8:46 ` iuncuim
2025-08-16 13:31 ` Andre Przywara
2025-08-16 13:31 ` Andre Przywara
2025-08-16 8:46 ` [PATCH 4/7] phy: allwinner: a523: add USB3/PCIe PHY driver iuncuim
2025-08-16 8:46 ` iuncuim
2025-08-16 9:33 ` Krzysztof Kozlowski
2025-08-16 9:33 ` Krzysztof Kozlowski
2025-08-25 9:42 ` Philipp Zabel
2025-08-25 9:42 ` Philipp Zabel
2025-08-27 6:40 ` Chukun Pan
2025-08-27 6:40 ` Chukun Pan
2025-08-16 8:46 ` [PATCH 5/7] arm64: dts: allwinner: a523: add USB3.0 phy node iuncuim
2025-08-16 8:46 ` iuncuim
2025-08-16 9:32 ` Krzysztof Kozlowski
2025-08-16 9:32 ` Krzysztof Kozlowski
2025-08-16 13:49 ` Andre Przywara
2025-08-16 13:49 ` Andre Przywara
2025-08-25 15:41 ` Chen-Yu Tsai
2025-08-25 15:41 ` Chen-Yu Tsai
2025-08-16 8:46 ` [PATCH 6/7] arm64: dts: allwinner: a523: add DWC3 USB3.0 node iuncuim
2025-08-16 8:46 ` iuncuim
2025-08-16 14:10 ` Andre Przywara
2025-08-16 14:10 ` Andre Przywara
2025-08-16 8:47 ` [PATCH 7/7] arm64: dts: allwinner: a523: activate USB3 for all boards iuncuim
2025-08-16 8:47 ` iuncuim
2025-08-18 18:24 ` [PATCH 0/7] arm64: allwinner: a523: add USB3.0 support Rob Herring (Arm)
2025-08-18 18:24 ` Rob Herring (Arm)
-- strict thread matches above, loose matches on Subject: below --
2025-08-17 14:59 [PATCH 2/7] arm64: dts: allwinner: a523: add third usb2 phy kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250816084700.569524-3-iuncuim@gmail.com \
--to=iuncuim@gmail.com \
--cc=andre.przywara@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=samuel@sholland.org \
--cc=sboyd@kernel.org \
--cc=vkoul@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.