All of lore.kernel.org
 help / color / mirror / Atom feed
From: greg@kroah.com (Greg KH)
To: linux-kernel@vger.kernel.org, sensors@stimpy.netroedge.com
Subject: [PATCH] More i2c driver changes for 2.5.65
Date: Thu, 19 May 2005 06:23:50 +0000	[thread overview]
Message-ID: <10482950874081@kroah.com> (raw)
In-Reply-To: <1048295086886@kroah.com>
In-Reply-To: <1048295086481@kroah.com>

ChangeSet 1.1193, 2003/03/21 16:16:01-08:00, greg@kroah.com

i2c: Removed the name variable from i2c_client as the dev one should be used instead.


 drivers/i2c/chips/adm1021.c |    2 +-
 drivers/i2c/chips/lm75.c    |    2 +-
 drivers/i2c/i2c-core.c      |   14 +++++++-------
 drivers/i2c/i2c-dev.c       |    4 +++-
 include/linux/i2c.h         |    1 -
 5 files changed, 12 insertions(+), 11 deletions(-)


diff -Nru a/drivers/i2c/chips/adm1021.c b/drivers/i2c/chips/adm1021.c
--- a/drivers/i2c/chips/adm1021.c	Fri Mar 21 16:52:58 2003
+++ b/drivers/i2c/chips/adm1021.c	Fri Mar 21 16:52:58 2003
@@ -299,7 +299,7 @@
 	}
 
 	/* Fill in the remaining client fields and put it into the global list */
-	strcpy(new_client->name, client_name);
+	strncpy(new_client->dev.name, client_name, DEVICE_NAME_SIZE);
 	data->type = kind;
 
 	new_client->id = adm1021_id++;
diff -Nru a/drivers/i2c/chips/lm75.c b/drivers/i2c/chips/lm75.c
--- a/drivers/i2c/chips/lm75.c	Fri Mar 21 16:52:58 2003
+++ b/drivers/i2c/chips/lm75.c	Fri Mar 21 16:52:58 2003
@@ -180,7 +180,7 @@
 	}
 
 	/* Fill in the remaining client fields and put it into the global list */
-	strcpy(new_client->name, client_name);
+	strncpy(new_client->dev.name, client_name, DEVICE_NAME_SIZE);
 
 	new_client->id = lm75_id++;
 	data->valid = 0;
diff -Nru a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
--- a/drivers/i2c/i2c-core.c	Fri Mar 21 16:52:58 2003
+++ b/drivers/i2c/i2c-core.c	Fri Mar 21 16:52:58 2003
@@ -291,9 +291,9 @@
 				    client->driver = driver) {
 					DEB2(printk(KERN_DEBUG "i2c-core.o: "
 						    "detaching client %s:\n",
-					            client->name));
+					            client->dev.name));
 					if ((res = driver->detach_client(client))) {
- 						dev_err(&adap->dev, "while "
+						dev_err(&adap->dev, "while "
 						       "unregistering driver "
 						       "`%s', the client at "
 						       "address %02x of "
@@ -355,7 +355,7 @@
 
 	printk(KERN_WARNING 
 	       " i2c-core.o: attach_client(%s) - enlarge I2C_CLIENT_MAX.\n",
-	       client->name);
+	       client->dev.name);
 
  out_unlock_list:
 	up(&adapter->list);
@@ -374,7 +374,7 @@
 	}
 
 	DEB(dev_dbg(&adapter->dev, "client [%s] registered to adapter "
-			"(pos. %d).\n", client->name, i));
+			"(pos. %d).\n", client->dev.name, i));
 
 	if (client->flags & I2C_CLIENT_ALLOW_USE)
 		client->usage_count = 0;
@@ -395,7 +395,7 @@
 		if (res) {
 			printk(KERN_ERR
 			       "i2c-core.o: client_unregister [%s] failed, "
-			       "client not detached", client->name);
+			       "client not detached", client->dev.name);
 			goto out;
 		}
 	}
@@ -410,7 +410,7 @@
 
 	printk(KERN_WARNING
 	       " i2c-core.o: unregister_client [%s] not found\n",
-	       client->name);
+	       client->dev.name);
 	res = -ENODEV;
 
  out_unlock:
@@ -522,7 +522,7 @@
 				client = adapters[i]->clients[order[j]];
 				len += sprintf(kbuf+len,"%02x\t%-32s\t%-32s\n",
 				              client->addr,
-				              client->name,
+				              client->dev.name,
 				              client->driver->name);
 			}
 			len = len - file->f_pos;
diff -Nru a/drivers/i2c/i2c-dev.c b/drivers/i2c/i2c-dev.c
--- a/drivers/i2c/i2c-dev.c	Fri Mar 21 16:52:58 2003
+++ b/drivers/i2c/i2c-dev.c	Fri Mar 21 16:52:58 2003
@@ -86,7 +86,9 @@
 };
 
 static struct i2c_client i2cdev_client_template = {
-	.name		= "I2C /dev entry",
+	.dev		= {
+		.name	= "I2C /dev entry",
+	},
 	.id		= 1,
 	.addr		= -1,
 	.driver		= &i2cdev_driver,
diff -Nru a/include/linux/i2c.h b/include/linux/i2c.h
--- a/include/linux/i2c.h	Fri Mar 21 16:52:58 2003
+++ b/include/linux/i2c.h	Fri Mar 21 16:52:58 2003
@@ -156,7 +156,6 @@
  * function is mainly used for lookup & other admin. functions.
  */
 struct i2c_client {
-	char name[32];
 	int id;
 	unsigned int flags;		/* div., see below		*/
 	unsigned int addr;		/* chip address - NOTE: 7bit 	*/

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: linux-kernel@vger.kernel.org, sensors@stimpy.netroedge.com
Subject: Re: [PATCH] More i2c driver changes for 2.5.65
Date: Fri, 21 Mar 2003 17:04 -0800	[thread overview]
Message-ID: <10482950874081@kroah.com> (raw)
In-Reply-To: <1048295086886@kroah.com>

ChangeSet 1.1193, 2003/03/21 16:16:01-08:00, greg@kroah.com

i2c: Removed the name variable from i2c_client as the dev one should be used instead.


 drivers/i2c/chips/adm1021.c |    2 +-
 drivers/i2c/chips/lm75.c    |    2 +-
 drivers/i2c/i2c-core.c      |   14 +++++++-------
 drivers/i2c/i2c-dev.c       |    4 +++-
 include/linux/i2c.h         |    1 -
 5 files changed, 12 insertions(+), 11 deletions(-)


diff -Nru a/drivers/i2c/chips/adm1021.c b/drivers/i2c/chips/adm1021.c
--- a/drivers/i2c/chips/adm1021.c	Fri Mar 21 16:52:58 2003
+++ b/drivers/i2c/chips/adm1021.c	Fri Mar 21 16:52:58 2003
@@ -299,7 +299,7 @@
 	}
 
 	/* Fill in the remaining client fields and put it into the global list */
-	strcpy(new_client->name, client_name);
+	strncpy(new_client->dev.name, client_name, DEVICE_NAME_SIZE);
 	data->type = kind;
 
 	new_client->id = adm1021_id++;
diff -Nru a/drivers/i2c/chips/lm75.c b/drivers/i2c/chips/lm75.c
--- a/drivers/i2c/chips/lm75.c	Fri Mar 21 16:52:58 2003
+++ b/drivers/i2c/chips/lm75.c	Fri Mar 21 16:52:58 2003
@@ -180,7 +180,7 @@
 	}
 
 	/* Fill in the remaining client fields and put it into the global list */
-	strcpy(new_client->name, client_name);
+	strncpy(new_client->dev.name, client_name, DEVICE_NAME_SIZE);
 
 	new_client->id = lm75_id++;
 	data->valid = 0;
diff -Nru a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
--- a/drivers/i2c/i2c-core.c	Fri Mar 21 16:52:58 2003
+++ b/drivers/i2c/i2c-core.c	Fri Mar 21 16:52:58 2003
@@ -291,9 +291,9 @@
 				    client->driver == driver) {
 					DEB2(printk(KERN_DEBUG "i2c-core.o: "
 						    "detaching client %s:\n",
-					            client->name));
+					            client->dev.name));
 					if ((res = driver->detach_client(client))) {
- 						dev_err(&adap->dev, "while "
+						dev_err(&adap->dev, "while "
 						       "unregistering driver "
 						       "`%s', the client at "
 						       "address %02x of "
@@ -355,7 +355,7 @@
 
 	printk(KERN_WARNING 
 	       " i2c-core.o: attach_client(%s) - enlarge I2C_CLIENT_MAX.\n",
-	       client->name);
+	       client->dev.name);
 
  out_unlock_list:
 	up(&adapter->list);
@@ -374,7 +374,7 @@
 	}
 
 	DEB(dev_dbg(&adapter->dev, "client [%s] registered to adapter "
-			"(pos. %d).\n", client->name, i));
+			"(pos. %d).\n", client->dev.name, i));
 
 	if (client->flags & I2C_CLIENT_ALLOW_USE)
 		client->usage_count = 0;
@@ -395,7 +395,7 @@
 		if (res) {
 			printk(KERN_ERR
 			       "i2c-core.o: client_unregister [%s] failed, "
-			       "client not detached", client->name);
+			       "client not detached", client->dev.name);
 			goto out;
 		}
 	}
@@ -410,7 +410,7 @@
 
 	printk(KERN_WARNING
 	       " i2c-core.o: unregister_client [%s] not found\n",
-	       client->name);
+	       client->dev.name);
 	res = -ENODEV;
 
  out_unlock:
@@ -522,7 +522,7 @@
 				client = adapters[i]->clients[order[j]];
 				len += sprintf(kbuf+len,"%02x\t%-32s\t%-32s\n",
 				              client->addr,
-				              client->name,
+				              client->dev.name,
 				              client->driver->name);
 			}
 			len = len - file->f_pos;
diff -Nru a/drivers/i2c/i2c-dev.c b/drivers/i2c/i2c-dev.c
--- a/drivers/i2c/i2c-dev.c	Fri Mar 21 16:52:58 2003
+++ b/drivers/i2c/i2c-dev.c	Fri Mar 21 16:52:58 2003
@@ -86,7 +86,9 @@
 };
 
 static struct i2c_client i2cdev_client_template = {
-	.name		= "I2C /dev entry",
+	.dev		= {
+		.name	= "I2C /dev entry",
+	},
 	.id		= 1,
 	.addr		= -1,
 	.driver		= &i2cdev_driver,
diff -Nru a/include/linux/i2c.h b/include/linux/i2c.h
--- a/include/linux/i2c.h	Fri Mar 21 16:52:58 2003
+++ b/include/linux/i2c.h	Fri Mar 21 16:52:58 2003
@@ -156,7 +156,6 @@
  * function is mainly used for lookup & other admin. functions.
  */
 struct i2c_client {
-	char name[32];
 	int id;
 	unsigned int flags;		/* div., see below		*/
 	unsigned int addr;		/* chip address - NOTE: 7bit 	*/


  parent reply	other threads:[~2005-05-19  6:23 UTC|newest]

Thread overview: 92+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-03-22  1:04 [BK PATCH] More i2c driver changes for 2.5.65 Greg KH
2005-05-19  6:23 ` Greg KH
2003-03-22  1:04 ` [PATCH] " Greg KH
2005-05-19  6:23   ` Greg KH
2003-03-22  1:04   ` Greg KH
2005-05-19  6:23     ` Greg KH
2003-03-22  1:04     ` Greg KH
2005-05-19  6:23       ` Greg KH
2003-03-22  1:04       ` Greg KH
2005-05-19  6:23         ` Greg KH
2003-03-22  1:04         ` Greg KH
2005-05-19  6:23           ` Greg KH
2003-03-22  1:04           ` Greg KH [this message]
2005-05-19  6:23             ` Greg KH
2003-03-22  1:04             ` Greg KH
2005-05-19  6:23               ` Greg KH
2003-03-22  1:04               ` Greg KH
2005-05-19  6:23                 ` Greg KH
2003-03-22  1:04                 ` Greg KH
2005-05-19  6:23                   ` Greg KH
2003-03-25  9:35                 ` Pavel Machek
2005-05-19  6:23                   ` Pavel Machek
2003-03-25  1:29                   ` Greg KH
2005-05-19  6:23                     ` Greg KH
2003-03-25  2:04                     ` Dave Jones
2005-05-19  6:23                       ` Dave Jones
2003-03-25  3:34                       ` Greg KH
2005-05-19  6:23                         ` Greg KH
2005-05-19  6:23         ` [PATCH] More i2c driver changes for 2.5.66 Greg KH
2005-05-19  6:23         ` Albert Cranford
2005-05-19  6:23         ` Mark M. Hoffman
2005-05-19  6:23         ` [PATCH] More i2c driver changes for 2.5.69 Philip Pokorny
2003-03-22  2:33     ` [PATCH] More i2c driver changes for 2.5.65 Petr Vandrovec
2005-05-19  6:23       ` Petr Vandrovec
2003-03-23  8:49       ` Greg KH
2005-05-19  6:23         ` Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2003-04-03  0:14 [BK PATCH] More i2c driver changes for 2.5.66 Greg KH
2003-04-03  0:15 ` [PATCH] " Greg KH
2003-04-03  0:15   ` Greg KH
2003-04-03  0:15     ` Greg KH
2003-04-03  0:15       ` Greg KH
2003-04-03  0:15         ` Greg KH
2003-04-03  0:15           ` Greg KH
2005-05-19  6:23             ` Greg KH
2003-04-03  0:15             ` Greg KH
2003-04-03  0:15               ` Greg KH
2005-05-19  6:23                 ` Greg KH
2003-04-03  0:15                 ` Greg KH
2003-04-03  0:15                   ` Greg KH
2003-04-03  0:15                     ` Greg KH
2003-04-03  0:15                       ` Greg KH
2003-04-03  0:15                         ` Greg KH
2003-04-03  0:15                           ` Greg KH
2003-04-03  0:15                             ` Greg KH
2003-04-03  6:21                 ` Albert Cranford
2005-05-19  6:23                   ` Albert Cranford
2003-04-03  6:33                   ` Greg KH
2005-05-19  6:23                     ` Greg KH
2003-04-03 13:06                     ` Albert Cranford
2005-05-19  6:23                       ` Albert Cranford
2003-04-03 16:37                       ` Greg KH
2005-05-19  6:23                         ` Greg KH
2003-05-09 23:55 [BK PATCH] More i2c driver changes for 2.5.69 Greg KH
2005-05-19  6:23 ` Greg KH
2003-05-09 23:56 ` [PATCH] " Greg KH
2005-05-19  6:23   ` Greg KH
2003-05-09 23:56   ` Greg KH
2005-05-19  6:23     ` Greg KH
2003-05-09 23:56     ` Greg KH
2005-05-19  6:23       ` Greg KH
2003-05-09 23:56       ` Greg KH
2005-05-19  6:23         ` Greg KH
2003-05-09 23:56         ` Greg KH
2005-05-19  6:23           ` Greg KH
2003-05-09 23:56           ` Greg KH
2005-05-19  6:23             ` Greg KH
2003-06-11 20:35 [BK PATCH] More i2c driver changes for 2.5.70 Greg KH
2005-05-19  6:23 ` Greg KH
2003-06-11 20:36 ` [PATCH] " Greg KH
2005-05-19  6:23   ` Greg KH
2003-06-11 20:36   ` Greg KH
2005-05-19  6:23     ` Greg KH
2003-06-11 20:36     ` Greg KH
2005-05-19  6:23       ` Greg KH
2003-06-11 20:36       ` Greg KH
2005-05-19  6:23         ` Greg KH
2003-06-11 20:36         ` Greg KH
2005-05-19  6:23           ` Greg KH
2003-06-11 20:36           ` Greg KH
2005-05-19  6:23             ` Greg KH
2003-06-12  2:40   ` Philip Pokorny
2005-05-19  6:23     ` Philip Pokorny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=10482950874081@kroah.com \
    --to=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sensors@stimpy.netroedge.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.