* typos
@ 2004-08-17 8:10 Borislav Petkov
2004-08-17 8:30 ` typos Lee Revell
0 siblings, 1 reply; 6+ messages in thread
From: Borislav Petkov @ 2004-08-17 8:10 UTC (permalink / raw)
To: linux-kernel
[-- Attachment #1.1: Type: text/plain, Size: 671 bytes --]
Hi there guys,
I've been pondering on posting about this for a long time but I guess
I'll just go and say it. I've been reading the lkml for about a year now
and, I don't know how important it is to you, but I think that typos in
the comments in the kernel sources really annoy those who really read
them in order to understand what's going on. Well, I'm one of them, and,
since the typos are really a lot, I thought that maybe fixing them would
be a good idea.
Here's a patch. Please, tell me if you don't want such noise on the list
but I think that, although not crucial, somewhat correct english in the
comments would be better, or?
Regards,
Boris
[-- Attachment #1.2: Type: text/x-patch, Size: 773 bytes --]
--- linux-2.6.8.1/ipc/sem.c.orig 2004-08-17 10:02:06.000000000 +0200
+++ linux-2.6.8.1/ipc/sem.c 2004-08-17 10:02:57.000000000 +0200
@@ -879,7 +879,7 @@ static inline void lock_semundo(void)
* acquires the undo_list lock in lock_semundo(). If task2 now
* exits before task1 releases the lock (by calling
* unlock_semundo()), then task1 will never call spin_unlock().
- * This leave the sem_undo_list in a locked state. If task1 now creats task3
+ * This leaves the sem_undo_list in a locked state. If task1 now creates task3
* and once again shares the sem_undo_list, the sem_undo_list will still be
* locked, and future SEM_UNDO operations will deadlock. This case is
* dealt with in copy_semundo() by having it reinitialize the spin lock when
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: typos
2004-08-17 8:10 typos Borislav Petkov
@ 2004-08-17 8:30 ` Lee Revell
2004-08-17 8:41 ` typos Borislav Petkov
0 siblings, 1 reply; 6+ messages in thread
From: Lee Revell @ 2004-08-17 8:30 UTC (permalink / raw)
To: Borislav Petkov; +Cc: linux-kernel
On Tue, 2004-08-17 at 04:10, Borislav Petkov wrote:
> Hi there guys,
> I've been pondering on posting about this for a long time but I guess
> I'll just go and say it. I've been reading the lkml for about a year now
> and, I don't know how important it is to you, but I think that typos in
> the comments in the kernel sources really annoy those who really read
> them in order to understand what's going on. Well, I'm one of them, and,
> since the typos are really a lot, I thought that maybe fixing them would
> be a good idea.
> Here's a patch. Please, tell me if you don't want such noise on the list
> but I think that, although not crucial, somewhat correct english in the
> comments would be better, or?
>
> Regards,
> Boris
>
>
--- foo.orig 2004-08-17 04:27:55.000000000 -0400
+++ foo.fixed 2004-08-17 04:29:27.000000000 -0400
@@ -44,11 +44,11 @@
and, I don't know how important it is to you, but I think that typos in
the comments in the kernel sources really annoy those who really read
them in order to understand what's going on. Well, I'm one of them, and,
-since the typos are really a lot, I thought that maybe fixing them would
+since there are really a lot of typos, I thought that maybe fixing them would
be a good idea.
-Here's a patch. Please, tell me if you don't want such noise on the list
-but I think that, although not crucial, somewhat correct english in the
-comments would be better, or?
+Here's a patch. Please, tell me if you don't want such noise on the
+list. I think that, although not crucial, somewhat more correct english in the
+comments would be better.
Regards,
Boris
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: typos
2004-08-17 8:30 ` typos Lee Revell
@ 2004-08-17 8:41 ` Borislav Petkov
2004-08-17 8:44 ` typos Lee Revell
0 siblings, 1 reply; 6+ messages in thread
From: Borislav Petkov @ 2004-08-17 8:41 UTC (permalink / raw)
To: Lee Revell; +Cc: linux-kernel
On Tue, 2004-08-17 at 10:30, Lee Revell wrote:
> On Tue, 2004-08-17 at 04:10, Borislav Petkov wrote:
> > Hi there guys,
> > I've been pondering on posting about this for a long time but I guess
> > I'll just go and say it. I've been reading the lkml for about a year now
> > and, I don't know how important it is to you, but I think that typos in
> > the comments in the kernel sources really annoy those who really read
> > them in order to understand what's going on. Well, I'm one of them, and,
> > since the typos are really a lot, I thought that maybe fixing them would
> > be a good idea.
> > Here's a patch. Please, tell me if you don't want such noise on the list
> > but I think that, although not crucial, somewhat correct english in the
> > comments would be better, or?
> >
> > Regards,
> > Boris
> >
> >
>
> --- foo.orig 2004-08-17 04:27:55.000000000 -0400
> +++ foo.fixed 2004-08-17 04:29:27.000000000 -0400
> @@ -44,11 +44,11 @@
> and, I don't know how important it is to you, but I think that typos in
> the comments in the kernel sources really annoy those who really read
> them in order to understand what's going on. Well, I'm one of them, and,
> -since the typos are really a lot, I thought that maybe fixing them would
> +since there are really a lot of typos, I thought that maybe fixing them would
> be a good idea.
> -Here's a patch. Please, tell me if you don't want such noise on the list
> -but I think that, although not crucial, somewhat correct english in the
> -comments would be better, or?
> +Here's a patch. Please, tell me if you don't want such noise on the
> +list. I think that, although not crucial, somewhat more correct english in the
> +comments would be better.
>
> Regards,
> Boris
>
>
I was expecting a flame like that. :) However, I'm talking about typos
and not about stylistic mistakes. After all, we don't want a masterpiece
in contemporary english literature...
Good day to you Mr. Revell,
Boris.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: typos
2004-08-17 8:41 ` typos Borislav Petkov
@ 2004-08-17 8:44 ` Lee Revell
2004-08-17 9:17 ` typos David Greaves
0 siblings, 1 reply; 6+ messages in thread
From: Lee Revell @ 2004-08-17 8:44 UTC (permalink / raw)
To: Borislav Petkov; +Cc: linux-kernel
On Tue, 2004-08-17 at 04:41, Borislav Petkov wrote:
> >
> > --- foo.orig 2004-08-17 04:27:55.000000000 -0400
> > +++ foo.fixed 2004-08-17 04:29:27.000000000 -0400
> > @@ -44,11 +44,11 @@
> > and, I don't know how important it is to you, but I think that typos in
> > the comments in the kernel sources really annoy those who really read
> > them in order to understand what's going on. Well, I'm one of them, and,
> > -since the typos are really a lot, I thought that maybe fixing them would
> > +since there are really a lot of typos, I thought that maybe fixing them would
> > be a good idea.
> > -Here's a patch. Please, tell me if you don't want such noise on the list
> > -but I think that, although not crucial, somewhat correct english in the
> > -comments would be better, or?
> > +Here's a patch. Please, tell me if you don't want such noise on the
> > +list. I think that, although not crucial, somewhat more correct english in the
> > +comments would be better.
> >
> > Regards,
> > Boris
> >
> >
> I was expecting a flame like that. :) However, I'm talking about typos
> and not about stylistic mistakes. After all, we don't want a masterpiece
> in contemporary english literature...
>
> Good day to you Mr. Revell,
>
Sorry, I couldn't resist ;-).
Seriously, submitting patches to fix typos like this is not a bad idea,
if you are inclined to do it, I am sure the patches woud be accepted.
Lee
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: typos
2004-08-17 8:44 ` typos Lee Revell
@ 2004-08-17 9:17 ` David Greaves
2004-08-17 9:40 ` typos Borislav Petkov
0 siblings, 1 reply; 6+ messages in thread
From: David Greaves @ 2004-08-17 9:17 UTC (permalink / raw)
To: Lee Revell; +Cc: Borislav Petkov, linux-kernel
Lee Revell wrote:
>On Tue, 2004-08-17 at 04:41, Borislav Petkov wrote:
>
>
>Sorry, I couldn't resist ;-).
>
>Seriously, submitting patches to fix typos like this is not a bad idea,
>if you are inclined to do it, I am sure the patches woud be accepted.
>
>Lee
>
>
Doesn't Rusty Russell aggregate such things?
http://www.kernel.org/pub/linux/kernel/people/rusty/trivial/
David
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: typos
2004-08-17 9:17 ` typos David Greaves
@ 2004-08-17 9:40 ` Borislav Petkov
0 siblings, 0 replies; 6+ messages in thread
From: Borislav Petkov @ 2004-08-17 9:40 UTC (permalink / raw)
To: linux-kernel
On Tue, 2004-08-17 at 11:17, David Greaves wrote:
> Lee Revell wrote:
>
> >On Tue, 2004-08-17 at 04:41, Borislav Petkov wrote:
> >
> >
> >Sorry, I couldn't resist ;-).
> >
> >Seriously, submitting patches to fix typos like this is not a bad idea,
> >if you are inclined to do it, I am sure the patches woud be accepted.
> >
> >Lee
> >
> >
>
> Doesn't Rusty Russell aggregate such things?
>
> http://www.kernel.org/pub/linux/kernel/people/rusty/trivial/
>
> David
Oh, didn't know that, sent as suggested to the trivial monkey :)
Boris.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2004-08-17 9:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-08-17 8:10 typos Borislav Petkov
2004-08-17 8:30 ` typos Lee Revell
2004-08-17 8:41 ` typos Borislav Petkov
2004-08-17 8:44 ` typos Lee Revell
2004-08-17 9:17 ` typos David Greaves
2004-08-17 9:40 ` typos Borislav Petkov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.