All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Pavel Machek <pavel@suse.cz>
Cc: Jesse Barnes <jbarnes@engr.sgi.com>,
	linux-pci@atrey.karlin.mff.cuni.cz,
	Matthew Wilcox <matthew@wil.cx>,
	Linus Torvalds <torvalds@osdl.org>,
	Jeff Garzik <jgarzik@pobox.com>,
	Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
	Linux Kernel list <linux-kernel@vger.kernel.org>,
	linux-ia64@vger.kernel.org, Linas Vepstas <linas@austin.ibm.com>,
	"Luck, Tony" <tony.luck@intel.com>
Subject: Re: [PATCH/RFC] I/O-check interface for driver's error handling
Date: Fri, 04 Mar 2005 23:27:07 +0000	[thread overview]
Message-ID: <1109978827.5680.324.camel@gaston> (raw)
In-Reply-To: <20050304231807.GC2647@elf.ucw.cz>

On Sat, 2005-03-05 at 00:18 +0100, Pavel Machek wrote:
> On So 05-03-05 10:03:37, Benjamin Herrenschmidt wrote:
> > On Fri, 2005-03-04 at 23:57 +0100, Pavel Machek wrote:
> > 
> > > What prevents driver from being run on another CPU, maybe just doing
> > > mdelay() between hardware accesses? 
> > 
> > Almost all drivers that I know have some sort of locking. Nothing nasty
> > about it. Besides, you can't expect everything to be as simple as
> > putting two bit of lego together, the problem isn't simple.
> 
> If error() is allowed to sleep, then yes, its probably easy enough. If
> it is not allowed to sleep, it will just postpone work to context that
> is allowed to sleep, and it will probably be okay, too.

Yes, it's my itend that the notification callback is to be called in a
task context where it can sleep.

> => there are some locking issues, but they are probably easy
> enough. Sorry for noise.
> 								Pavel
> 
-- 
Benjamin Herrenschmidt <benh@kernel.crashing.org>


WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Pavel Machek <pavel@suse.cz>
Cc: Jesse Barnes <jbarnes@engr.sgi.com>,
	linux-pci@atrey.karlin.mff.cuni.cz,
	Matthew Wilcox <matthew@wil.cx>,
	Linus Torvalds <torvalds@osdl.org>,
	Jeff Garzik <jgarzik@pobox.com>,
	Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
	Linux Kernel list <linux-kernel@vger.kernel.org>,
	linux-ia64@vger.kernel.org, Linas Vepstas <linas@austin.ibm.com>,
	"Luck, Tony" <tony.luck@intel.com>
Subject: Re: [PATCH/RFC] I/O-check interface for driver's error handling
Date: Sat, 05 Mar 2005 10:27:07 +1100	[thread overview]
Message-ID: <1109978827.5680.324.camel@gaston> (raw)
In-Reply-To: <20050304231807.GC2647@elf.ucw.cz>

On Sat, 2005-03-05 at 00:18 +0100, Pavel Machek wrote:
> On So 05-03-05 10:03:37, Benjamin Herrenschmidt wrote:
> > On Fri, 2005-03-04 at 23:57 +0100, Pavel Machek wrote:
> > 
> > > What prevents driver from being run on another CPU, maybe just doing
> > > mdelay() between hardware accesses? 
> > 
> > Almost all drivers that I know have some sort of locking. Nothing nasty
> > about it. Besides, you can't expect everything to be as simple as
> > putting two bit of lego together, the problem isn't simple.
> 
> If error() is allowed to sleep, then yes, its probably easy enough. If
> it is not allowed to sleep, it will just postpone work to context that
> is allowed to sleep, and it will probably be okay, too.

Yes, it's my itend that the notification callback is to be called in a
task context where it can sleep.

> => there are some locking issues, but they are probably easy
> enough. Sorry for noise.
> 								Pavel
> 
-- 
Benjamin Herrenschmidt <benh@kernel.crashing.org>


  reply	other threads:[~2005-03-04 23:27 UTC|newest]

Thread overview: 90+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-01  8:33 [PATCH/RFC] I/O-check interface for driver's error handling Hidetoshi Seto
2005-03-01  8:33 ` Hidetoshi Seto
2005-03-01 14:42 ` Matthew Wilcox
2005-03-01 14:42   ` Matthew Wilcox
2005-03-01 19:27   ` Linas Vepstas
2005-03-01 19:27     ` Linas Vepstas
2005-03-01 19:37     ` Linus Torvalds
2005-03-01 19:37       ` Linus Torvalds
2005-03-02  6:13     ` Hidetoshi Seto
2005-03-02  6:13       ` Hidetoshi Seto
2005-03-02 19:20       ` Linas Vepstas
2005-03-02 19:20         ` Linas Vepstas
2005-03-04  2:03         ` Hidetoshi Seto
2005-03-04  2:03           ` Hidetoshi Seto
2005-03-04 16:46           ` Linas Vepstas
2005-03-04 16:46             ` Linas Vepstas
2005-03-01 16:37 ` Jeff Garzik
2005-03-01 16:37   ` Jeff Garzik
2005-03-01 16:49   ` Linus Torvalds
2005-03-01 16:49     ` Linus Torvalds
2005-03-01 16:59     ` Matthew Wilcox
2005-03-01 16:59       ` Matthew Wilcox
2005-03-01 17:10       ` Jesse Barnes
2005-03-01 17:10         ` Jesse Barnes
2005-03-01 18:33         ` Linas Vepstas
2005-03-01 18:33           ` Linas Vepstas
2005-03-01 22:27           ` Benjamin Herrenschmidt
2005-03-01 22:27             ` Benjamin Herrenschmidt
2005-03-02 20:02             ` Linas Vepstas
2005-03-02 20:02               ` Linas Vepstas
2005-03-02 22:46               ` Benjamin Herrenschmidt
2005-03-02 22:46                 ` Benjamin Herrenschmidt
2005-03-02 23:37                 ` Linas Vepstas
2005-03-02 23:37                   ` Linas Vepstas
2005-03-01 22:23         ` Benjamin Herrenschmidt
2005-03-01 22:23           ` Benjamin Herrenschmidt
2005-03-02  3:13         ` Hidetoshi Seto
2005-03-02  3:13           ` Hidetoshi Seto
2005-03-04 13:54         ` Pavel Machek
2005-03-04 13:54           ` Pavel Machek
2005-03-04 17:50           ` Jesse Barnes
2005-03-04 17:50             ` Jesse Barnes
2005-03-04 22:37           ` Benjamin Herrenschmidt
2005-03-04 22:37             ` Benjamin Herrenschmidt
2005-03-04 22:57             ` Pavel Machek
2005-03-04 22:57               ` Pavel Machek
2005-03-04 23:03               ` Benjamin Herrenschmidt
2005-03-04 23:03                 ` Benjamin Herrenschmidt
2005-03-04 23:18                 ` Pavel Machek
2005-03-04 23:18                   ` Pavel Machek
2005-03-04 23:27                   ` Benjamin Herrenschmidt [this message]
2005-03-04 23:27                     ` Benjamin Herrenschmidt
2005-03-02  2:28       ` Hidetoshi Seto
2005-03-02  2:28         ` Hidetoshi Seto
2005-03-02 17:44         ` Linas Vepstas
2005-03-02 17:44           ` Linas Vepstas
2005-03-02 18:03           ` linux-os
2005-03-02 18:03             ` linux-os
2005-03-02 22:40             ` Benjamin Herrenschmidt
2005-03-02 22:40               ` Benjamin Herrenschmidt
2005-03-04  2:21           ` Hidetoshi Seto
2005-03-04  2:21             ` Hidetoshi Seto
2005-03-01 22:20     ` Benjamin Herrenschmidt
2005-03-01 22:20       ` Benjamin Herrenschmidt
2005-03-02 18:22     ` Linas Vepstas
2005-03-02 18:22       ` Linas Vepstas
2005-03-02 18:41       ` Jesse Barnes
2005-03-02 18:41         ` Jesse Barnes
2005-03-02 19:46         ` Linas Vepstas
2005-03-02 19:46           ` Linas Vepstas
2005-03-02 22:43         ` Benjamin Herrenschmidt
2005-03-02 22:43           ` Benjamin Herrenschmidt
2005-03-02 22:41       ` Benjamin Herrenschmidt
2005-03-02 22:41         ` Benjamin Herrenschmidt
2005-03-02 23:30         ` Linas Vepstas
2005-03-02 23:30           ` Linas Vepstas
2005-03-02 23:40           ` Jesse Barnes
2005-03-02 23:40             ` Jesse Barnes
2005-03-01 19:17   ` Linas Vepstas
2005-03-01 19:17     ` Linas Vepstas
2005-03-01 22:15   ` Benjamin Herrenschmidt
2005-03-01 22:15     ` Benjamin Herrenschmidt
2005-03-01 17:19 ` Andi Kleen
2005-03-01 18:08   ` Linus Torvalds
2005-03-01 18:45     ` Andi Kleen
2005-03-01 18:59     ` Linas Vepstas
2005-03-01 22:26     ` Benjamin Herrenschmidt
2005-03-01 22:24   ` Benjamin Herrenschmidt
2005-03-04 12:40 ` Hidetoshi Seto
2005-03-04 12:40   ` Hidetoshi Seto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1109978827.5680.324.camel@gaston \
    --to=benh@kernel.crashing.org \
    --cc=jbarnes@engr.sgi.com \
    --cc=jgarzik@pobox.com \
    --cc=linas@austin.ibm.com \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@atrey.karlin.mff.cuni.cz \
    --cc=matthew@wil.cx \
    --cc=pavel@suse.cz \
    --cc=seto.hidetoshi@jp.fujitsu.com \
    --cc=tony.luck@intel.com \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.