All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
To: Linas Vepstas <linas@austin.ibm.com>
Cc: Matthew Wilcox <matthew@wil.cx>,
	Linux Kernel list <linux-kernel@vger.kernel.org>,
	linux-pci@atrey.karlin.mff.cuni.cz, linux-ia64@vger.kernel.org,
	Linus Torvalds <torvalds@osdl.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	"Luck, Tony" <tony.luck@intel.com>
Subject: Re: [PATCH/RFC] I/O-check interface for driver's error handling
Date: Fri, 04 Mar 2005 02:03:29 +0000	[thread overview]
Message-ID: <4227C1F1.6040508@jp.fujitsu.com> (raw)
In-Reply-To: <20050302192043.GJ1220@austin.ibm.com>

Linas Vepstas wrote:
>>If their defaults are no-ops, device
>>maintainers who develops their driver on not-implemented arch should be
>>more careful. 
> 
> Why? People who write device drivers already know if/when they need to
> disable interrupts, and so they already disable if they need it.  

OK, I'll remake them as no-ops.
Nothing will start unless trust in driver folks.

> p.s. I would like to have iochk_read() take struct pci_dev * as an
> argument.  (I could store a pointer to pci_dev in the "cookie" but
> that seems odd).

I'd like to store the pointer and handle all only with the cookie...
Or is it needed to pass different device to iochk_clear() and iochk_read()?


Thanks,
H.Seto


WARNING: multiple messages have this Message-ID (diff)
From: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
To: Linas Vepstas <linas@austin.ibm.com>
Cc: Matthew Wilcox <matthew@wil.cx>,
	Linux Kernel list <linux-kernel@vger.kernel.org>,
	linux-pci@atrey.karlin.mff.cuni.cz, linux-ia64@vger.kernel.org,
	Linus Torvalds <torvalds@osdl.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	"Luck, Tony" <tony.luck@intel.com>
Subject: Re: [PATCH/RFC] I/O-check interface for driver's error handling
Date: Fri, 04 Mar 2005 11:03:29 +0900	[thread overview]
Message-ID: <4227C1F1.6040508@jp.fujitsu.com> (raw)
In-Reply-To: <20050302192043.GJ1220@austin.ibm.com>

Linas Vepstas wrote:
>>If their defaults are no-ops, device
>>maintainers who develops their driver on not-implemented arch should be
>>more careful. 
> 
> Why? People who write device drivers already know if/when they need to
> disable interrupts, and so they already disable if they need it.  

OK, I'll remake them as no-ops.
Nothing will start unless trust in driver folks.

> p.s. I would like to have iochk_read() take struct pci_dev * as an
> argument.  (I could store a pointer to pci_dev in the "cookie" but
> that seems odd).

I'd like to store the pointer and handle all only with the cookie...
Or is it needed to pass different device to iochk_clear() and iochk_read()?


Thanks,
H.Seto


  reply	other threads:[~2005-03-04  2:03 UTC|newest]

Thread overview: 90+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-01  8:33 [PATCH/RFC] I/O-check interface for driver's error handling Hidetoshi Seto
2005-03-01  8:33 ` Hidetoshi Seto
2005-03-01 14:42 ` Matthew Wilcox
2005-03-01 14:42   ` Matthew Wilcox
2005-03-01 19:27   ` Linas Vepstas
2005-03-01 19:27     ` Linas Vepstas
2005-03-01 19:37     ` Linus Torvalds
2005-03-01 19:37       ` Linus Torvalds
2005-03-02  6:13     ` Hidetoshi Seto
2005-03-02  6:13       ` Hidetoshi Seto
2005-03-02 19:20       ` Linas Vepstas
2005-03-02 19:20         ` Linas Vepstas
2005-03-04  2:03         ` Hidetoshi Seto [this message]
2005-03-04  2:03           ` Hidetoshi Seto
2005-03-04 16:46           ` Linas Vepstas
2005-03-04 16:46             ` Linas Vepstas
2005-03-01 16:37 ` Jeff Garzik
2005-03-01 16:37   ` Jeff Garzik
2005-03-01 16:49   ` Linus Torvalds
2005-03-01 16:49     ` Linus Torvalds
2005-03-01 16:59     ` Matthew Wilcox
2005-03-01 16:59       ` Matthew Wilcox
2005-03-01 17:10       ` Jesse Barnes
2005-03-01 17:10         ` Jesse Barnes
2005-03-01 18:33         ` Linas Vepstas
2005-03-01 18:33           ` Linas Vepstas
2005-03-01 22:27           ` Benjamin Herrenschmidt
2005-03-01 22:27             ` Benjamin Herrenschmidt
2005-03-02 20:02             ` Linas Vepstas
2005-03-02 20:02               ` Linas Vepstas
2005-03-02 22:46               ` Benjamin Herrenschmidt
2005-03-02 22:46                 ` Benjamin Herrenschmidt
2005-03-02 23:37                 ` Linas Vepstas
2005-03-02 23:37                   ` Linas Vepstas
2005-03-01 22:23         ` Benjamin Herrenschmidt
2005-03-01 22:23           ` Benjamin Herrenschmidt
2005-03-02  3:13         ` Hidetoshi Seto
2005-03-02  3:13           ` Hidetoshi Seto
2005-03-04 13:54         ` Pavel Machek
2005-03-04 13:54           ` Pavel Machek
2005-03-04 17:50           ` Jesse Barnes
2005-03-04 17:50             ` Jesse Barnes
2005-03-04 22:37           ` Benjamin Herrenschmidt
2005-03-04 22:37             ` Benjamin Herrenschmidt
2005-03-04 22:57             ` Pavel Machek
2005-03-04 22:57               ` Pavel Machek
2005-03-04 23:03               ` Benjamin Herrenschmidt
2005-03-04 23:03                 ` Benjamin Herrenschmidt
2005-03-04 23:18                 ` Pavel Machek
2005-03-04 23:18                   ` Pavel Machek
2005-03-04 23:27                   ` Benjamin Herrenschmidt
2005-03-04 23:27                     ` Benjamin Herrenschmidt
2005-03-02  2:28       ` Hidetoshi Seto
2005-03-02  2:28         ` Hidetoshi Seto
2005-03-02 17:44         ` Linas Vepstas
2005-03-02 17:44           ` Linas Vepstas
2005-03-02 18:03           ` linux-os
2005-03-02 18:03             ` linux-os
2005-03-02 22:40             ` Benjamin Herrenschmidt
2005-03-02 22:40               ` Benjamin Herrenschmidt
2005-03-04  2:21           ` Hidetoshi Seto
2005-03-04  2:21             ` Hidetoshi Seto
2005-03-01 22:20     ` Benjamin Herrenschmidt
2005-03-01 22:20       ` Benjamin Herrenschmidt
2005-03-02 18:22     ` Linas Vepstas
2005-03-02 18:22       ` Linas Vepstas
2005-03-02 18:41       ` Jesse Barnes
2005-03-02 18:41         ` Jesse Barnes
2005-03-02 19:46         ` Linas Vepstas
2005-03-02 19:46           ` Linas Vepstas
2005-03-02 22:43         ` Benjamin Herrenschmidt
2005-03-02 22:43           ` Benjamin Herrenschmidt
2005-03-02 22:41       ` Benjamin Herrenschmidt
2005-03-02 22:41         ` Benjamin Herrenschmidt
2005-03-02 23:30         ` Linas Vepstas
2005-03-02 23:30           ` Linas Vepstas
2005-03-02 23:40           ` Jesse Barnes
2005-03-02 23:40             ` Jesse Barnes
2005-03-01 19:17   ` Linas Vepstas
2005-03-01 19:17     ` Linas Vepstas
2005-03-01 22:15   ` Benjamin Herrenschmidt
2005-03-01 22:15     ` Benjamin Herrenschmidt
2005-03-01 17:19 ` Andi Kleen
2005-03-01 18:08   ` Linus Torvalds
2005-03-01 18:45     ` Andi Kleen
2005-03-01 18:59     ` Linas Vepstas
2005-03-01 22:26     ` Benjamin Herrenschmidt
2005-03-01 22:24   ` Benjamin Herrenschmidt
2005-03-04 12:40 ` Hidetoshi Seto
2005-03-04 12:40   ` Hidetoshi Seto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4227C1F1.6040508@jp.fujitsu.com \
    --to=seto.hidetoshi@jp.fujitsu.com \
    --cc=benh@kernel.crashing.org \
    --cc=linas@austin.ibm.com \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@atrey.karlin.mff.cuni.cz \
    --cc=matthew@wil.cx \
    --cc=tony.luck@intel.com \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.