All of lore.kernel.org
 help / color / mirror / Atom feed
From: johnpol@2ka.mipt.ru (Evgeniy Polyakov)
To: Adrian Bunk <bunk@stusta.de>
Cc: sensors@stimpy.netroedge.com, linux-kernel@vger.kernel.org
Subject: [2.6 patch] drivers/w1/: possible cleanups
Date: Thu, 19 May 2005 06:25:52 +0000	[thread overview]
Message-ID: <1113920787.29655.11.camel@uganda> (raw)
In-Reply-To: <20050417233145.GX3625@stusta.de>

On Mon, 2005-04-18 at 01:31 +0200, Adrian Bunk wrote:
> This patch contains the following possible cleanups:
> - make needlessly global code static
> - #if 0 unused functions
> - remove unused EXPORT_SYMBOL's
> 
> Signed-off-by: Adrian Bunk <bunk@stusta.de>

Thank you for your patch, I will apply the most of it,
but I have some points against
1. removing ->get(), while having ->put() methods.
2. removing some w1_read/write* methods() since they are used for test
cases.

I will push it after Greg applied current pending patchset.

-- 
        Evgeniy Polyakov

Crash is better than data corruption -- Arthur Grabowski
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20050419/0517f188/attachment.bin

WARNING: multiple messages have this Message-ID (diff)
From: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
To: Adrian Bunk <bunk@stusta.de>
Cc: sensors@stimpy.netroedge.com, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] drivers/w1/: possible cleanups
Date: Tue, 19 Apr 2005 18:26:27 +0400	[thread overview]
Message-ID: <1113920787.29655.11.camel@uganda> (raw)
In-Reply-To: <20050417233145.GX3625@stusta.de>

[-- Attachment #1: Type: text/plain, Size: 643 bytes --]

On Mon, 2005-04-18 at 01:31 +0200, Adrian Bunk wrote:
> This patch contains the following possible cleanups:
> - make needlessly global code static
> - #if 0 unused functions
> - remove unused EXPORT_SYMBOL's
> 
> Signed-off-by: Adrian Bunk <bunk@stusta.de>

Thank you for your patch, I will apply the most of it,
but I have some points against
1. removing ->get(), while having ->put() methods.
2. removing some w1_read/write* methods() since they are used for test
cases.

I will push it after Greg applied current pending patchset.

-- 
        Evgeniy Polyakov

Crash is better than data corruption -- Arthur Grabowski

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

  reply	other threads:[~2005-05-19  6:25 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-17 23:31 [2.6 patch] drivers/w1/: possible cleanups Adrian Bunk
2005-05-19  6:25 ` Adrian Bunk
2005-04-19 14:26 ` Evgeniy Polyakov [this message]
2005-05-19  6:25   ` Evgeniy Polyakov
  -- strict thread matches above, loose matches on Subject: below --
2004-11-21 22:02 drivers/w1/: why is dscore.c not ds9490r.c ? Adrian Bunk
2005-05-19  6:25 ` Adrian Bunk
2004-11-22  7:31 ` Evgeniy Polyakov
2005-05-19  6:25   ` Evgeniy Polyakov
2004-11-22 13:33   ` Adrian Bunk
2005-05-19  6:25     ` Adrian Bunk
2004-11-22 16:25     ` Evgeniy Polyakov
2005-05-19  6:25       ` Evgeniy Polyakov
2004-11-22 16:51       ` Adrian Bunk
2005-05-19  6:25         ` Adrian Bunk
2004-11-22 17:05         ` Evgeniy Polyakov
2005-05-19  6:25           ` Evgeniy Polyakov
2004-11-22 17:19           ` Adrian Bunk
2005-05-19  6:25             ` Adrian Bunk
2004-11-22 17:37             ` Evgeniy Polyakov
2005-05-19  6:25               ` Evgeniy Polyakov
2004-11-23  0:20               ` Adrian Bunk
2005-05-19  6:25                 ` Adrian Bunk
2004-11-23 10:34                 ` Evgeniy Polyakov
2005-05-19  6:25                   ` Evgeniy Polyakov
2004-11-25 15:56                   ` Adrian Bunk
2005-05-19  6:25                     ` Adrian Bunk
2004-11-29  1:52                     ` [2.6 patch] drivers/w1/: possible cleanups Adrian Bunk
2005-05-19  6:25                       ` Adrian Bunk
2004-11-29  5:12                       ` Evgeniy Polyakov
2005-05-19  6:25                         ` Evgeniy Polyakov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1113920787.29655.11.camel@uganda \
    --to=johnpol@2ka.mipt.ru \
    --cc=bunk@stusta.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sensors@stimpy.netroedge.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.