From: harry <harry@hebutterworth.freeserve.co.uk>
To: Muli Ben-Yehuda <mulix@mulix.org>
Cc: NAHieu <nahieu@gmail.com>,
xen-devel@lists.xensource.com,
Vincent Hanquez <vincent.hanquez@cl.cam.ac.uk>
Subject: Re: USB virt 2.6 split driver patch series
Date: Fri, 25 Nov 2005 19:16:14 +0000 [thread overview]
Message-ID: <1132946174.21175.33.camel@localhost.localdomain> (raw)
In-Reply-To: <20051121154453.GB20118@granada.merseine.nu>
On Mon, 2005-11-21 at 17:44 +0200, Muli Ben-Yehuda wrote:
> The thing is, the more readable the coding style, the more meaningful
> comments you'll get. I believe readable in this context is the Linux
> kernel coding style. Case in point - all of the comments so far have
> been about the coding style. Please fix it as soon as possible and
> repost so that we could move on to more substantial issues without
> getting hung up on the awkward (from a Linux kernel POV!) coding
> style.
I have now posted REVISION 2 of the first 13 of of the 17 patches which
includes all of the xenidc code. I have made a best effort attempt at
getting the coding style into line with what I understand to be
acceptable. As this is my first ever attempt at writing in the Linux
style I expect there are still issues. I am aware that there are a
couple of places where the code exceeds 80 columns. I intend to
abbreviate a few function names to fix this. I'm expecting to have to
do another pass over these patches so further feedback on style is
welcome but hopefully the code is now good enough that it will be
possible to review the content and provide some feedback on that as
well.
I'll follow up with revision 2 of the remaining 4 patches (containing
the actual USB driver) as I reformet them over the next few days.
Harry.
next prev parent reply other threads:[~2005-11-25 19:16 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-21 13:18 USB virt 2.6 split driver patch series harry
2005-11-21 13:49 ` Vincent Hanquez
2005-11-21 14:01 ` harry
2005-11-21 14:27 ` Vincent Hanquez
2005-11-21 14:29 ` Dave Feustel
2005-11-21 14:41 ` NAHieu
2005-11-21 15:14 ` harry
2005-11-21 15:27 ` NAHieu
2005-11-21 15:39 ` harry
2005-11-21 17:02 ` NAHieu
2005-11-21 17:17 ` harry
2005-11-22 1:59 ` NAHieu
2005-11-22 2:00 ` NAHieu
2005-11-22 10:24 ` harry
2005-11-22 11:07 ` Vincent Hanquez
2005-11-22 15:37 ` Anthony Liguori
2005-11-22 20:27 ` Vincent Hanquez
2005-11-21 15:44 ` Muli Ben-Yehuda
2005-11-21 18:49 ` Harry Butterworth
2005-11-21 18:58 ` Muli Ben-Yehuda
2005-11-25 19:16 ` harry [this message]
2005-11-21 17:26 ` Oleg Goldshmidt
2005-11-21 15:34 ` harry
2005-11-21 14:25 ` Dave Feustel
2005-11-21 14:36 ` Vincent Hanquez
2005-11-21 15:24 ` Dave Feustel
2005-11-21 16:03 ` Vincent Hanquez
2005-11-21 16:30 ` Dave Feustel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1132946174.21175.33.camel@localhost.localdomain \
--to=harry@hebutterworth.freeserve.co.uk \
--cc=mulix@mulix.org \
--cc=nahieu@gmail.com \
--cc=vincent.hanquez@cl.cam.ac.uk \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.