From: Vincent Hanquez <vincent.hanquez@cl.cam.ac.uk>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: xen-devel@lists.xensource.com, NAHieu <nahieu@gmail.com>,
harry <harry@hebutterworth.freeserve.co.uk>,
Vincent Hanquez <vincent.hanquez@cl.cam.ac.uk>
Subject: Re: USB virt 2.6 split driver patch series
Date: Tue, 22 Nov 2005 21:27:00 +0100 [thread overview]
Message-ID: <20051122202659.GA31571@snarc.org> (raw)
In-Reply-To: <43833B4E.8070502@us.ibm.com>
On Tue, Nov 22, 2005 at 09:37:50AM -0600, Anthony Liguori wrote:
> Harry's right, it's not allowed by the C standard.
still this is common accepted practice is kernel code ...
(no glibc included/linked, gcc specific)
> FWIW, I don't think it's all that common to use underscores to denote
> functions as private when you can just mark them static.
grep "__[a-z]" | grep "EXPORT" in linux kernel source you'll be surprise.
most kernels-code reason to provide both function (__fctname and fctname) is:
- one is lock free, the other lock what is necessary.
- one test some conditions, the other doesn't
and probably some others reasons ..
Cheers,
--
Vincent Hanquez
next prev parent reply other threads:[~2005-11-22 20:27 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-21 13:18 USB virt 2.6 split driver patch series harry
2005-11-21 13:49 ` Vincent Hanquez
2005-11-21 14:01 ` harry
2005-11-21 14:27 ` Vincent Hanquez
2005-11-21 14:29 ` Dave Feustel
2005-11-21 14:41 ` NAHieu
2005-11-21 15:14 ` harry
2005-11-21 15:27 ` NAHieu
2005-11-21 15:39 ` harry
2005-11-21 17:02 ` NAHieu
2005-11-21 17:17 ` harry
2005-11-22 1:59 ` NAHieu
2005-11-22 2:00 ` NAHieu
2005-11-22 10:24 ` harry
2005-11-22 11:07 ` Vincent Hanquez
2005-11-22 15:37 ` Anthony Liguori
2005-11-22 20:27 ` Vincent Hanquez [this message]
2005-11-21 15:44 ` Muli Ben-Yehuda
2005-11-21 18:49 ` Harry Butterworth
2005-11-21 18:58 ` Muli Ben-Yehuda
2005-11-25 19:16 ` harry
2005-11-21 17:26 ` Oleg Goldshmidt
2005-11-21 15:34 ` harry
2005-11-21 14:25 ` Dave Feustel
2005-11-21 14:36 ` Vincent Hanquez
2005-11-21 15:24 ` Dave Feustel
2005-11-21 16:03 ` Vincent Hanquez
2005-11-21 16:30 ` Dave Feustel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051122202659.GA31571@snarc.org \
--to=vincent.hanquez@cl.cam.ac.uk \
--cc=aliguori@us.ibm.com \
--cc=harry@hebutterworth.freeserve.co.uk \
--cc=nahieu@gmail.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.