All of lore.kernel.org
 help / color / mirror / Atom feed
From: harry <harry@hebutterworth.freeserve.co.uk>
To: xen-devel@lists.xensource.com
Cc: Vincent Hanquez <vincent.hanquez@cl.cam.ac.uk>
Subject: Re: USB virt 2.6 split driver patch series
Date: Mon, 21 Nov 2005 15:34:47 +0000	[thread overview]
Message-ID: <1132587287.31295.151.camel@localhost.localdomain> (raw)
In-Reply-To: <m3br0d52ud.fsf@goldshmidt.org>

On Mon, 2005-11-21 at 17:26 +0000, Oleg Goldshmidt wrote:

> Another style comment that I have is that I think that
> 
> struct xenidc_channel_struct {
> 	void (*submit_message)
> 	 (xenidc_channel * channel, xenidc_channel_message * message);
> 
> is inferior to
> 
> struct xenidc_channel_struct {
> 	void (*submit_message)(xenidc_channel * channel,
> 		               xenidc_channel_message * message);
> 
> in terms of readability.

Thanks.  Yes, I agree. I left it the way that Lindent formatted it but I will do it this way on the manual formatting pass.

  reply	other threads:[~2005-11-21 15:34 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-21 13:18 USB virt 2.6 split driver patch series harry
2005-11-21 13:49 ` Vincent Hanquez
2005-11-21 14:01   ` harry
2005-11-21 14:27     ` Vincent Hanquez
2005-11-21 14:29     ` Dave Feustel
2005-11-21 14:41     ` NAHieu
2005-11-21 15:14       ` harry
2005-11-21 15:27         ` NAHieu
2005-11-21 15:39           ` harry
2005-11-21 17:02             ` NAHieu
2005-11-21 17:17               ` harry
2005-11-22  1:59                 ` NAHieu
2005-11-22  2:00                   ` NAHieu
2005-11-22 10:24                     ` harry
2005-11-22 11:07                       ` Vincent Hanquez
2005-11-22 15:37                         ` Anthony Liguori
2005-11-22 20:27                           ` Vincent Hanquez
2005-11-21 15:44         ` Muli Ben-Yehuda
2005-11-21 18:49           ` Harry Butterworth
2005-11-21 18:58             ` Muli Ben-Yehuda
2005-11-25 19:16           ` harry
2005-11-21 17:26     ` Oleg Goldshmidt
2005-11-21 15:34       ` harry [this message]
2005-11-21 14:25   ` Dave Feustel
2005-11-21 14:36     ` Vincent Hanquez
2005-11-21 15:24       ` Dave Feustel
2005-11-21 16:03         ` Vincent Hanquez
2005-11-21 16:30           ` Dave Feustel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1132587287.31295.151.camel@localhost.localdomain \
    --to=harry@hebutterworth.freeserve.co.uk \
    --cc=vincent.hanquez@cl.cam.ac.uk \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.