Re: USB virt 2.6 split driver patch series

[Dave Feustel <dfeustel@verizon.net>]

On Monday 21 November 2005 11:03, Vincent Hanquez wrote:
> On Mon, Nov 21, 2005 at 10:24:11AM -0500, Dave Feustel wrote:
> > Thanks for posting the example with explanation.
> > What about this example bothers you and makes
> > you think this use of brackets should not be permitted
> > (if in fact this is your position)?
> 
> [ oleg's answer is pretty much what I think ]
> 
> but yeah, my main reason would be that it deepens the code nesting
> unnecessarily; that's really bad that the left half (or more) of the 80
> columns is blank.
> 
> you end up doing code in the [50:80] range,
> 
> like:
> 					big_name_of_function(do_something,
> 					                     1 + 1542,
> 					                     something_else);
> instead of:
> 
> 	big_name_of_function(do_something, 1 + 1542, something_else);

I hadn't thought of that, but I have run into exactly the kind of code that you describe. 
It's definitely a PITA to work with.

-- 
Switch to Secure OpenBSD with a KDE desktop!!!
NOW with Virtual PC OS support via QEMU and
Beowulf clustering using PETSc and MPICH2!