All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Takashi Iwai <tiwai@suse.de>
Cc: linuxppc-dev@ozlabs.org, alsa-devel@alsa-project.org
Subject: Re: [RFC 4/7] snd-aoa: add codecs
Date: Tue, 30 May 2006 15:26:10 +0200	[thread overview]
Message-ID: <1148995575.4372.5.camel@johannes> (raw)
In-Reply-To: <s5hr72bbqfm.wl%tiwai@suse.de>


[-- Attachment #1.1: Type: text/plain, Size: 1035 bytes --]

> > > > +	return 1;
> > > 
> > > The put callback is supposed to return 0 if the values are unchanged
> > > (although most apps ignore the return value).
> > 
> > Does it have to? This way there's an event, but...
> 
> Yes, in principle.  As mentioned, it works even without the check,
> though.

Hmm. I thought it worked like this:
 0    -> no change
 1    -> change applied, and other apps are notified, 0 returned to the app
-err  -> error returned to app

Is that wrong?


> Well, I meant the position of asterisk to follow the conventional C
> coding style.  Of course it should be static.

Ah. Yeah, I'll see to that and probably just Lindent the files (cleaning
up after it...)

> The driver should give up the initialization and fail to load.
> Usually the error from snd_ctl_add() is critical, either no memory or
> a duplicated control element is found.

Hmm, that's a bit hard to do since the driver here consists of more than
one module, but I suppose I can do something about it.

johannes

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 793 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



[-- Attachment #3: Type: text/plain, Size: 161 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/alsa-devel

WARNING: multiple messages have this Message-ID (diff)
From: Johannes Berg <johannes@sipsolutions.net>
To: Takashi Iwai <tiwai@suse.de>
Cc: linuxppc-dev@ozlabs.org, alsa-devel@alsa-project.org
Subject: Re: [Alsa-devel] [RFC 4/7] snd-aoa: add codecs
Date: Tue, 30 May 2006 15:26:10 +0200	[thread overview]
Message-ID: <1148995575.4372.5.camel@johannes> (raw)
In-Reply-To: <s5hr72bbqfm.wl%tiwai@suse.de>

[-- Attachment #1: Type: text/plain, Size: 1035 bytes --]

> > > > +	return 1;
> > > 
> > > The put callback is supposed to return 0 if the values are unchanged
> > > (although most apps ignore the return value).
> > 
> > Does it have to? This way there's an event, but...
> 
> Yes, in principle.  As mentioned, it works even without the check,
> though.

Hmm. I thought it worked like this:
 0    -> no change
 1    -> change applied, and other apps are notified, 0 returned to the app
-err  -> error returned to app

Is that wrong?


> Well, I meant the position of asterisk to follow the conventional C
> coding style.  Of course it should be static.

Ah. Yeah, I'll see to that and probably just Lindent the files (cleaning
up after it...)

> The driver should give up the initialization and fail to load.
> Usually the error from snd_ctl_add() is critical, either no memory or
> a duplicated control element is found.

Hmm, that's a bit hard to do since the driver here consists of more than
one module, but I suppose I can do something about it.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 793 bytes --]

  reply	other threads:[~2006-05-30 13:26 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-28 19:00 [RFC 0/7] snd-aoa: add snd-aoa Johannes Berg
2006-05-28 19:00 ` [RFC 1/7] snd-aoa: add aoa header files Johannes Berg
2006-05-28 19:00   ` Johannes Berg
2006-05-28 19:00 ` [RFC 2/7] snd-aoa: add aoa core Johannes Berg
2006-05-28 19:00   ` Johannes Berg
2006-05-29 10:57   ` Takashi Iwai
2006-05-29 10:57     ` [Alsa-devel] " Takashi Iwai
2006-05-30 12:44     ` Johannes Berg
2006-05-30 13:20       ` Takashi Iwai
2006-05-30 13:20         ` [Alsa-devel] " Takashi Iwai
2006-05-30 12:44     ` Johannes Berg
2006-05-28 19:00 ` [RFC 3/7] snd-aoa: add soundbus and i2sbus Johannes Berg
2006-05-28 19:00 ` [RFC 4/7] snd-aoa: add codecs Johannes Berg
2006-05-28 19:00   ` Johannes Berg
2006-05-29 12:08   ` Takashi Iwai
2006-05-29 12:08     ` [Alsa-devel] " Takashi Iwai
2006-05-30 12:43     ` Johannes Berg
2006-05-30 13:19       ` Takashi Iwai
2006-05-30 13:19         ` [Alsa-devel] " Takashi Iwai
2006-05-30 13:26         ` Johannes Berg [this message]
2006-05-30 13:26           ` Johannes Berg
2006-05-30 13:35           ` Takashi Iwai
2006-05-30 13:35           ` [Alsa-devel] " Takashi Iwai
2006-05-30 13:39             ` Johannes Berg
2006-05-30 13:39               ` [Alsa-devel] " Johannes Berg
2006-05-30 13:48               ` Takashi Iwai
2006-05-30 13:48                 ` [Alsa-devel] " Takashi Iwai
2006-05-30 13:53                 ` Johannes Berg
2006-05-30 13:53                   ` [Alsa-devel] " Johannes Berg
2006-05-30 13:56                   ` Takashi Iwai
2006-05-30 13:56                     ` [Alsa-devel] " Takashi Iwai
2006-05-30 12:43     ` Johannes Berg
2006-05-28 19:00 ` [RFC 5/7] snd-aoa: add layout-id fabric Johannes Berg
2006-05-28 19:00   ` Johannes Berg
2006-05-29 12:14   ` Takashi Iwai
2006-05-29 12:14     ` [Alsa-devel] " Takashi Iwai
2006-05-30 12:37     ` Johannes Berg
2006-05-30 12:37       ` [Alsa-devel] " Johannes Berg
2006-05-28 19:00 ` [RFC 6/7] snd-aoa: add Kconfig and Makefile Johannes Berg
2006-05-28 19:00   ` Johannes Berg
2006-05-28 19:00 ` [RFC 7/7] snd-aoa: wire up aoa in sound/ Johannes Berg
2006-05-28 19:00   ` Johannes Berg
2006-05-28 19:10 ` [RFC 0/7] snd-aoa: add snd-aoa Johannes Berg
2006-05-29 10:12   ` Takashi Iwai
2006-05-30 12:37     ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1148995575.4372.5.camel@johannes \
    --to=johannes@sipsolutions.net \
    --cc=alsa-devel@alsa-project.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.